delete_scheduler_test.cc 33 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865
  1. // Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
  2. // This source code is licensed under both the GPLv2 (found in the
  3. // COPYING file in the root directory) and Apache 2.0 License
  4. // (found in the LICENSE.Apache file in the root directory).
  5. #include "file/delete_scheduler.h"
  6. #include <atomic>
  7. #include <cinttypes>
  8. #include <thread>
  9. #include <vector>
  10. #include "file/file_util.h"
  11. #include "file/sst_file_manager_impl.h"
  12. #include "rocksdb/env.h"
  13. #include "rocksdb/options.h"
  14. #include "test_util/sync_point.h"
  15. #include "test_util/testharness.h"
  16. #include "util/string_util.h"
  17. namespace ROCKSDB_NAMESPACE {
  18. class DeleteSchedulerTest : public testing::Test {
  19. public:
  20. DeleteSchedulerTest() : env_(Env::Default()) {
  21. const int kNumDataDirs = 3;
  22. dummy_files_dirs_.reserve(kNumDataDirs);
  23. for (size_t i = 0; i < kNumDataDirs; ++i) {
  24. dummy_files_dirs_.emplace_back(
  25. test::PerThreadDBPath(env_, "delete_scheduler_dummy_data_dir") +
  26. std::to_string(i));
  27. DestroyAndCreateDir(dummy_files_dirs_.back());
  28. }
  29. stats_ = ROCKSDB_NAMESPACE::CreateDBStatistics();
  30. }
  31. ~DeleteSchedulerTest() override {
  32. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  33. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({});
  34. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
  35. for (const auto& dummy_files_dir : dummy_files_dirs_) {
  36. EXPECT_OK(DestroyDir(env_, dummy_files_dir));
  37. }
  38. }
  39. void DestroyAndCreateDir(const std::string& dir) {
  40. ASSERT_OK(DestroyDir(env_, dir));
  41. EXPECT_OK(env_->CreateDir(dir));
  42. }
  43. int CountNormalFiles(size_t dummy_files_dirs_idx = 0) {
  44. std::vector<std::string> files_in_dir;
  45. EXPECT_OK(env_->GetChildren(dummy_files_dirs_[dummy_files_dirs_idx],
  46. &files_in_dir));
  47. int normal_cnt = 0;
  48. for (auto& f : files_in_dir) {
  49. if (!DeleteScheduler::IsTrashFile(f)) {
  50. normal_cnt++;
  51. }
  52. }
  53. return normal_cnt;
  54. }
  55. int CountTrashFiles(size_t dummy_files_dirs_idx = 0) {
  56. std::vector<std::string> files_in_dir;
  57. EXPECT_OK(env_->GetChildren(dummy_files_dirs_[dummy_files_dirs_idx],
  58. &files_in_dir));
  59. int trash_cnt = 0;
  60. for (auto& f : files_in_dir) {
  61. if (DeleteScheduler::IsTrashFile(f)) {
  62. trash_cnt++;
  63. }
  64. }
  65. return trash_cnt;
  66. }
  67. std::string NewDummyFile(const std::string& file_name, uint64_t size = 1024,
  68. size_t dummy_files_dirs_idx = 0, bool track = true) {
  69. std::string file_path =
  70. dummy_files_dirs_[dummy_files_dirs_idx] + "/" + file_name;
  71. std::unique_ptr<WritableFile> f;
  72. EXPECT_OK(env_->NewWritableFile(file_path, &f, EnvOptions()));
  73. std::string data(size, 'A');
  74. EXPECT_OK(f->Append(data));
  75. EXPECT_OK(f->Close());
  76. if (track) {
  77. EXPECT_OK(sst_file_mgr_->OnAddFile(file_path));
  78. }
  79. return file_path;
  80. }
  81. void NewDeleteScheduler() {
  82. // Tests in this file are for DeleteScheduler component and don't create any
  83. // DBs, so we need to set max_trash_db_ratio to 100% (instead of default
  84. // 25%)
  85. sst_file_mgr_.reset(
  86. new SstFileManagerImpl(env_->GetSystemClock(), env_->GetFileSystem(),
  87. nullptr, rate_bytes_per_sec_,
  88. /* max_trash_db_ratio= */ 1.1, 128 * 1024));
  89. delete_scheduler_ = sst_file_mgr_->delete_scheduler();
  90. sst_file_mgr_->SetStatisticsPtr(stats_);
  91. }
  92. Env* env_;
  93. std::vector<std::string> dummy_files_dirs_;
  94. int64_t rate_bytes_per_sec_;
  95. DeleteScheduler* delete_scheduler_;
  96. std::unique_ptr<SstFileManagerImpl> sst_file_mgr_;
  97. std::shared_ptr<Statistics> stats_;
  98. };
  99. // Test the basic functionality of DeleteScheduler (Rate Limiting).
  100. // 1- Create 100 dummy files
  101. // 2- Delete the 100 dummy files using DeleteScheduler
  102. // --- Hold DeleteScheduler::BackgroundEmptyTrash ---
  103. // 3- Wait for DeleteScheduler to delete all files in trash
  104. // 4- Verify that BackgroundEmptyTrash used to correct penlties for the files
  105. // 5- Make sure that all created files were completely deleted
  106. TEST_F(DeleteSchedulerTest, BasicRateLimiting) {
  107. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  108. {"DeleteSchedulerTest::BasicRateLimiting:1",
  109. "DeleteScheduler::BackgroundEmptyTrash"},
  110. });
  111. std::vector<uint64_t> penalties;
  112. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  113. "DeleteScheduler::BackgroundEmptyTrash:Wait",
  114. [&](void* arg) { penalties.push_back(*(static_cast<uint64_t*>(arg))); });
  115. int dir_synced = 0;
  116. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  117. "DeleteScheduler::DeleteTrashFile::AfterSyncDir", [&](void* arg) {
  118. dir_synced++;
  119. std::string* dir = static_cast<std::string*>(arg);
  120. EXPECT_EQ(dummy_files_dirs_[0], *dir);
  121. });
  122. int num_files = 100; // 100 files
  123. uint64_t file_size = 1024; // every file is 1 kb
  124. std::vector<uint64_t> delete_kbs_per_sec = {512, 200, 100, 50, 25};
  125. for (size_t t = 0; t < delete_kbs_per_sec.size(); t++) {
  126. penalties.clear();
  127. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
  128. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  129. DestroyAndCreateDir(dummy_files_dirs_[0]);
  130. rate_bytes_per_sec_ = delete_kbs_per_sec[t] * 1024;
  131. NewDeleteScheduler();
  132. dir_synced = 0;
  133. // Create 100 dummy files, every file is 1 Kb
  134. std::vector<std::string> generated_files;
  135. for (int i = 0; i < num_files; i++) {
  136. std::string file_name = "file" + std::to_string(i) + ".data";
  137. generated_files.push_back(NewDummyFile(file_name, file_size));
  138. }
  139. // Delete dummy files and measure time spent to empty trash
  140. for (int i = 0; i < num_files; i++) {
  141. ASSERT_OK(delete_scheduler_->DeleteFile(generated_files[i],
  142. dummy_files_dirs_[0]));
  143. }
  144. ASSERT_EQ(CountNormalFiles(), 0);
  145. uint64_t delete_start_time = env_->NowMicros();
  146. TEST_SYNC_POINT("DeleteSchedulerTest::BasicRateLimiting:1");
  147. delete_scheduler_->WaitForEmptyTrash();
  148. uint64_t time_spent_deleting = env_->NowMicros() - delete_start_time;
  149. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  150. ASSERT_EQ(bg_errors.size(), 0);
  151. uint64_t total_files_size = 0;
  152. uint64_t expected_penlty = 0;
  153. ASSERT_EQ(penalties.size(), num_files);
  154. for (int i = 0; i < num_files; i++) {
  155. total_files_size += file_size;
  156. expected_penlty = ((total_files_size * 1000000) / rate_bytes_per_sec_);
  157. ASSERT_EQ(expected_penlty, penalties[i]);
  158. }
  159. ASSERT_GT(time_spent_deleting, expected_penlty * 0.9);
  160. ASSERT_EQ(num_files, dir_synced);
  161. ASSERT_EQ(CountTrashFiles(), 0);
  162. ASSERT_EQ(num_files, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  163. ASSERT_EQ(num_files,
  164. stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  165. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  166. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  167. }
  168. }
  169. TEST_F(DeleteSchedulerTest, MultiDirectoryDeletionsScheduled) {
  170. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  171. {"DeleteSchedulerTest::MultiDbPathDeletionsScheduled:1",
  172. "DeleteScheduler::BackgroundEmptyTrash"},
  173. });
  174. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  175. rate_bytes_per_sec_ = 1 << 20; // 1MB
  176. NewDeleteScheduler();
  177. // Generate dummy files in multiple directories
  178. const size_t kNumFiles = dummy_files_dirs_.size();
  179. const size_t kFileSize = 1 << 10; // 1KB
  180. std::vector<std::string> generated_files;
  181. for (size_t i = 0; i < kNumFiles; i++) {
  182. generated_files.push_back(NewDummyFile("file", kFileSize, i));
  183. ASSERT_EQ(1, CountNormalFiles(i));
  184. }
  185. // Mark dummy files as trash
  186. for (size_t i = 0; i < kNumFiles; i++) {
  187. ASSERT_OK(delete_scheduler_->DeleteFile(generated_files[i], ""));
  188. ASSERT_EQ(0, CountNormalFiles(i));
  189. ASSERT_EQ(1, CountTrashFiles(i));
  190. }
  191. TEST_SYNC_POINT("DeleteSchedulerTest::MultiDbPathDeletionsScheduled:1");
  192. delete_scheduler_->WaitForEmptyTrash();
  193. // Verify dummy files eventually got deleted
  194. for (size_t i = 0; i < kNumFiles; i++) {
  195. ASSERT_EQ(0, CountNormalFiles(i));
  196. ASSERT_EQ(0, CountTrashFiles(i));
  197. }
  198. ASSERT_EQ(kNumFiles, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  199. ASSERT_EQ(kNumFiles,
  200. stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  201. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  202. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  203. }
  204. // Same as the BasicRateLimiting test but delete files in multiple threads.
  205. // 1- Create 100 dummy files
  206. // 2- Delete the 100 dummy files using DeleteScheduler using 10 threads
  207. // --- Hold DeleteScheduler::BackgroundEmptyTrash ---
  208. // 3- Wait for DeleteScheduler to delete all files in queue
  209. // 4- Verify that BackgroundEmptyTrash used to correct penlties for the files
  210. // 5- Make sure that all created files were completely deleted
  211. TEST_F(DeleteSchedulerTest, RateLimitingMultiThreaded) {
  212. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  213. {"DeleteSchedulerTest::RateLimitingMultiThreaded:1",
  214. "DeleteScheduler::BackgroundEmptyTrash"},
  215. });
  216. std::vector<uint64_t> penalties;
  217. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  218. "DeleteScheduler::BackgroundEmptyTrash:Wait",
  219. [&](void* arg) { penalties.push_back(*(static_cast<uint64_t*>(arg))); });
  220. int thread_cnt = 10;
  221. int num_files = 10; // 10 files per thread
  222. uint64_t file_size = 1024; // every file is 1 kb
  223. std::vector<uint64_t> delete_kbs_per_sec = {512, 200, 100, 50, 25};
  224. for (size_t t = 0; t < delete_kbs_per_sec.size(); t++) {
  225. penalties.clear();
  226. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
  227. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  228. DestroyAndCreateDir(dummy_files_dirs_[0]);
  229. rate_bytes_per_sec_ = delete_kbs_per_sec[t] * 1024;
  230. NewDeleteScheduler();
  231. // Create 100 dummy files, every file is 1 Kb
  232. std::vector<std::string> generated_files;
  233. for (int i = 0; i < num_files * thread_cnt; i++) {
  234. std::string file_name = "file" + std::to_string(i) + ".data";
  235. generated_files.push_back(NewDummyFile(file_name, file_size));
  236. }
  237. // Delete dummy files using 10 threads and measure time spent to empty trash
  238. std::atomic<int> thread_num(0);
  239. std::vector<port::Thread> threads;
  240. std::function<void()> delete_thread = [&]() {
  241. int idx = thread_num.fetch_add(1);
  242. int range_start = idx * num_files;
  243. int range_end = range_start + num_files;
  244. for (int j = range_start; j < range_end; j++) {
  245. ASSERT_OK(delete_scheduler_->DeleteFile(generated_files[j], ""));
  246. }
  247. };
  248. for (int i = 0; i < thread_cnt; i++) {
  249. threads.emplace_back(delete_thread);
  250. }
  251. for (size_t i = 0; i < threads.size(); i++) {
  252. threads[i].join();
  253. }
  254. uint64_t delete_start_time = env_->NowMicros();
  255. TEST_SYNC_POINT("DeleteSchedulerTest::RateLimitingMultiThreaded:1");
  256. delete_scheduler_->WaitForEmptyTrash();
  257. uint64_t time_spent_deleting = env_->NowMicros() - delete_start_time;
  258. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  259. ASSERT_EQ(bg_errors.size(), 0);
  260. uint64_t total_files_size = 0;
  261. uint64_t expected_penlty = 0;
  262. ASSERT_EQ(penalties.size(), num_files * thread_cnt);
  263. for (int i = 0; i < num_files * thread_cnt; i++) {
  264. total_files_size += file_size;
  265. expected_penlty = ((total_files_size * 1000000) / rate_bytes_per_sec_);
  266. ASSERT_EQ(expected_penlty, penalties[i]);
  267. }
  268. ASSERT_GT(time_spent_deleting, expected_penlty * 0.9);
  269. ASSERT_EQ(CountNormalFiles(), 0);
  270. ASSERT_EQ(CountTrashFiles(), 0);
  271. int total_num_files = num_files * thread_cnt;
  272. ASSERT_EQ(total_num_files,
  273. stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  274. ASSERT_EQ(total_num_files,
  275. stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  276. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  277. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  278. }
  279. }
  280. // Disable rate limiting by setting rate_bytes_per_sec_ to 0 and make sure
  281. // that when DeleteScheduler delete a file it delete it immediately and don't
  282. // move it to trash
  283. TEST_F(DeleteSchedulerTest, DisableRateLimiting) {
  284. int bg_delete_file = 0;
  285. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  286. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  287. [&](void* /*arg*/) { bg_delete_file++; });
  288. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  289. rate_bytes_per_sec_ = 0;
  290. NewDeleteScheduler();
  291. constexpr int num_files = 10;
  292. for (int i = 0; i < num_files; i++) {
  293. // Every file we delete will be deleted immediately
  294. std::string dummy_file = NewDummyFile("dummy.data");
  295. ASSERT_OK(delete_scheduler_->DeleteFile(dummy_file, ""));
  296. ASSERT_TRUE(env_->FileExists(dummy_file).IsNotFound());
  297. ASSERT_EQ(CountNormalFiles(), 0);
  298. ASSERT_EQ(CountTrashFiles(), 0);
  299. }
  300. ASSERT_EQ(bg_delete_file, 0);
  301. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  302. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  303. ASSERT_EQ(num_files,
  304. stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  305. ASSERT_FALSE(delete_scheduler_->NewTrashBucket().has_value());
  306. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  307. }
  308. // Testing that moving files to trash with the same name is not a problem
  309. // 1- Create 10 files with the same name "conflict.data"
  310. // 2- Delete the 10 files using DeleteScheduler
  311. // 3- Make sure that trash directory contain 10 files ("conflict.data" x 10)
  312. // --- Hold DeleteScheduler::BackgroundEmptyTrash ---
  313. // 4- Make sure that files are deleted from trash
  314. TEST_F(DeleteSchedulerTest, ConflictNames) {
  315. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  316. {"DeleteSchedulerTest::ConflictNames:1",
  317. "DeleteScheduler::BackgroundEmptyTrash"},
  318. });
  319. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  320. rate_bytes_per_sec_ = 1024 * 1024; // 1 Mb/sec
  321. NewDeleteScheduler();
  322. // Create "conflict.data" and move it to trash 10 times
  323. for (int i = 0; i < 10; i++) {
  324. std::string dummy_file = NewDummyFile("conflict.data");
  325. ASSERT_OK(delete_scheduler_->DeleteFile(dummy_file, ""));
  326. }
  327. ASSERT_EQ(CountNormalFiles(), 0);
  328. // 10 files ("conflict.data" x 10) in trash
  329. ASSERT_EQ(CountTrashFiles(), 10);
  330. // Hold BackgroundEmptyTrash
  331. TEST_SYNC_POINT("DeleteSchedulerTest::ConflictNames:1");
  332. delete_scheduler_->WaitForEmptyTrash();
  333. ASSERT_EQ(CountTrashFiles(), 0);
  334. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  335. ASSERT_EQ(bg_errors.size(), 0);
  336. ASSERT_EQ(10, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  337. ASSERT_EQ(10, stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  338. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  339. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  340. }
  341. // 1- Create 10 dummy files
  342. // 2- Delete the 10 files using DeleteScheduler (move them to trsah)
  343. // 3- Delete the 10 files directly (using env_->DeleteFile)
  344. // --- Hold DeleteScheduler::BackgroundEmptyTrash ---
  345. // 4- Make sure that DeleteScheduler failed to delete the 10 files and
  346. // reported 10 background errors
  347. TEST_F(DeleteSchedulerTest, BackgroundError) {
  348. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  349. {"DeleteSchedulerTest::BackgroundError:1",
  350. "DeleteScheduler::BackgroundEmptyTrash"},
  351. });
  352. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  353. rate_bytes_per_sec_ = 1024 * 1024; // 1 Mb/sec
  354. NewDeleteScheduler();
  355. // Generate 10 dummy files and move them to trash
  356. for (int i = 0; i < 10; i++) {
  357. std::string file_name = "data_" + std::to_string(i) + ".data";
  358. ASSERT_OK(delete_scheduler_->DeleteFile(NewDummyFile(file_name), ""));
  359. }
  360. ASSERT_EQ(CountNormalFiles(), 0);
  361. ASSERT_EQ(CountTrashFiles(), 10);
  362. // Delete 10 files from trash, this will cause background errors in
  363. // BackgroundEmptyTrash since we already deleted the files it was
  364. // goind to delete
  365. for (int i = 0; i < 10; i++) {
  366. std::string file_name = "data_" + std::to_string(i) + ".data.trash";
  367. ASSERT_OK(env_->DeleteFile(dummy_files_dirs_[0] + "/" + file_name));
  368. }
  369. // Hold BackgroundEmptyTrash
  370. TEST_SYNC_POINT("DeleteSchedulerTest::BackgroundError:1");
  371. delete_scheduler_->WaitForEmptyTrash();
  372. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  373. ASSERT_EQ(bg_errors.size(), 10);
  374. for (const auto& it : bg_errors) {
  375. ASSERT_TRUE(it.second.IsPathNotFound());
  376. }
  377. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  378. }
  379. // 1- Create kTestFileNum dummy files
  380. // 2- Delete kTestFileNum dummy files using DeleteScheduler
  381. // 3- Wait for DeleteScheduler to delete all files in queue
  382. // 4- Make sure all files in trash directory were deleted
  383. // 5- Repeat previous steps 5 times
  384. TEST_F(DeleteSchedulerTest, StartBGEmptyTrashMultipleTimes) {
  385. constexpr int kTestFileNum = 10;
  386. std::atomic_int bg_delete_file = 0;
  387. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  388. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  389. [&](void* /*arg*/) { bg_delete_file++; });
  390. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  391. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / sec
  392. NewDeleteScheduler();
  393. // If trash file is generated faster than deleting, delete_scheduler will
  394. // delete it directly instead of waiting for background trash empty thread to
  395. // clean it. Set the ratio higher to avoid that.
  396. sst_file_mgr_->SetMaxTrashDBRatio(kTestFileNum + 1);
  397. // Move files to trash, wait for empty trash, start again
  398. for (int run = 1; run <= 5; run++) {
  399. // Generate kTestFileNum dummy files and move them to trash
  400. for (int i = 0; i < kTestFileNum; i++) {
  401. std::string file_name = "data_" + std::to_string(i) + ".data";
  402. ASSERT_OK(delete_scheduler_->DeleteFile(NewDummyFile(file_name), ""));
  403. }
  404. ASSERT_EQ(CountNormalFiles(), 0);
  405. delete_scheduler_->WaitForEmptyTrash();
  406. ASSERT_EQ(bg_delete_file, kTestFileNum * run);
  407. ASSERT_EQ(CountTrashFiles(), 0);
  408. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  409. ASSERT_EQ(bg_errors.size(), 0);
  410. ASSERT_EQ(kTestFileNum, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  411. ASSERT_EQ(kTestFileNum,
  412. stats_->getAndResetTickerCount(FILES_DELETED_FROM_TRASH_QUEUE));
  413. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  414. }
  415. ASSERT_EQ(bg_delete_file, 5 * kTestFileNum);
  416. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  417. }
  418. TEST_F(DeleteSchedulerTest, DeletePartialFile) {
  419. int bg_delete_file = 0;
  420. int bg_fsync = 0;
  421. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  422. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  423. [&](void*) { bg_delete_file++; });
  424. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  425. "DeleteScheduler::DeleteTrashFile:Fsync", [&](void*) { bg_fsync++; });
  426. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  427. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / sec
  428. NewDeleteScheduler();
  429. // Should delete in 4 batch
  430. ASSERT_OK(
  431. delete_scheduler_->DeleteFile(NewDummyFile("data_1", 500 * 1024), ""));
  432. ASSERT_OK(
  433. delete_scheduler_->DeleteFile(NewDummyFile("data_2", 100 * 1024), ""));
  434. // Should delete in 2 batch
  435. ASSERT_OK(
  436. delete_scheduler_->DeleteFile(NewDummyFile("data_2", 200 * 1024), ""));
  437. delete_scheduler_->WaitForEmptyTrash();
  438. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  439. ASSERT_EQ(bg_errors.size(), 0);
  440. ASSERT_EQ(7, bg_delete_file);
  441. ASSERT_EQ(4, bg_fsync);
  442. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  443. }
  444. #ifdef OS_LINUX
  445. TEST_F(DeleteSchedulerTest, NoPartialDeleteWithLink) {
  446. int bg_delete_file = 0;
  447. int bg_fsync = 0;
  448. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  449. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  450. [&](void*) { bg_delete_file++; });
  451. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  452. "DeleteScheduler::DeleteTrashFile:Fsync", [&](void*) { bg_fsync++; });
  453. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  454. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / sec
  455. NewDeleteScheduler();
  456. std::string file1 = NewDummyFile("data_1", 500 * 1024);
  457. std::string file2 = NewDummyFile("data_2", 100 * 1024);
  458. ASSERT_OK(env_->LinkFile(file1, dummy_files_dirs_[0] + "/data_1b"));
  459. ASSERT_OK(env_->LinkFile(file2, dummy_files_dirs_[0] + "/data_2b"));
  460. // Should delete in 4 batch if there is no hardlink
  461. ASSERT_OK(delete_scheduler_->DeleteFile(file1, ""));
  462. ASSERT_OK(delete_scheduler_->DeleteFile(file2, ""));
  463. delete_scheduler_->WaitForEmptyTrash();
  464. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  465. ASSERT_EQ(bg_errors.size(), 0);
  466. ASSERT_EQ(2, bg_delete_file);
  467. ASSERT_EQ(0, bg_fsync);
  468. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  469. }
  470. #endif
  471. // 1- Create a DeleteScheduler with very slow rate limit (1 Byte / sec)
  472. // 2- Delete 100 files using DeleteScheduler
  473. // 3- Delete the DeleteScheduler (call the destructor while queue is not empty)
  474. // 4- Make sure that not all files were deleted from trash and that
  475. // DeleteScheduler background thread did not delete all files
  476. TEST_F(DeleteSchedulerTest, DestructorWithNonEmptyQueue) {
  477. int bg_delete_file = 0;
  478. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  479. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  480. [&](void* /*arg*/) { bg_delete_file++; });
  481. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  482. rate_bytes_per_sec_ = 1; // 1 Byte / sec
  483. NewDeleteScheduler();
  484. for (int i = 0; i < 100; i++) {
  485. std::string file_name = "data_" + std::to_string(i) + ".data";
  486. ASSERT_OK(delete_scheduler_->DeleteFile(NewDummyFile(file_name), ""));
  487. }
  488. // Deleting 100 files will need >28 hours to delete
  489. // we will delete the DeleteScheduler while delete queue is not empty
  490. sst_file_mgr_.reset();
  491. ASSERT_LT(bg_delete_file, 100);
  492. ASSERT_GT(CountTrashFiles(), 0);
  493. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  494. }
  495. TEST_F(DeleteSchedulerTest, DISABLED_DynamicRateLimiting1) {
  496. std::vector<uint64_t> penalties;
  497. int bg_delete_file = 0;
  498. int fg_delete_file = 0;
  499. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  500. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  501. [&](void* /*arg*/) { bg_delete_file++; });
  502. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  503. "DeleteScheduler::DeleteFile", [&](void* /*arg*/) { fg_delete_file++; });
  504. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  505. "DeleteScheduler::BackgroundEmptyTrash:Wait",
  506. [&](void* arg) { penalties.push_back(*(static_cast<int*>(arg))); });
  507. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({
  508. {"DeleteSchedulerTest::DynamicRateLimiting1:1",
  509. "DeleteScheduler::BackgroundEmptyTrash"},
  510. });
  511. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  512. rate_bytes_per_sec_ = 0; // Disable rate limiting initially
  513. NewDeleteScheduler();
  514. int num_files = 10; // 10 files
  515. uint64_t file_size = 1024; // every file is 1 kb
  516. std::vector<int64_t> delete_kbs_per_sec = {512, 200, 0, 100, 50, -2, 25};
  517. for (size_t t = 0; t < delete_kbs_per_sec.size(); t++) {
  518. penalties.clear();
  519. bg_delete_file = 0;
  520. fg_delete_file = 0;
  521. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
  522. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  523. DestroyAndCreateDir(dummy_files_dirs_[0]);
  524. rate_bytes_per_sec_ = delete_kbs_per_sec[t] * 1024;
  525. delete_scheduler_->SetRateBytesPerSecond(rate_bytes_per_sec_);
  526. // Create 100 dummy files, every file is 1 Kb
  527. std::vector<std::string> generated_files;
  528. for (int i = 0; i < num_files; i++) {
  529. std::string file_name = "file" + std::to_string(i) + ".data";
  530. generated_files.push_back(NewDummyFile(file_name, file_size));
  531. }
  532. // Delete dummy files and measure time spent to empty trash
  533. for (int i = 0; i < num_files; i++) {
  534. ASSERT_OK(delete_scheduler_->DeleteFile(generated_files[i], ""));
  535. }
  536. ASSERT_EQ(CountNormalFiles(), 0);
  537. if (rate_bytes_per_sec_ > 0) {
  538. uint64_t delete_start_time = env_->NowMicros();
  539. TEST_SYNC_POINT("DeleteSchedulerTest::DynamicRateLimiting1:1");
  540. delete_scheduler_->WaitForEmptyTrash();
  541. uint64_t time_spent_deleting = env_->NowMicros() - delete_start_time;
  542. auto bg_errors = delete_scheduler_->GetBackgroundErrors();
  543. ASSERT_EQ(bg_errors.size(), 0);
  544. uint64_t total_files_size = 0;
  545. uint64_t expected_penlty = 0;
  546. ASSERT_EQ(penalties.size(), num_files);
  547. for (int i = 0; i < num_files; i++) {
  548. total_files_size += file_size;
  549. expected_penlty = ((total_files_size * 1000000) / rate_bytes_per_sec_);
  550. ASSERT_EQ(expected_penlty, penalties[i]);
  551. }
  552. ASSERT_GT(time_spent_deleting, expected_penlty * 0.9);
  553. ASSERT_EQ(bg_delete_file, num_files);
  554. ASSERT_EQ(fg_delete_file, 0);
  555. } else {
  556. ASSERT_EQ(penalties.size(), 0);
  557. ASSERT_EQ(bg_delete_file, 0);
  558. ASSERT_EQ(fg_delete_file, num_files);
  559. }
  560. ASSERT_EQ(CountTrashFiles(), 0);
  561. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  562. }
  563. }
  564. TEST_F(DeleteSchedulerTest, ImmediateDeleteOn25PercDBSize) {
  565. int bg_delete_file = 0;
  566. int fg_delete_file = 0;
  567. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  568. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  569. [&](void* /*arg*/) { bg_delete_file++; });
  570. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  571. "DeleteScheduler::DeleteFile", [&](void* /*arg*/) { fg_delete_file++; });
  572. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  573. int num_files = 100; // 100 files
  574. uint64_t file_size = 1024 * 10; // 100 KB as a file size
  575. rate_bytes_per_sec_ = 1; // 1 byte per sec (very slow trash delete)
  576. NewDeleteScheduler();
  577. delete_scheduler_->SetMaxTrashDBRatio(0.25);
  578. std::vector<std::string> generated_files;
  579. for (int i = 0; i < num_files; i++) {
  580. std::string file_name = "file" + std::to_string(i) + ".data";
  581. generated_files.push_back(NewDummyFile(file_name, file_size));
  582. }
  583. for (std::string& file_name : generated_files) {
  584. ASSERT_OK(delete_scheduler_->DeleteFile(file_name, ""));
  585. }
  586. // When we end up with 26 files in trash we will start
  587. // deleting new files immediately
  588. ASSERT_EQ(fg_delete_file, 74);
  589. ASSERT_EQ(26, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  590. ASSERT_EQ(74, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  591. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  592. }
  593. TEST_F(DeleteSchedulerTest, IsTrashCheck) {
  594. // Trash files
  595. ASSERT_TRUE(DeleteScheduler::IsTrashFile("x.trash"));
  596. ASSERT_TRUE(DeleteScheduler::IsTrashFile(".trash"));
  597. ASSERT_TRUE(DeleteScheduler::IsTrashFile("abc.sst.trash"));
  598. ASSERT_TRUE(DeleteScheduler::IsTrashFile("/a/b/c/abc..sst.trash"));
  599. ASSERT_TRUE(DeleteScheduler::IsTrashFile("log.trash"));
  600. ASSERT_TRUE(DeleteScheduler::IsTrashFile("^^^^^.log.trash"));
  601. ASSERT_TRUE(DeleteScheduler::IsTrashFile("abc.t.trash"));
  602. // Not trash files
  603. ASSERT_FALSE(DeleteScheduler::IsTrashFile("abc.sst"));
  604. ASSERT_FALSE(DeleteScheduler::IsTrashFile("abc.txt"));
  605. ASSERT_FALSE(DeleteScheduler::IsTrashFile("/a/b/c/abc.sst"));
  606. ASSERT_FALSE(DeleteScheduler::IsTrashFile("/a/b/c/abc.sstrash"));
  607. ASSERT_FALSE(DeleteScheduler::IsTrashFile("^^^^^.trashh"));
  608. ASSERT_FALSE(DeleteScheduler::IsTrashFile("abc.ttrash"));
  609. ASSERT_FALSE(DeleteScheduler::IsTrashFile(".ttrash"));
  610. ASSERT_FALSE(DeleteScheduler::IsTrashFile("abc.trashx"));
  611. }
  612. TEST_F(DeleteSchedulerTest, DeleteAccountedAndUnaccountedFiles) {
  613. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / s
  614. NewDeleteScheduler();
  615. // Create 100 files, every file is 1 KB
  616. int num_files = 100; // 100 files
  617. uint64_t file_size = 1024; // 1 KB as a file size
  618. std::vector<std::string> generated_files;
  619. for (int i = 0; i < num_files; i++) {
  620. std::string file_name = "file" + std::to_string(i) + ".data";
  621. generated_files.push_back(NewDummyFile(file_name, file_size,
  622. /*dummy_files_dirs_idx*/ 0,
  623. /*track=*/false));
  624. }
  625. for (int i = 0; i < num_files; i++) {
  626. if (i % 2) {
  627. ASSERT_OK(sst_file_mgr_->OnAddFile(generated_files[i], file_size));
  628. ASSERT_OK(delete_scheduler_->DeleteFile(generated_files[i], ""));
  629. } else {
  630. ASSERT_OK(
  631. delete_scheduler_->DeleteUnaccountedFile(generated_files[i], ""));
  632. }
  633. }
  634. delete_scheduler_->WaitForEmptyTrash();
  635. ASSERT_EQ(0, delete_scheduler_->GetTotalTrashSize());
  636. ASSERT_EQ(0, sst_file_mgr_->GetTotalSize());
  637. }
  638. TEST_F(DeleteSchedulerTest, ConcurrentlyDeleteUnaccountedFilesInBuckets) {
  639. int bg_delete_file = 0;
  640. int fg_delete_file = 0;
  641. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  642. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  643. [&](void* /*arg*/) { bg_delete_file++; });
  644. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  645. "DeleteScheduler::DeleteFile", [&](void* /*arg*/) { fg_delete_file++; });
  646. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / s
  647. NewDeleteScheduler();
  648. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  649. // Create 1000 files, every file is 1 KB
  650. int num_files = 1000;
  651. uint64_t file_size = 1024; // 1 KB as a file size
  652. std::vector<std::string> generated_files;
  653. for (int i = 0; i < num_files; i++) {
  654. std::string file_name = "file" + std::to_string(i) + ".data";
  655. generated_files.push_back(NewDummyFile(file_name, file_size,
  656. /*dummy_files_dirs_idx*/ 0,
  657. /*track=*/false));
  658. }
  659. // Concurrently delete files in different buckets and check all the buckets
  660. // are empty.
  661. int thread_cnt = 10;
  662. int files_per_thread = 100;
  663. std::atomic<int> thread_num(0);
  664. std::vector<port::Thread> threads;
  665. std::function<void()> delete_thread = [&]() {
  666. std::optional<int32_t> bucket = delete_scheduler_->NewTrashBucket();
  667. ASSERT_TRUE(bucket.has_value());
  668. int idx = thread_num.fetch_add(1);
  669. int range_start = idx * files_per_thread;
  670. int range_end = range_start + files_per_thread;
  671. for (int j = range_start; j < range_end; j++) {
  672. ASSERT_OK(delete_scheduler_->DeleteUnaccountedFile(
  673. generated_files[j], "", /*false_bg=*/false, bucket));
  674. }
  675. delete_scheduler_->WaitForEmptyTrashBucket(bucket.value());
  676. };
  677. for (int i = 0; i < thread_cnt; i++) {
  678. threads.emplace_back(delete_thread);
  679. }
  680. for (size_t i = 0; i < threads.size(); i++) {
  681. threads[i].join();
  682. }
  683. ASSERT_EQ(0, delete_scheduler_->GetTotalTrashSize());
  684. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  685. ASSERT_EQ(1000, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  686. ASSERT_EQ(0, fg_delete_file);
  687. ASSERT_EQ(1000, bg_delete_file);
  688. // OK to re check an already empty bucket
  689. delete_scheduler_->WaitForEmptyTrashBucket(9);
  690. // Invalid bucket return too.
  691. delete_scheduler_->WaitForEmptyTrashBucket(100);
  692. std::optional<int32_t> next_bucket = delete_scheduler_->NewTrashBucket();
  693. ASSERT_TRUE(next_bucket.has_value());
  694. ASSERT_EQ(10, next_bucket.value());
  695. delete_scheduler_->WaitForEmptyTrashBucket(10);
  696. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  697. }
  698. TEST_F(DeleteSchedulerTest,
  699. ImmediatelyDeleteUnaccountedFilesWithRemainingLinks) {
  700. int bg_delete_file = 0;
  701. int fg_delete_file = 0;
  702. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  703. "DeleteScheduler::DeleteTrashFile:DeleteFile",
  704. [&](void* /*arg*/) { bg_delete_file++; });
  705. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  706. "DeleteScheduler::DeleteFile", [&](void* /*arg*/) { fg_delete_file++; });
  707. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  708. rate_bytes_per_sec_ = 1024 * 1024; // 1 MB / sec
  709. NewDeleteScheduler();
  710. std::string file1 = NewDummyFile("data_1", 500 * 1024,
  711. /*dummy_files_dirs_idx*/ 0, /*track=*/false);
  712. std::string file2 = NewDummyFile("data_2", 100 * 1024,
  713. /*dummy_files_dirs_idx*/ 0, /*track=*/false);
  714. ASSERT_OK(env_->LinkFile(file1, dummy_files_dirs_[0] + "/data_1b"));
  715. ASSERT_OK(env_->LinkFile(file2, dummy_files_dirs_[0] + "/data_2b"));
  716. // Should delete in 4 batch if there is no hardlink
  717. ASSERT_OK(
  718. delete_scheduler_->DeleteUnaccountedFile(file1, "", /*force_bg=*/false));
  719. ASSERT_OK(
  720. delete_scheduler_->DeleteUnaccountedFile(file2, "", /*force_bg=*/false));
  721. delete_scheduler_->WaitForEmptyTrash();
  722. ASSERT_EQ(0, delete_scheduler_->GetTotalTrashSize());
  723. ASSERT_EQ(0, bg_delete_file);
  724. ASSERT_EQ(2, fg_delete_file);
  725. ASSERT_EQ(0, stats_->getAndResetTickerCount(FILES_MARKED_TRASH));
  726. ASSERT_EQ(2, stats_->getAndResetTickerCount(FILES_DELETED_IMMEDIATELY));
  727. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  728. }
  729. } // namespace ROCKSDB_NAMESPACE
  730. int main(int argc, char** argv) {
  731. ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
  732. ::testing::InitGoogleTest(&argc, argv);
  733. return RUN_ALL_TESTS();
  734. }