db_compaction_test.cc 177 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167
  1. // Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
  2. // This source code is licensed under both the GPLv2 (found in the
  3. // COPYING file in the root directory) and Apache 2.0 License
  4. // (found in the LICENSE.Apache file in the root directory).
  5. //
  6. // Copyright (c) 2011 The LevelDB Authors. All rights reserved.
  7. // Use of this source code is governed by a BSD-style license that can be
  8. // found in the LICENSE file. See the AUTHORS file for names of contributors.
  9. #include "db/db_test_util.h"
  10. #include "port/port.h"
  11. #include "port/stack_trace.h"
  12. #include "rocksdb/concurrent_task_limiter.h"
  13. #include "rocksdb/experimental.h"
  14. #include "rocksdb/sst_file_writer.h"
  15. #include "rocksdb/utilities/convenience.h"
  16. #include "test_util/fault_injection_test_env.h"
  17. #include "test_util/sync_point.h"
  18. #include "util/concurrent_task_limiter_impl.h"
  19. namespace ROCKSDB_NAMESPACE {
  20. // SYNC_POINT is not supported in released Windows mode.
  21. #if !defined(ROCKSDB_LITE)
  22. class DBCompactionTest : public DBTestBase {
  23. public:
  24. DBCompactionTest() : DBTestBase("/db_compaction_test") {}
  25. };
  26. class DBCompactionTestWithParam
  27. : public DBTestBase,
  28. public testing::WithParamInterface<std::tuple<uint32_t, bool>> {
  29. public:
  30. DBCompactionTestWithParam() : DBTestBase("/db_compaction_test") {
  31. max_subcompactions_ = std::get<0>(GetParam());
  32. exclusive_manual_compaction_ = std::get<1>(GetParam());
  33. }
  34. // Required if inheriting from testing::WithParamInterface<>
  35. static void SetUpTestCase() {}
  36. static void TearDownTestCase() {}
  37. uint32_t max_subcompactions_;
  38. bool exclusive_manual_compaction_;
  39. };
  40. class DBCompactionDirectIOTest : public DBCompactionTest,
  41. public ::testing::WithParamInterface<bool> {
  42. public:
  43. DBCompactionDirectIOTest() : DBCompactionTest() {}
  44. };
  45. namespace {
  46. class FlushedFileCollector : public EventListener {
  47. public:
  48. FlushedFileCollector() {}
  49. ~FlushedFileCollector() override {}
  50. void OnFlushCompleted(DB* /*db*/, const FlushJobInfo& info) override {
  51. std::lock_guard<std::mutex> lock(mutex_);
  52. flushed_files_.push_back(info.file_path);
  53. }
  54. std::vector<std::string> GetFlushedFiles() {
  55. std::lock_guard<std::mutex> lock(mutex_);
  56. std::vector<std::string> result;
  57. for (auto fname : flushed_files_) {
  58. result.push_back(fname);
  59. }
  60. return result;
  61. }
  62. void ClearFlushedFiles() { flushed_files_.clear(); }
  63. private:
  64. std::vector<std::string> flushed_files_;
  65. std::mutex mutex_;
  66. };
  67. class CompactionStatsCollector : public EventListener {
  68. public:
  69. CompactionStatsCollector()
  70. : compaction_completed_(static_cast<int>(CompactionReason::kNumOfReasons)) {
  71. for (auto& v : compaction_completed_) {
  72. v.store(0);
  73. }
  74. }
  75. ~CompactionStatsCollector() override {}
  76. void OnCompactionCompleted(DB* /* db */,
  77. const CompactionJobInfo& info) override {
  78. int k = static_cast<int>(info.compaction_reason);
  79. int num_of_reasons = static_cast<int>(CompactionReason::kNumOfReasons);
  80. assert(k >= 0 && k < num_of_reasons);
  81. compaction_completed_[k]++;
  82. }
  83. void OnExternalFileIngested(
  84. DB* /* db */, const ExternalFileIngestionInfo& /* info */) override {
  85. int k = static_cast<int>(CompactionReason::kExternalSstIngestion);
  86. compaction_completed_[k]++;
  87. }
  88. void OnFlushCompleted(DB* /* db */, const FlushJobInfo& /* info */) override {
  89. int k = static_cast<int>(CompactionReason::kFlush);
  90. compaction_completed_[k]++;
  91. }
  92. int NumberOfCompactions(CompactionReason reason) const {
  93. int num_of_reasons = static_cast<int>(CompactionReason::kNumOfReasons);
  94. int k = static_cast<int>(reason);
  95. assert(k >= 0 && k < num_of_reasons);
  96. return compaction_completed_.at(k).load();
  97. }
  98. private:
  99. std::vector<std::atomic<int>> compaction_completed_;
  100. };
  101. class SstStatsCollector : public EventListener {
  102. public:
  103. SstStatsCollector() : num_ssts_creation_started_(0) {}
  104. void OnTableFileCreationStarted(
  105. const TableFileCreationBriefInfo& /* info */) override {
  106. ++num_ssts_creation_started_;
  107. }
  108. int num_ssts_creation_started() { return num_ssts_creation_started_; }
  109. private:
  110. std::atomic<int> num_ssts_creation_started_;
  111. };
  112. static const int kCDTValueSize = 1000;
  113. static const int kCDTKeysPerBuffer = 4;
  114. static const int kCDTNumLevels = 8;
  115. Options DeletionTriggerOptions(Options options) {
  116. options.compression = kNoCompression;
  117. options.write_buffer_size = kCDTKeysPerBuffer * (kCDTValueSize + 24);
  118. options.min_write_buffer_number_to_merge = 1;
  119. options.max_write_buffer_size_to_maintain = 0;
  120. options.num_levels = kCDTNumLevels;
  121. options.level0_file_num_compaction_trigger = 1;
  122. options.target_file_size_base = options.write_buffer_size * 2;
  123. options.target_file_size_multiplier = 2;
  124. options.max_bytes_for_level_base =
  125. options.target_file_size_base * options.target_file_size_multiplier;
  126. options.max_bytes_for_level_multiplier = 2;
  127. options.disable_auto_compactions = false;
  128. return options;
  129. }
  130. bool HaveOverlappingKeyRanges(
  131. const Comparator* c,
  132. const SstFileMetaData& a, const SstFileMetaData& b) {
  133. if (c->Compare(a.smallestkey, b.smallestkey) >= 0) {
  134. if (c->Compare(a.smallestkey, b.largestkey) <= 0) {
  135. // b.smallestkey <= a.smallestkey <= b.largestkey
  136. return true;
  137. }
  138. } else if (c->Compare(a.largestkey, b.smallestkey) >= 0) {
  139. // a.smallestkey < b.smallestkey <= a.largestkey
  140. return true;
  141. }
  142. if (c->Compare(a.largestkey, b.largestkey) <= 0) {
  143. if (c->Compare(a.largestkey, b.smallestkey) >= 0) {
  144. // b.smallestkey <= a.largestkey <= b.largestkey
  145. return true;
  146. }
  147. } else if (c->Compare(a.smallestkey, b.largestkey) <= 0) {
  148. // a.smallestkey <= b.largestkey < a.largestkey
  149. return true;
  150. }
  151. return false;
  152. }
  153. // Identifies all files between level "min_level" and "max_level"
  154. // which has overlapping key range with "input_file_meta".
  155. void GetOverlappingFileNumbersForLevelCompaction(
  156. const ColumnFamilyMetaData& cf_meta,
  157. const Comparator* comparator,
  158. int min_level, int max_level,
  159. const SstFileMetaData* input_file_meta,
  160. std::set<std::string>* overlapping_file_names) {
  161. std::set<const SstFileMetaData*> overlapping_files;
  162. overlapping_files.insert(input_file_meta);
  163. for (int m = min_level; m <= max_level; ++m) {
  164. for (auto& file : cf_meta.levels[m].files) {
  165. for (auto* included_file : overlapping_files) {
  166. if (HaveOverlappingKeyRanges(
  167. comparator, *included_file, file)) {
  168. overlapping_files.insert(&file);
  169. overlapping_file_names->insert(file.name);
  170. break;
  171. }
  172. }
  173. }
  174. }
  175. }
  176. void VerifyCompactionResult(
  177. const ColumnFamilyMetaData& cf_meta,
  178. const std::set<std::string>& overlapping_file_numbers) {
  179. #ifndef NDEBUG
  180. for (auto& level : cf_meta.levels) {
  181. for (auto& file : level.files) {
  182. assert(overlapping_file_numbers.find(file.name) ==
  183. overlapping_file_numbers.end());
  184. }
  185. }
  186. #endif
  187. }
  188. /*
  189. * Verifies compaction stats of cfd are valid.
  190. *
  191. * For each level of cfd, its compaction stats are valid if
  192. * 1) sum(stat.counts) == stat.count, and
  193. * 2) stat.counts[i] == collector.NumberOfCompactions(i)
  194. */
  195. void VerifyCompactionStats(ColumnFamilyData& cfd,
  196. const CompactionStatsCollector& collector) {
  197. #ifndef NDEBUG
  198. InternalStats* internal_stats_ptr = cfd.internal_stats();
  199. ASSERT_TRUE(internal_stats_ptr != nullptr);
  200. const std::vector<InternalStats::CompactionStats>& comp_stats =
  201. internal_stats_ptr->TEST_GetCompactionStats();
  202. const int num_of_reasons = static_cast<int>(CompactionReason::kNumOfReasons);
  203. std::vector<int> counts(num_of_reasons, 0);
  204. // Count the number of compactions caused by each CompactionReason across
  205. // all levels.
  206. for (const auto& stat : comp_stats) {
  207. int sum = 0;
  208. for (int i = 0; i < num_of_reasons; i++) {
  209. counts[i] += stat.counts[i];
  210. sum += stat.counts[i];
  211. }
  212. ASSERT_EQ(sum, stat.count);
  213. }
  214. // Verify InternalStats bookkeeping matches that of CompactionStatsCollector,
  215. // assuming that all compactions complete.
  216. for (int i = 0; i < num_of_reasons; i++) {
  217. ASSERT_EQ(collector.NumberOfCompactions(static_cast<CompactionReason>(i)), counts[i]);
  218. }
  219. #endif /* NDEBUG */
  220. }
  221. const SstFileMetaData* PickFileRandomly(
  222. const ColumnFamilyMetaData& cf_meta,
  223. Random* rand,
  224. int* level = nullptr) {
  225. auto file_id = rand->Uniform(static_cast<int>(
  226. cf_meta.file_count)) + 1;
  227. for (auto& level_meta : cf_meta.levels) {
  228. if (file_id <= level_meta.files.size()) {
  229. if (level != nullptr) {
  230. *level = level_meta.level;
  231. }
  232. auto result = rand->Uniform(file_id);
  233. return &(level_meta.files[result]);
  234. }
  235. file_id -= static_cast<uint32_t>(level_meta.files.size());
  236. }
  237. assert(false);
  238. return nullptr;
  239. }
  240. } // anonymous namespace
  241. #ifndef ROCKSDB_VALGRIND_RUN
  242. // All the TEST_P tests run once with sub_compactions disabled (i.e.
  243. // options.max_subcompactions = 1) and once with it enabled
  244. TEST_P(DBCompactionTestWithParam, CompactionDeletionTrigger) {
  245. for (int tid = 0; tid < 3; ++tid) {
  246. uint64_t db_size[2];
  247. Options options = DeletionTriggerOptions(CurrentOptions());
  248. options.max_subcompactions = max_subcompactions_;
  249. if (tid == 1) {
  250. // the following only disable stats update in DB::Open()
  251. // and should not affect the result of this test.
  252. options.skip_stats_update_on_db_open = true;
  253. } else if (tid == 2) {
  254. // third pass with universal compaction
  255. options.compaction_style = kCompactionStyleUniversal;
  256. options.num_levels = 1;
  257. }
  258. DestroyAndReopen(options);
  259. Random rnd(301);
  260. const int kTestSize = kCDTKeysPerBuffer * 1024;
  261. std::vector<std::string> values;
  262. for (int k = 0; k < kTestSize; ++k) {
  263. values.push_back(RandomString(&rnd, kCDTValueSize));
  264. ASSERT_OK(Put(Key(k), values[k]));
  265. }
  266. dbfull()->TEST_WaitForFlushMemTable();
  267. dbfull()->TEST_WaitForCompact();
  268. db_size[0] = Size(Key(0), Key(kTestSize - 1));
  269. for (int k = 0; k < kTestSize; ++k) {
  270. ASSERT_OK(Delete(Key(k)));
  271. }
  272. dbfull()->TEST_WaitForFlushMemTable();
  273. dbfull()->TEST_WaitForCompact();
  274. db_size[1] = Size(Key(0), Key(kTestSize - 1));
  275. // must have much smaller db size.
  276. ASSERT_GT(db_size[0] / 3, db_size[1]);
  277. }
  278. }
  279. #endif // ROCKSDB_VALGRIND_RUN
  280. TEST_P(DBCompactionTestWithParam, CompactionsPreserveDeletes) {
  281. // For each options type we test following
  282. // - Enable preserve_deletes
  283. // - write bunch of keys and deletes
  284. // - Set start_seqnum to the beginning; compact; check that keys are present
  285. // - rewind start_seqnum way forward; compact; check that keys are gone
  286. for (int tid = 0; tid < 3; ++tid) {
  287. Options options = DeletionTriggerOptions(CurrentOptions());
  288. options.max_subcompactions = max_subcompactions_;
  289. options.preserve_deletes=true;
  290. options.num_levels = 2;
  291. if (tid == 1) {
  292. options.skip_stats_update_on_db_open = true;
  293. } else if (tid == 2) {
  294. // third pass with universal compaction
  295. options.compaction_style = kCompactionStyleUniversal;
  296. }
  297. DestroyAndReopen(options);
  298. Random rnd(301);
  299. // highlight the default; all deletes should be preserved
  300. SetPreserveDeletesSequenceNumber(0);
  301. const int kTestSize = kCDTKeysPerBuffer;
  302. std::vector<std::string> values;
  303. for (int k = 0; k < kTestSize; ++k) {
  304. values.push_back(RandomString(&rnd, kCDTValueSize));
  305. ASSERT_OK(Put(Key(k), values[k]));
  306. }
  307. for (int k = 0; k < kTestSize; ++k) {
  308. ASSERT_OK(Delete(Key(k)));
  309. }
  310. // to ensure we tackle all tombstones
  311. CompactRangeOptions cro;
  312. cro.change_level = true;
  313. cro.target_level = 2;
  314. cro.bottommost_level_compaction =
  315. BottommostLevelCompaction::kForceOptimized;
  316. dbfull()->TEST_WaitForFlushMemTable();
  317. dbfull()->CompactRange(cro, nullptr, nullptr);
  318. // check that normal user iterator doesn't see anything
  319. Iterator* db_iter = dbfull()->NewIterator(ReadOptions());
  320. int i = 0;
  321. for (db_iter->SeekToFirst(); db_iter->Valid(); db_iter->Next()) {
  322. i++;
  323. }
  324. ASSERT_EQ(i, 0);
  325. delete db_iter;
  326. // check that iterator that sees internal keys sees tombstones
  327. ReadOptions ro;
  328. ro.iter_start_seqnum=1;
  329. db_iter = dbfull()->NewIterator(ro);
  330. i = 0;
  331. for (db_iter->SeekToFirst(); db_iter->Valid(); db_iter->Next()) {
  332. i++;
  333. }
  334. ASSERT_EQ(i, 4);
  335. delete db_iter;
  336. // now all deletes should be gone
  337. SetPreserveDeletesSequenceNumber(100000000);
  338. dbfull()->CompactRange(cro, nullptr, nullptr);
  339. db_iter = dbfull()->NewIterator(ro);
  340. i = 0;
  341. for (db_iter->SeekToFirst(); db_iter->Valid(); db_iter->Next()) {
  342. i++;
  343. }
  344. ASSERT_EQ(i, 0);
  345. delete db_iter;
  346. }
  347. }
  348. TEST_F(DBCompactionTest, SkipStatsUpdateTest) {
  349. // This test verify UpdateAccumulatedStats is not on
  350. // if options.skip_stats_update_on_db_open = true
  351. // The test will need to be updated if the internal behavior changes.
  352. Options options = DeletionTriggerOptions(CurrentOptions());
  353. options.disable_auto_compactions = true;
  354. options.env = env_;
  355. DestroyAndReopen(options);
  356. Random rnd(301);
  357. const int kTestSize = kCDTKeysPerBuffer * 512;
  358. std::vector<std::string> values;
  359. for (int k = 0; k < kTestSize; ++k) {
  360. values.push_back(RandomString(&rnd, kCDTValueSize));
  361. ASSERT_OK(Put(Key(k), values[k]));
  362. }
  363. ASSERT_OK(Flush());
  364. Close();
  365. int update_acc_stats_called = 0;
  366. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  367. "VersionStorageInfo::UpdateAccumulatedStats",
  368. [&](void* /* arg */) { ++update_acc_stats_called; });
  369. SyncPoint::GetInstance()->EnableProcessing();
  370. // Reopen the DB with stats-update disabled
  371. options.skip_stats_update_on_db_open = true;
  372. options.max_open_files = 20;
  373. Reopen(options);
  374. ASSERT_EQ(update_acc_stats_called, 0);
  375. // Repeat the reopen process, but this time we enable
  376. // stats-update.
  377. options.skip_stats_update_on_db_open = false;
  378. Reopen(options);
  379. ASSERT_GT(update_acc_stats_called, 0);
  380. SyncPoint::GetInstance()->ClearAllCallBacks();
  381. SyncPoint::GetInstance()->DisableProcessing();
  382. }
  383. TEST_F(DBCompactionTest, TestTableReaderForCompaction) {
  384. Options options = CurrentOptions();
  385. options.env = env_;
  386. options.new_table_reader_for_compaction_inputs = true;
  387. options.max_open_files = 20;
  388. options.level0_file_num_compaction_trigger = 3;
  389. DestroyAndReopen(options);
  390. Random rnd(301);
  391. int num_table_cache_lookup = 0;
  392. int num_new_table_reader = 0;
  393. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  394. "TableCache::FindTable:0", [&](void* arg) {
  395. assert(arg != nullptr);
  396. bool no_io = *(reinterpret_cast<bool*>(arg));
  397. if (!no_io) {
  398. // filter out cases for table properties queries.
  399. num_table_cache_lookup++;
  400. }
  401. });
  402. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  403. "TableCache::GetTableReader:0",
  404. [&](void* /*arg*/) { num_new_table_reader++; });
  405. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  406. for (int k = 0; k < options.level0_file_num_compaction_trigger; ++k) {
  407. ASSERT_OK(Put(Key(k), Key(k)));
  408. ASSERT_OK(Put(Key(10 - k), "bar"));
  409. if (k < options.level0_file_num_compaction_trigger - 1) {
  410. num_table_cache_lookup = 0;
  411. Flush();
  412. dbfull()->TEST_WaitForCompact();
  413. // preloading iterator issues one table cache lookup and create
  414. // a new table reader, if not preloaded.
  415. int old_num_table_cache_lookup = num_table_cache_lookup;
  416. ASSERT_GE(num_table_cache_lookup, 1);
  417. ASSERT_EQ(num_new_table_reader, 1);
  418. num_table_cache_lookup = 0;
  419. num_new_table_reader = 0;
  420. ASSERT_EQ(Key(k), Get(Key(k)));
  421. // lookup iterator from table cache and no need to create a new one.
  422. ASSERT_EQ(old_num_table_cache_lookup + num_table_cache_lookup, 2);
  423. ASSERT_EQ(num_new_table_reader, 0);
  424. }
  425. }
  426. num_table_cache_lookup = 0;
  427. num_new_table_reader = 0;
  428. Flush();
  429. dbfull()->TEST_WaitForCompact();
  430. // Preloading iterator issues one table cache lookup and creates
  431. // a new table reader. One file is created for flush and one for compaction.
  432. // Compaction inputs make no table cache look-up for data/range deletion
  433. // iterators
  434. // May preload table cache too.
  435. ASSERT_GE(num_table_cache_lookup, 2);
  436. int old_num_table_cache_lookup2 = num_table_cache_lookup;
  437. // Create new iterator for:
  438. // (1) 1 for verifying flush results
  439. // (2) 1 for verifying compaction results.
  440. // (3) New TableReaders will not be created for compaction inputs
  441. ASSERT_EQ(num_new_table_reader, 2);
  442. num_table_cache_lookup = 0;
  443. num_new_table_reader = 0;
  444. ASSERT_EQ(Key(1), Get(Key(1)));
  445. ASSERT_EQ(num_table_cache_lookup + old_num_table_cache_lookup2, 5);
  446. ASSERT_EQ(num_new_table_reader, 0);
  447. num_table_cache_lookup = 0;
  448. num_new_table_reader = 0;
  449. CompactRangeOptions cro;
  450. cro.change_level = true;
  451. cro.target_level = 2;
  452. cro.bottommost_level_compaction = BottommostLevelCompaction::kForceOptimized;
  453. db_->CompactRange(cro, nullptr, nullptr);
  454. // Only verifying compaction outputs issues one table cache lookup
  455. // for both data block and range deletion block).
  456. // May preload table cache too.
  457. ASSERT_GE(num_table_cache_lookup, 1);
  458. old_num_table_cache_lookup2 = num_table_cache_lookup;
  459. // One for verifying compaction results.
  460. // No new iterator created for compaction.
  461. ASSERT_EQ(num_new_table_reader, 1);
  462. num_table_cache_lookup = 0;
  463. num_new_table_reader = 0;
  464. ASSERT_EQ(Key(1), Get(Key(1)));
  465. ASSERT_EQ(num_table_cache_lookup + old_num_table_cache_lookup2, 3);
  466. ASSERT_EQ(num_new_table_reader, 0);
  467. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
  468. }
  469. TEST_P(DBCompactionTestWithParam, CompactionDeletionTriggerReopen) {
  470. for (int tid = 0; tid < 2; ++tid) {
  471. uint64_t db_size[3];
  472. Options options = DeletionTriggerOptions(CurrentOptions());
  473. options.max_subcompactions = max_subcompactions_;
  474. if (tid == 1) {
  475. // second pass with universal compaction
  476. options.compaction_style = kCompactionStyleUniversal;
  477. options.num_levels = 1;
  478. }
  479. DestroyAndReopen(options);
  480. Random rnd(301);
  481. // round 1 --- insert key/value pairs.
  482. const int kTestSize = kCDTKeysPerBuffer * 512;
  483. std::vector<std::string> values;
  484. for (int k = 0; k < kTestSize; ++k) {
  485. values.push_back(RandomString(&rnd, kCDTValueSize));
  486. ASSERT_OK(Put(Key(k), values[k]));
  487. }
  488. dbfull()->TEST_WaitForFlushMemTable();
  489. dbfull()->TEST_WaitForCompact();
  490. db_size[0] = Size(Key(0), Key(kTestSize - 1));
  491. Close();
  492. // round 2 --- disable auto-compactions and issue deletions.
  493. options.create_if_missing = false;
  494. options.disable_auto_compactions = true;
  495. Reopen(options);
  496. for (int k = 0; k < kTestSize; ++k) {
  497. ASSERT_OK(Delete(Key(k)));
  498. }
  499. db_size[1] = Size(Key(0), Key(kTestSize - 1));
  500. Close();
  501. // as auto_compaction is off, we shouldn't see too much reduce
  502. // in db size.
  503. ASSERT_LT(db_size[0] / 3, db_size[1]);
  504. // round 3 --- reopen db with auto_compaction on and see if
  505. // deletion compensation still work.
  506. options.disable_auto_compactions = false;
  507. Reopen(options);
  508. // insert relatively small amount of data to trigger auto compaction.
  509. for (int k = 0; k < kTestSize / 10; ++k) {
  510. ASSERT_OK(Put(Key(k), values[k]));
  511. }
  512. dbfull()->TEST_WaitForFlushMemTable();
  513. dbfull()->TEST_WaitForCompact();
  514. db_size[2] = Size(Key(0), Key(kTestSize - 1));
  515. // this time we're expecting significant drop in size.
  516. ASSERT_GT(db_size[0] / 3, db_size[2]);
  517. }
  518. }
  519. TEST_F(DBCompactionTest, DisableStatsUpdateReopen) {
  520. uint64_t db_size[3];
  521. for (int test = 0; test < 2; ++test) {
  522. Options options = DeletionTriggerOptions(CurrentOptions());
  523. options.skip_stats_update_on_db_open = (test == 0);
  524. env_->random_read_counter_.Reset();
  525. DestroyAndReopen(options);
  526. Random rnd(301);
  527. // round 1 --- insert key/value pairs.
  528. const int kTestSize = kCDTKeysPerBuffer * 512;
  529. std::vector<std::string> values;
  530. for (int k = 0; k < kTestSize; ++k) {
  531. values.push_back(RandomString(&rnd, kCDTValueSize));
  532. ASSERT_OK(Put(Key(k), values[k]));
  533. }
  534. dbfull()->TEST_WaitForFlushMemTable();
  535. dbfull()->TEST_WaitForCompact();
  536. db_size[0] = Size(Key(0), Key(kTestSize - 1));
  537. Close();
  538. // round 2 --- disable auto-compactions and issue deletions.
  539. options.create_if_missing = false;
  540. options.disable_auto_compactions = true;
  541. env_->random_read_counter_.Reset();
  542. Reopen(options);
  543. for (int k = 0; k < kTestSize; ++k) {
  544. ASSERT_OK(Delete(Key(k)));
  545. }
  546. db_size[1] = Size(Key(0), Key(kTestSize - 1));
  547. Close();
  548. // as auto_compaction is off, we shouldn't see too much reduce
  549. // in db size.
  550. ASSERT_LT(db_size[0] / 3, db_size[1]);
  551. // round 3 --- reopen db with auto_compaction on and see if
  552. // deletion compensation still work.
  553. options.disable_auto_compactions = false;
  554. Reopen(options);
  555. dbfull()->TEST_WaitForFlushMemTable();
  556. dbfull()->TEST_WaitForCompact();
  557. db_size[2] = Size(Key(0), Key(kTestSize - 1));
  558. if (options.skip_stats_update_on_db_open) {
  559. // If update stats on DB::Open is disable, we don't expect
  560. // deletion entries taking effect.
  561. ASSERT_LT(db_size[0] / 3, db_size[2]);
  562. } else {
  563. // Otherwise, we should see a significant drop in db size.
  564. ASSERT_GT(db_size[0] / 3, db_size[2]);
  565. }
  566. }
  567. }
  568. TEST_P(DBCompactionTestWithParam, CompactionTrigger) {
  569. const int kNumKeysPerFile = 100;
  570. Options options = CurrentOptions();
  571. options.write_buffer_size = 110 << 10; // 110KB
  572. options.arena_block_size = 4 << 10;
  573. options.num_levels = 3;
  574. options.level0_file_num_compaction_trigger = 3;
  575. options.max_subcompactions = max_subcompactions_;
  576. options.memtable_factory.reset(new SpecialSkipListFactory(kNumKeysPerFile));
  577. CreateAndReopenWithCF({"pikachu"}, options);
  578. Random rnd(301);
  579. for (int num = 0; num < options.level0_file_num_compaction_trigger - 1;
  580. num++) {
  581. std::vector<std::string> values;
  582. // Write 100KB (100 values, each 1K)
  583. for (int i = 0; i < kNumKeysPerFile; i++) {
  584. values.push_back(RandomString(&rnd, 990));
  585. ASSERT_OK(Put(1, Key(i), values[i]));
  586. }
  587. // put extra key to trigger flush
  588. ASSERT_OK(Put(1, "", ""));
  589. dbfull()->TEST_WaitForFlushMemTable(handles_[1]);
  590. ASSERT_EQ(NumTableFilesAtLevel(0, 1), num + 1);
  591. }
  592. // generate one more file in level-0, and should trigger level-0 compaction
  593. std::vector<std::string> values;
  594. for (int i = 0; i < kNumKeysPerFile; i++) {
  595. values.push_back(RandomString(&rnd, 990));
  596. ASSERT_OK(Put(1, Key(i), values[i]));
  597. }
  598. // put extra key to trigger flush
  599. ASSERT_OK(Put(1, "", ""));
  600. dbfull()->TEST_WaitForCompact();
  601. ASSERT_EQ(NumTableFilesAtLevel(0, 1), 0);
  602. ASSERT_EQ(NumTableFilesAtLevel(1, 1), 1);
  603. }
  604. TEST_F(DBCompactionTest, BGCompactionsAllowed) {
  605. // Create several column families. Make compaction triggers in all of them
  606. // and see number of compactions scheduled to be less than allowed.
  607. const int kNumKeysPerFile = 100;
  608. Options options = CurrentOptions();
  609. options.write_buffer_size = 110 << 10; // 110KB
  610. options.arena_block_size = 4 << 10;
  611. options.num_levels = 3;
  612. // Should speed up compaction when there are 4 files.
  613. options.level0_file_num_compaction_trigger = 2;
  614. options.level0_slowdown_writes_trigger = 20;
  615. options.soft_pending_compaction_bytes_limit = 1 << 30; // Infinitely large
  616. options.max_background_compactions = 3;
  617. options.memtable_factory.reset(new SpecialSkipListFactory(kNumKeysPerFile));
  618. // Block all threads in thread pool.
  619. const size_t kTotalTasks = 4;
  620. env_->SetBackgroundThreads(4, Env::LOW);
  621. test::SleepingBackgroundTask sleeping_tasks[kTotalTasks];
  622. for (size_t i = 0; i < kTotalTasks; i++) {
  623. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask,
  624. &sleeping_tasks[i], Env::Priority::LOW);
  625. sleeping_tasks[i].WaitUntilSleeping();
  626. }
  627. CreateAndReopenWithCF({"one", "two", "three"}, options);
  628. Random rnd(301);
  629. for (int cf = 0; cf < 4; cf++) {
  630. for (int num = 0; num < options.level0_file_num_compaction_trigger; num++) {
  631. for (int i = 0; i < kNumKeysPerFile; i++) {
  632. ASSERT_OK(Put(cf, Key(i), ""));
  633. }
  634. // put extra key to trigger flush
  635. ASSERT_OK(Put(cf, "", ""));
  636. dbfull()->TEST_WaitForFlushMemTable(handles_[cf]);
  637. ASSERT_EQ(NumTableFilesAtLevel(0, cf), num + 1);
  638. }
  639. }
  640. // Now all column families qualify compaction but only one should be
  641. // scheduled, because no column family hits speed up condition.
  642. ASSERT_EQ(1u, env_->GetThreadPoolQueueLen(Env::Priority::LOW));
  643. // Create two more files for one column family, which triggers speed up
  644. // condition, three compactions will be scheduled.
  645. for (int num = 0; num < options.level0_file_num_compaction_trigger; num++) {
  646. for (int i = 0; i < kNumKeysPerFile; i++) {
  647. ASSERT_OK(Put(2, Key(i), ""));
  648. }
  649. // put extra key to trigger flush
  650. ASSERT_OK(Put(2, "", ""));
  651. dbfull()->TEST_WaitForFlushMemTable(handles_[2]);
  652. ASSERT_EQ(options.level0_file_num_compaction_trigger + num + 1,
  653. NumTableFilesAtLevel(0, 2));
  654. }
  655. ASSERT_EQ(3U, env_->GetThreadPoolQueueLen(Env::Priority::LOW));
  656. // Unblock all threads to unblock all compactions.
  657. for (size_t i = 0; i < kTotalTasks; i++) {
  658. sleeping_tasks[i].WakeUp();
  659. sleeping_tasks[i].WaitUntilDone();
  660. }
  661. dbfull()->TEST_WaitForCompact();
  662. // Verify number of compactions allowed will come back to 1.
  663. for (size_t i = 0; i < kTotalTasks; i++) {
  664. sleeping_tasks[i].Reset();
  665. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask,
  666. &sleeping_tasks[i], Env::Priority::LOW);
  667. sleeping_tasks[i].WaitUntilSleeping();
  668. }
  669. for (int cf = 0; cf < 4; cf++) {
  670. for (int num = 0; num < options.level0_file_num_compaction_trigger; num++) {
  671. for (int i = 0; i < kNumKeysPerFile; i++) {
  672. ASSERT_OK(Put(cf, Key(i), ""));
  673. }
  674. // put extra key to trigger flush
  675. ASSERT_OK(Put(cf, "", ""));
  676. dbfull()->TEST_WaitForFlushMemTable(handles_[cf]);
  677. ASSERT_EQ(NumTableFilesAtLevel(0, cf), num + 1);
  678. }
  679. }
  680. // Now all column families qualify compaction but only one should be
  681. // scheduled, because no column family hits speed up condition.
  682. ASSERT_EQ(1U, env_->GetThreadPoolQueueLen(Env::Priority::LOW));
  683. for (size_t i = 0; i < kTotalTasks; i++) {
  684. sleeping_tasks[i].WakeUp();
  685. sleeping_tasks[i].WaitUntilDone();
  686. }
  687. }
  688. TEST_P(DBCompactionTestWithParam, CompactionsGenerateMultipleFiles) {
  689. Options options = CurrentOptions();
  690. options.write_buffer_size = 100000000; // Large write buffer
  691. options.max_subcompactions = max_subcompactions_;
  692. CreateAndReopenWithCF({"pikachu"}, options);
  693. Random rnd(301);
  694. // Write 8MB (80 values, each 100K)
  695. ASSERT_EQ(NumTableFilesAtLevel(0, 1), 0);
  696. std::vector<std::string> values;
  697. for (int i = 0; i < 80; i++) {
  698. values.push_back(RandomString(&rnd, 100000));
  699. ASSERT_OK(Put(1, Key(i), values[i]));
  700. }
  701. // Reopening moves updates to level-0
  702. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  703. dbfull()->TEST_CompactRange(0, nullptr, nullptr, handles_[1],
  704. true /* disallow trivial move */);
  705. ASSERT_EQ(NumTableFilesAtLevel(0, 1), 0);
  706. ASSERT_GT(NumTableFilesAtLevel(1, 1), 1);
  707. for (int i = 0; i < 80; i++) {
  708. ASSERT_EQ(Get(1, Key(i)), values[i]);
  709. }
  710. }
  711. TEST_F(DBCompactionTest, MinorCompactionsHappen) {
  712. do {
  713. Options options = CurrentOptions();
  714. options.write_buffer_size = 10000;
  715. CreateAndReopenWithCF({"pikachu"}, options);
  716. const int N = 500;
  717. int starting_num_tables = TotalTableFiles(1);
  718. for (int i = 0; i < N; i++) {
  719. ASSERT_OK(Put(1, Key(i), Key(i) + std::string(1000, 'v')));
  720. }
  721. int ending_num_tables = TotalTableFiles(1);
  722. ASSERT_GT(ending_num_tables, starting_num_tables);
  723. for (int i = 0; i < N; i++) {
  724. ASSERT_EQ(Key(i) + std::string(1000, 'v'), Get(1, Key(i)));
  725. }
  726. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  727. for (int i = 0; i < N; i++) {
  728. ASSERT_EQ(Key(i) + std::string(1000, 'v'), Get(1, Key(i)));
  729. }
  730. } while (ChangeCompactOptions());
  731. }
  732. TEST_F(DBCompactionTest, UserKeyCrossFile1) {
  733. Options options = CurrentOptions();
  734. options.compaction_style = kCompactionStyleLevel;
  735. options.level0_file_num_compaction_trigger = 3;
  736. DestroyAndReopen(options);
  737. // create first file and flush to l0
  738. Put("4", "A");
  739. Put("3", "A");
  740. Flush();
  741. dbfull()->TEST_WaitForFlushMemTable();
  742. Put("2", "A");
  743. Delete("3");
  744. Flush();
  745. dbfull()->TEST_WaitForFlushMemTable();
  746. ASSERT_EQ("NOT_FOUND", Get("3"));
  747. // move both files down to l1
  748. dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr);
  749. ASSERT_EQ("NOT_FOUND", Get("3"));
  750. for (int i = 0; i < 3; i++) {
  751. Put("2", "B");
  752. Flush();
  753. dbfull()->TEST_WaitForFlushMemTable();
  754. }
  755. dbfull()->TEST_WaitForCompact();
  756. ASSERT_EQ("NOT_FOUND", Get("3"));
  757. }
  758. TEST_F(DBCompactionTest, UserKeyCrossFile2) {
  759. Options options = CurrentOptions();
  760. options.compaction_style = kCompactionStyleLevel;
  761. options.level0_file_num_compaction_trigger = 3;
  762. DestroyAndReopen(options);
  763. // create first file and flush to l0
  764. Put("4", "A");
  765. Put("3", "A");
  766. Flush();
  767. dbfull()->TEST_WaitForFlushMemTable();
  768. Put("2", "A");
  769. SingleDelete("3");
  770. Flush();
  771. dbfull()->TEST_WaitForFlushMemTable();
  772. ASSERT_EQ("NOT_FOUND", Get("3"));
  773. // move both files down to l1
  774. dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr);
  775. ASSERT_EQ("NOT_FOUND", Get("3"));
  776. for (int i = 0; i < 3; i++) {
  777. Put("2", "B");
  778. Flush();
  779. dbfull()->TEST_WaitForFlushMemTable();
  780. }
  781. dbfull()->TEST_WaitForCompact();
  782. ASSERT_EQ("NOT_FOUND", Get("3"));
  783. }
  784. TEST_F(DBCompactionTest, ZeroSeqIdCompaction) {
  785. Options options = CurrentOptions();
  786. options.compaction_style = kCompactionStyleLevel;
  787. options.level0_file_num_compaction_trigger = 3;
  788. FlushedFileCollector* collector = new FlushedFileCollector();
  789. options.listeners.emplace_back(collector);
  790. // compaction options
  791. CompactionOptions compact_opt;
  792. compact_opt.compression = kNoCompression;
  793. compact_opt.output_file_size_limit = 4096;
  794. const size_t key_len =
  795. static_cast<size_t>(compact_opt.output_file_size_limit) / 5;
  796. DestroyAndReopen(options);
  797. std::vector<const Snapshot*> snaps;
  798. // create first file and flush to l0
  799. for (auto& key : {"1", "2", "3", "3", "3", "3"}) {
  800. Put(key, std::string(key_len, 'A'));
  801. snaps.push_back(dbfull()->GetSnapshot());
  802. }
  803. Flush();
  804. dbfull()->TEST_WaitForFlushMemTable();
  805. // create second file and flush to l0
  806. for (auto& key : {"3", "4", "5", "6", "7", "8"}) {
  807. Put(key, std::string(key_len, 'A'));
  808. snaps.push_back(dbfull()->GetSnapshot());
  809. }
  810. Flush();
  811. dbfull()->TEST_WaitForFlushMemTable();
  812. // move both files down to l1
  813. dbfull()->CompactFiles(compact_opt, collector->GetFlushedFiles(), 1);
  814. // release snap so that first instance of key(3) can have seqId=0
  815. for (auto snap : snaps) {
  816. dbfull()->ReleaseSnapshot(snap);
  817. }
  818. // create 3 files in l0 so to trigger compaction
  819. for (int i = 0; i < options.level0_file_num_compaction_trigger; i++) {
  820. Put("2", std::string(1, 'A'));
  821. Flush();
  822. dbfull()->TEST_WaitForFlushMemTable();
  823. }
  824. dbfull()->TEST_WaitForCompact();
  825. ASSERT_OK(Put("", ""));
  826. }
  827. TEST_F(DBCompactionTest, ManualCompactionUnknownOutputSize) {
  828. // github issue #2249
  829. Options options = CurrentOptions();
  830. options.compaction_style = kCompactionStyleLevel;
  831. options.level0_file_num_compaction_trigger = 3;
  832. DestroyAndReopen(options);
  833. // create two files in l1 that we can compact
  834. for (int i = 0; i < 2; ++i) {
  835. for (int j = 0; j < options.level0_file_num_compaction_trigger; j++) {
  836. // make l0 files' ranges overlap to avoid trivial move
  837. Put(std::to_string(2 * i), std::string(1, 'A'));
  838. Put(std::to_string(2 * i + 1), std::string(1, 'A'));
  839. Flush();
  840. dbfull()->TEST_WaitForFlushMemTable();
  841. }
  842. dbfull()->TEST_WaitForCompact();
  843. ASSERT_EQ(NumTableFilesAtLevel(0, 0), 0);
  844. ASSERT_EQ(NumTableFilesAtLevel(1, 0), i + 1);
  845. }
  846. ColumnFamilyMetaData cf_meta;
  847. dbfull()->GetColumnFamilyMetaData(dbfull()->DefaultColumnFamily(), &cf_meta);
  848. ASSERT_EQ(2, cf_meta.levels[1].files.size());
  849. std::vector<std::string> input_filenames;
  850. for (const auto& sst_file : cf_meta.levels[1].files) {
  851. input_filenames.push_back(sst_file.name);
  852. }
  853. // note CompactionOptions::output_file_size_limit is unset.
  854. CompactionOptions compact_opt;
  855. compact_opt.compression = kNoCompression;
  856. dbfull()->CompactFiles(compact_opt, input_filenames, 1);
  857. }
  858. // Check that writes done during a memtable compaction are recovered
  859. // if the database is shutdown during the memtable compaction.
  860. TEST_F(DBCompactionTest, RecoverDuringMemtableCompaction) {
  861. do {
  862. Options options = CurrentOptions();
  863. options.env = env_;
  864. CreateAndReopenWithCF({"pikachu"}, options);
  865. // Trigger a long memtable compaction and reopen the database during it
  866. ASSERT_OK(Put(1, "foo", "v1")); // Goes to 1st log file
  867. ASSERT_OK(Put(1, "big1", std::string(10000000, 'x'))); // Fills memtable
  868. ASSERT_OK(Put(1, "big2", std::string(1000, 'y'))); // Triggers compaction
  869. ASSERT_OK(Put(1, "bar", "v2")); // Goes to new log file
  870. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  871. ASSERT_EQ("v1", Get(1, "foo"));
  872. ASSERT_EQ("v2", Get(1, "bar"));
  873. ASSERT_EQ(std::string(10000000, 'x'), Get(1, "big1"));
  874. ASSERT_EQ(std::string(1000, 'y'), Get(1, "big2"));
  875. } while (ChangeOptions());
  876. }
  877. TEST_P(DBCompactionTestWithParam, TrivialMoveOneFile) {
  878. int32_t trivial_move = 0;
  879. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  880. "DBImpl::BackgroundCompaction:TrivialMove",
  881. [&](void* /*arg*/) { trivial_move++; });
  882. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  883. Options options = CurrentOptions();
  884. options.write_buffer_size = 100000000;
  885. options.max_subcompactions = max_subcompactions_;
  886. DestroyAndReopen(options);
  887. int32_t num_keys = 80;
  888. int32_t value_size = 100 * 1024; // 100 KB
  889. Random rnd(301);
  890. std::vector<std::string> values;
  891. for (int i = 0; i < num_keys; i++) {
  892. values.push_back(RandomString(&rnd, value_size));
  893. ASSERT_OK(Put(Key(i), values[i]));
  894. }
  895. // Reopening moves updates to L0
  896. Reopen(options);
  897. ASSERT_EQ(NumTableFilesAtLevel(0, 0), 1); // 1 file in L0
  898. ASSERT_EQ(NumTableFilesAtLevel(1, 0), 0); // 0 files in L1
  899. std::vector<LiveFileMetaData> metadata;
  900. db_->GetLiveFilesMetaData(&metadata);
  901. ASSERT_EQ(metadata.size(), 1U);
  902. LiveFileMetaData level0_file = metadata[0]; // L0 file meta
  903. CompactRangeOptions cro;
  904. cro.exclusive_manual_compaction = exclusive_manual_compaction_;
  905. // Compaction will initiate a trivial move from L0 to L1
  906. dbfull()->CompactRange(cro, nullptr, nullptr);
  907. // File moved From L0 to L1
  908. ASSERT_EQ(NumTableFilesAtLevel(0, 0), 0); // 0 files in L0
  909. ASSERT_EQ(NumTableFilesAtLevel(1, 0), 1); // 1 file in L1
  910. metadata.clear();
  911. db_->GetLiveFilesMetaData(&metadata);
  912. ASSERT_EQ(metadata.size(), 1U);
  913. ASSERT_EQ(metadata[0].name /* level1_file.name */, level0_file.name);
  914. ASSERT_EQ(metadata[0].size /* level1_file.size */, level0_file.size);
  915. for (int i = 0; i < num_keys; i++) {
  916. ASSERT_EQ(Get(Key(i)), values[i]);
  917. }
  918. ASSERT_EQ(trivial_move, 1);
  919. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  920. }
  921. TEST_P(DBCompactionTestWithParam, TrivialMoveNonOverlappingFiles) {
  922. int32_t trivial_move = 0;
  923. int32_t non_trivial_move = 0;
  924. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  925. "DBImpl::BackgroundCompaction:TrivialMove",
  926. [&](void* /*arg*/) { trivial_move++; });
  927. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  928. "DBImpl::BackgroundCompaction:NonTrivial",
  929. [&](void* /*arg*/) { non_trivial_move++; });
  930. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  931. Options options = CurrentOptions();
  932. options.disable_auto_compactions = true;
  933. options.write_buffer_size = 10 * 1024 * 1024;
  934. options.max_subcompactions = max_subcompactions_;
  935. DestroyAndReopen(options);
  936. // non overlapping ranges
  937. std::vector<std::pair<int32_t, int32_t>> ranges = {
  938. {100, 199},
  939. {300, 399},
  940. {0, 99},
  941. {200, 299},
  942. {600, 699},
  943. {400, 499},
  944. {500, 550},
  945. {551, 599},
  946. };
  947. int32_t value_size = 10 * 1024; // 10 KB
  948. Random rnd(301);
  949. std::map<int32_t, std::string> values;
  950. for (size_t i = 0; i < ranges.size(); i++) {
  951. for (int32_t j = ranges[i].first; j <= ranges[i].second; j++) {
  952. values[j] = RandomString(&rnd, value_size);
  953. ASSERT_OK(Put(Key(j), values[j]));
  954. }
  955. ASSERT_OK(Flush());
  956. }
  957. int32_t level0_files = NumTableFilesAtLevel(0, 0);
  958. ASSERT_EQ(level0_files, ranges.size()); // Multiple files in L0
  959. ASSERT_EQ(NumTableFilesAtLevel(1, 0), 0); // No files in L1
  960. CompactRangeOptions cro;
  961. cro.exclusive_manual_compaction = exclusive_manual_compaction_;
  962. // Since data is non-overlapping we expect compaction to initiate
  963. // a trivial move
  964. db_->CompactRange(cro, nullptr, nullptr);
  965. // We expect that all the files were trivially moved from L0 to L1
  966. ASSERT_EQ(NumTableFilesAtLevel(0, 0), 0);
  967. ASSERT_EQ(NumTableFilesAtLevel(1, 0) /* level1_files */, level0_files);
  968. for (size_t i = 0; i < ranges.size(); i++) {
  969. for (int32_t j = ranges[i].first; j <= ranges[i].second; j++) {
  970. ASSERT_EQ(Get(Key(j)), values[j]);
  971. }
  972. }
  973. ASSERT_EQ(trivial_move, 1);
  974. ASSERT_EQ(non_trivial_move, 0);
  975. trivial_move = 0;
  976. non_trivial_move = 0;
  977. values.clear();
  978. DestroyAndReopen(options);
  979. // Same ranges as above but overlapping
  980. ranges = {
  981. {100, 199},
  982. {300, 399},
  983. {0, 99},
  984. {200, 299},
  985. {600, 699},
  986. {400, 499},
  987. {500, 560}, // this range overlap with the next one
  988. {551, 599},
  989. };
  990. for (size_t i = 0; i < ranges.size(); i++) {
  991. for (int32_t j = ranges[i].first; j <= ranges[i].second; j++) {
  992. values[j] = RandomString(&rnd, value_size);
  993. ASSERT_OK(Put(Key(j), values[j]));
  994. }
  995. ASSERT_OK(Flush());
  996. }
  997. db_->CompactRange(cro, nullptr, nullptr);
  998. for (size_t i = 0; i < ranges.size(); i++) {
  999. for (int32_t j = ranges[i].first; j <= ranges[i].second; j++) {
  1000. ASSERT_EQ(Get(Key(j)), values[j]);
  1001. }
  1002. }
  1003. ASSERT_EQ(trivial_move, 0);
  1004. ASSERT_EQ(non_trivial_move, 1);
  1005. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  1006. }
  1007. TEST_P(DBCompactionTestWithParam, TrivialMoveTargetLevel) {
  1008. int32_t trivial_move = 0;
  1009. int32_t non_trivial_move = 0;
  1010. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1011. "DBImpl::BackgroundCompaction:TrivialMove",
  1012. [&](void* /*arg*/) { trivial_move++; });
  1013. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1014. "DBImpl::BackgroundCompaction:NonTrivial",
  1015. [&](void* /*arg*/) { non_trivial_move++; });
  1016. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  1017. Options options = CurrentOptions();
  1018. options.disable_auto_compactions = true;
  1019. options.write_buffer_size = 10 * 1024 * 1024;
  1020. options.num_levels = 7;
  1021. options.max_subcompactions = max_subcompactions_;
  1022. DestroyAndReopen(options);
  1023. int32_t value_size = 10 * 1024; // 10 KB
  1024. // Add 2 non-overlapping files
  1025. Random rnd(301);
  1026. std::map<int32_t, std::string> values;
  1027. // file 1 [0 => 300]
  1028. for (int32_t i = 0; i <= 300; i++) {
  1029. values[i] = RandomString(&rnd, value_size);
  1030. ASSERT_OK(Put(Key(i), values[i]));
  1031. }
  1032. ASSERT_OK(Flush());
  1033. // file 2 [600 => 700]
  1034. for (int32_t i = 600; i <= 700; i++) {
  1035. values[i] = RandomString(&rnd, value_size);
  1036. ASSERT_OK(Put(Key(i), values[i]));
  1037. }
  1038. ASSERT_OK(Flush());
  1039. // 2 files in L0
  1040. ASSERT_EQ("2", FilesPerLevel(0));
  1041. CompactRangeOptions compact_options;
  1042. compact_options.change_level = true;
  1043. compact_options.target_level = 6;
  1044. compact_options.exclusive_manual_compaction = exclusive_manual_compaction_;
  1045. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1046. // 2 files in L6
  1047. ASSERT_EQ("0,0,0,0,0,0,2", FilesPerLevel(0));
  1048. ASSERT_EQ(trivial_move, 1);
  1049. ASSERT_EQ(non_trivial_move, 0);
  1050. for (int32_t i = 0; i <= 300; i++) {
  1051. ASSERT_EQ(Get(Key(i)), values[i]);
  1052. }
  1053. for (int32_t i = 600; i <= 700; i++) {
  1054. ASSERT_EQ(Get(Key(i)), values[i]);
  1055. }
  1056. }
  1057. TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) {
  1058. int32_t trivial_move = 0;
  1059. int32_t non_trivial_move = 0;
  1060. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1061. "DBImpl::BackgroundCompaction:TrivialMove",
  1062. [&](void* /*arg*/) { trivial_move++; });
  1063. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1064. "DBImpl::BackgroundCompaction:NonTrivial",
  1065. [&](void* /*arg*/) { non_trivial_move++; });
  1066. bool first = true;
  1067. // Purpose of dependencies:
  1068. // 4 -> 1: ensure the order of two non-trivial compactions
  1069. // 5 -> 2 and 5 -> 3: ensure we do a check before two non-trivial compactions
  1070. // are installed
  1071. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  1072. {{"DBCompaction::ManualPartial:4", "DBCompaction::ManualPartial:1"},
  1073. {"DBCompaction::ManualPartial:5", "DBCompaction::ManualPartial:2"},
  1074. {"DBCompaction::ManualPartial:5", "DBCompaction::ManualPartial:3"}});
  1075. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1076. "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) {
  1077. if (first) {
  1078. first = false;
  1079. TEST_SYNC_POINT("DBCompaction::ManualPartial:4");
  1080. TEST_SYNC_POINT("DBCompaction::ManualPartial:3");
  1081. } else { // second non-trivial compaction
  1082. TEST_SYNC_POINT("DBCompaction::ManualPartial:2");
  1083. }
  1084. });
  1085. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  1086. Options options = CurrentOptions();
  1087. options.write_buffer_size = 10 * 1024 * 1024;
  1088. options.num_levels = 7;
  1089. options.max_subcompactions = max_subcompactions_;
  1090. options.level0_file_num_compaction_trigger = 3;
  1091. options.max_background_compactions = 3;
  1092. options.target_file_size_base = 1 << 23; // 8 MB
  1093. DestroyAndReopen(options);
  1094. int32_t value_size = 10 * 1024; // 10 KB
  1095. // Add 2 non-overlapping files
  1096. Random rnd(301);
  1097. std::map<int32_t, std::string> values;
  1098. // file 1 [0 => 100]
  1099. for (int32_t i = 0; i < 100; i++) {
  1100. values[i] = RandomString(&rnd, value_size);
  1101. ASSERT_OK(Put(Key(i), values[i]));
  1102. }
  1103. ASSERT_OK(Flush());
  1104. // file 2 [100 => 300]
  1105. for (int32_t i = 100; i < 300; i++) {
  1106. values[i] = RandomString(&rnd, value_size);
  1107. ASSERT_OK(Put(Key(i), values[i]));
  1108. }
  1109. ASSERT_OK(Flush());
  1110. // 2 files in L0
  1111. ASSERT_EQ("2", FilesPerLevel(0));
  1112. CompactRangeOptions compact_options;
  1113. compact_options.change_level = true;
  1114. compact_options.target_level = 6;
  1115. compact_options.exclusive_manual_compaction = exclusive_manual_compaction_;
  1116. // Trivial move the two non-overlapping files to level 6
  1117. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1118. // 2 files in L6
  1119. ASSERT_EQ("0,0,0,0,0,0,2", FilesPerLevel(0));
  1120. ASSERT_EQ(trivial_move, 1);
  1121. ASSERT_EQ(non_trivial_move, 0);
  1122. // file 3 [ 0 => 200]
  1123. for (int32_t i = 0; i < 200; i++) {
  1124. values[i] = RandomString(&rnd, value_size);
  1125. ASSERT_OK(Put(Key(i), values[i]));
  1126. }
  1127. ASSERT_OK(Flush());
  1128. // 1 files in L0
  1129. ASSERT_EQ("1,0,0,0,0,0,2", FilesPerLevel(0));
  1130. ASSERT_OK(dbfull()->TEST_CompactRange(0, nullptr, nullptr, nullptr, false));
  1131. ASSERT_OK(dbfull()->TEST_CompactRange(1, nullptr, nullptr, nullptr, false));
  1132. ASSERT_OK(dbfull()->TEST_CompactRange(2, nullptr, nullptr, nullptr, false));
  1133. ASSERT_OK(dbfull()->TEST_CompactRange(3, nullptr, nullptr, nullptr, false));
  1134. ASSERT_OK(dbfull()->TEST_CompactRange(4, nullptr, nullptr, nullptr, false));
  1135. // 2 files in L6, 1 file in L5
  1136. ASSERT_EQ("0,0,0,0,0,1,2", FilesPerLevel(0));
  1137. ASSERT_EQ(trivial_move, 6);
  1138. ASSERT_EQ(non_trivial_move, 0);
  1139. ROCKSDB_NAMESPACE::port::Thread threads([&] {
  1140. compact_options.change_level = false;
  1141. compact_options.exclusive_manual_compaction = false;
  1142. std::string begin_string = Key(0);
  1143. std::string end_string = Key(199);
  1144. Slice begin(begin_string);
  1145. Slice end(end_string);
  1146. // First non-trivial compaction is triggered
  1147. ASSERT_OK(db_->CompactRange(compact_options, &begin, &end));
  1148. });
  1149. TEST_SYNC_POINT("DBCompaction::ManualPartial:1");
  1150. // file 4 [300 => 400)
  1151. for (int32_t i = 300; i <= 400; i++) {
  1152. values[i] = RandomString(&rnd, value_size);
  1153. ASSERT_OK(Put(Key(i), values[i]));
  1154. }
  1155. ASSERT_OK(Flush());
  1156. // file 5 [400 => 500)
  1157. for (int32_t i = 400; i <= 500; i++) {
  1158. values[i] = RandomString(&rnd, value_size);
  1159. ASSERT_OK(Put(Key(i), values[i]));
  1160. }
  1161. ASSERT_OK(Flush());
  1162. // file 6 [500 => 600)
  1163. for (int32_t i = 500; i <= 600; i++) {
  1164. values[i] = RandomString(&rnd, value_size);
  1165. ASSERT_OK(Put(Key(i), values[i]));
  1166. }
  1167. // Second non-trivial compaction is triggered
  1168. ASSERT_OK(Flush());
  1169. // Before two non-trivial compactions are installed, there are 3 files in L0
  1170. ASSERT_EQ("3,0,0,0,0,1,2", FilesPerLevel(0));
  1171. TEST_SYNC_POINT("DBCompaction::ManualPartial:5");
  1172. dbfull()->TEST_WaitForFlushMemTable();
  1173. dbfull()->TEST_WaitForCompact();
  1174. // After two non-trivial compactions are installed, there is 1 file in L6, and
  1175. // 1 file in L1
  1176. ASSERT_EQ("0,1,0,0,0,0,1", FilesPerLevel(0));
  1177. threads.join();
  1178. for (int32_t i = 0; i < 600; i++) {
  1179. ASSERT_EQ(Get(Key(i)), values[i]);
  1180. }
  1181. }
  1182. // Disable as the test is flaky.
  1183. TEST_F(DBCompactionTest, DISABLED_ManualPartialFill) {
  1184. int32_t trivial_move = 0;
  1185. int32_t non_trivial_move = 0;
  1186. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1187. "DBImpl::BackgroundCompaction:TrivialMove",
  1188. [&](void* /*arg*/) { trivial_move++; });
  1189. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1190. "DBImpl::BackgroundCompaction:NonTrivial",
  1191. [&](void* /*arg*/) { non_trivial_move++; });
  1192. bool first = true;
  1193. bool second = true;
  1194. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  1195. {{"DBCompaction::PartialFill:4", "DBCompaction::PartialFill:1"},
  1196. {"DBCompaction::PartialFill:2", "DBCompaction::PartialFill:3"}});
  1197. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1198. "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) {
  1199. if (first) {
  1200. TEST_SYNC_POINT("DBCompaction::PartialFill:4");
  1201. first = false;
  1202. TEST_SYNC_POINT("DBCompaction::PartialFill:3");
  1203. } else if (second) {
  1204. }
  1205. });
  1206. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  1207. Options options = CurrentOptions();
  1208. options.write_buffer_size = 10 * 1024 * 1024;
  1209. options.max_bytes_for_level_multiplier = 2;
  1210. options.num_levels = 4;
  1211. options.level0_file_num_compaction_trigger = 3;
  1212. options.max_background_compactions = 3;
  1213. DestroyAndReopen(options);
  1214. // make sure all background compaction jobs can be scheduled
  1215. auto stop_token =
  1216. dbfull()->TEST_write_controler().GetCompactionPressureToken();
  1217. int32_t value_size = 10 * 1024; // 10 KB
  1218. // Add 2 non-overlapping files
  1219. Random rnd(301);
  1220. std::map<int32_t, std::string> values;
  1221. // file 1 [0 => 100]
  1222. for (int32_t i = 0; i < 100; i++) {
  1223. values[i] = RandomString(&rnd, value_size);
  1224. ASSERT_OK(Put(Key(i), values[i]));
  1225. }
  1226. ASSERT_OK(Flush());
  1227. // file 2 [100 => 300]
  1228. for (int32_t i = 100; i < 300; i++) {
  1229. values[i] = RandomString(&rnd, value_size);
  1230. ASSERT_OK(Put(Key(i), values[i]));
  1231. }
  1232. ASSERT_OK(Flush());
  1233. // 2 files in L0
  1234. ASSERT_EQ("2", FilesPerLevel(0));
  1235. CompactRangeOptions compact_options;
  1236. compact_options.change_level = true;
  1237. compact_options.target_level = 2;
  1238. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1239. // 2 files in L2
  1240. ASSERT_EQ("0,0,2", FilesPerLevel(0));
  1241. ASSERT_EQ(trivial_move, 1);
  1242. ASSERT_EQ(non_trivial_move, 0);
  1243. // file 3 [ 0 => 200]
  1244. for (int32_t i = 0; i < 200; i++) {
  1245. values[i] = RandomString(&rnd, value_size);
  1246. ASSERT_OK(Put(Key(i), values[i]));
  1247. }
  1248. ASSERT_OK(Flush());
  1249. // 2 files in L2, 1 in L0
  1250. ASSERT_EQ("1,0,2", FilesPerLevel(0));
  1251. ASSERT_OK(dbfull()->TEST_CompactRange(0, nullptr, nullptr, nullptr, false));
  1252. // 2 files in L2, 1 in L1
  1253. ASSERT_EQ("0,1,2", FilesPerLevel(0));
  1254. ASSERT_EQ(trivial_move, 2);
  1255. ASSERT_EQ(non_trivial_move, 0);
  1256. ROCKSDB_NAMESPACE::port::Thread threads([&] {
  1257. compact_options.change_level = false;
  1258. compact_options.exclusive_manual_compaction = false;
  1259. std::string begin_string = Key(0);
  1260. std::string end_string = Key(199);
  1261. Slice begin(begin_string);
  1262. Slice end(end_string);
  1263. ASSERT_OK(db_->CompactRange(compact_options, &begin, &end));
  1264. });
  1265. TEST_SYNC_POINT("DBCompaction::PartialFill:1");
  1266. // Many files 4 [300 => 4300)
  1267. for (int32_t i = 0; i <= 5; i++) {
  1268. for (int32_t j = 300; j < 4300; j++) {
  1269. if (j == 2300) {
  1270. ASSERT_OK(Flush());
  1271. dbfull()->TEST_WaitForFlushMemTable();
  1272. }
  1273. values[j] = RandomString(&rnd, value_size);
  1274. ASSERT_OK(Put(Key(j), values[j]));
  1275. }
  1276. }
  1277. // Verify level sizes
  1278. uint64_t target_size = 4 * options.max_bytes_for_level_base;
  1279. for (int32_t i = 1; i < options.num_levels; i++) {
  1280. ASSERT_LE(SizeAtLevel(i), target_size);
  1281. target_size = static_cast<uint64_t>(target_size *
  1282. options.max_bytes_for_level_multiplier);
  1283. }
  1284. TEST_SYNC_POINT("DBCompaction::PartialFill:2");
  1285. dbfull()->TEST_WaitForFlushMemTable();
  1286. dbfull()->TEST_WaitForCompact();
  1287. threads.join();
  1288. for (int32_t i = 0; i < 4300; i++) {
  1289. ASSERT_EQ(Get(Key(i)), values[i]);
  1290. }
  1291. }
  1292. TEST_F(DBCompactionTest, ManualCompactionWithUnorderedWrite) {
  1293. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  1294. {{"DBImpl::WriteImpl:UnorderedWriteAfterWriteWAL",
  1295. "DBCompactionTest::ManualCompactionWithUnorderedWrite:WaitWriteWAL"},
  1296. {"DBImpl::WaitForPendingWrites:BeforeBlock",
  1297. "DBImpl::WriteImpl:BeforeUnorderedWriteMemtable"}});
  1298. Options options = CurrentOptions();
  1299. options.unordered_write = true;
  1300. DestroyAndReopen(options);
  1301. Put("foo", "v1");
  1302. ASSERT_OK(Flush());
  1303. Put("bar", "v1");
  1304. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  1305. port::Thread writer([&]() { Put("foo", "v2"); });
  1306. TEST_SYNC_POINT(
  1307. "DBCompactionTest::ManualCompactionWithUnorderedWrite:WaitWriteWAL");
  1308. ASSERT_OK(db_->CompactRange(CompactRangeOptions(), nullptr, nullptr));
  1309. writer.join();
  1310. ASSERT_EQ(Get("foo"), "v2");
  1311. SyncPoint::GetInstance()->DisableProcessing();
  1312. SyncPoint::GetInstance()->ClearAllCallBacks();
  1313. Reopen(options);
  1314. ASSERT_EQ(Get("foo"), "v2");
  1315. }
  1316. TEST_F(DBCompactionTest, DeleteFileRange) {
  1317. Options options = CurrentOptions();
  1318. options.write_buffer_size = 10 * 1024 * 1024;
  1319. options.max_bytes_for_level_multiplier = 2;
  1320. options.num_levels = 4;
  1321. options.level0_file_num_compaction_trigger = 3;
  1322. options.max_background_compactions = 3;
  1323. DestroyAndReopen(options);
  1324. int32_t value_size = 10 * 1024; // 10 KB
  1325. // Add 2 non-overlapping files
  1326. Random rnd(301);
  1327. std::map<int32_t, std::string> values;
  1328. // file 1 [0 => 100]
  1329. for (int32_t i = 0; i < 100; i++) {
  1330. values[i] = RandomString(&rnd, value_size);
  1331. ASSERT_OK(Put(Key(i), values[i]));
  1332. }
  1333. ASSERT_OK(Flush());
  1334. // file 2 [100 => 300]
  1335. for (int32_t i = 100; i < 300; i++) {
  1336. values[i] = RandomString(&rnd, value_size);
  1337. ASSERT_OK(Put(Key(i), values[i]));
  1338. }
  1339. ASSERT_OK(Flush());
  1340. // 2 files in L0
  1341. ASSERT_EQ("2", FilesPerLevel(0));
  1342. CompactRangeOptions compact_options;
  1343. compact_options.change_level = true;
  1344. compact_options.target_level = 2;
  1345. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1346. // 2 files in L2
  1347. ASSERT_EQ("0,0,2", FilesPerLevel(0));
  1348. // file 3 [ 0 => 200]
  1349. for (int32_t i = 0; i < 200; i++) {
  1350. values[i] = RandomString(&rnd, value_size);
  1351. ASSERT_OK(Put(Key(i), values[i]));
  1352. }
  1353. ASSERT_OK(Flush());
  1354. // Many files 4 [300 => 4300)
  1355. for (int32_t i = 0; i <= 5; i++) {
  1356. for (int32_t j = 300; j < 4300; j++) {
  1357. if (j == 2300) {
  1358. ASSERT_OK(Flush());
  1359. dbfull()->TEST_WaitForFlushMemTable();
  1360. }
  1361. values[j] = RandomString(&rnd, value_size);
  1362. ASSERT_OK(Put(Key(j), values[j]));
  1363. }
  1364. }
  1365. ASSERT_OK(Flush());
  1366. dbfull()->TEST_WaitForFlushMemTable();
  1367. dbfull()->TEST_WaitForCompact();
  1368. // Verify level sizes
  1369. uint64_t target_size = 4 * options.max_bytes_for_level_base;
  1370. for (int32_t i = 1; i < options.num_levels; i++) {
  1371. ASSERT_LE(SizeAtLevel(i), target_size);
  1372. target_size = static_cast<uint64_t>(target_size *
  1373. options.max_bytes_for_level_multiplier);
  1374. }
  1375. size_t old_num_files = CountFiles();
  1376. std::string begin_string = Key(1000);
  1377. std::string end_string = Key(2000);
  1378. Slice begin(begin_string);
  1379. Slice end(end_string);
  1380. ASSERT_OK(DeleteFilesInRange(db_, db_->DefaultColumnFamily(), &begin, &end));
  1381. int32_t deleted_count = 0;
  1382. for (int32_t i = 0; i < 4300; i++) {
  1383. if (i < 1000 || i > 2000) {
  1384. ASSERT_EQ(Get(Key(i)), values[i]);
  1385. } else {
  1386. ReadOptions roptions;
  1387. std::string result;
  1388. Status s = db_->Get(roptions, Key(i), &result);
  1389. ASSERT_TRUE(s.IsNotFound() || s.ok());
  1390. if (s.IsNotFound()) {
  1391. deleted_count++;
  1392. }
  1393. }
  1394. }
  1395. ASSERT_GT(deleted_count, 0);
  1396. begin_string = Key(5000);
  1397. end_string = Key(6000);
  1398. Slice begin1(begin_string);
  1399. Slice end1(end_string);
  1400. // Try deleting files in range which contain no keys
  1401. ASSERT_OK(
  1402. DeleteFilesInRange(db_, db_->DefaultColumnFamily(), &begin1, &end1));
  1403. // Push data from level 0 to level 1 to force all data to be deleted
  1404. // Note that we don't delete level 0 files
  1405. compact_options.change_level = true;
  1406. compact_options.target_level = 1;
  1407. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1408. dbfull()->TEST_WaitForCompact();
  1409. ASSERT_OK(
  1410. DeleteFilesInRange(db_, db_->DefaultColumnFamily(), nullptr, nullptr));
  1411. int32_t deleted_count2 = 0;
  1412. for (int32_t i = 0; i < 4300; i++) {
  1413. ReadOptions roptions;
  1414. std::string result;
  1415. Status s = db_->Get(roptions, Key(i), &result);
  1416. ASSERT_TRUE(s.IsNotFound());
  1417. deleted_count2++;
  1418. }
  1419. ASSERT_GT(deleted_count2, deleted_count);
  1420. size_t new_num_files = CountFiles();
  1421. ASSERT_GT(old_num_files, new_num_files);
  1422. }
  1423. TEST_F(DBCompactionTest, DeleteFilesInRanges) {
  1424. Options options = CurrentOptions();
  1425. options.write_buffer_size = 10 * 1024 * 1024;
  1426. options.max_bytes_for_level_multiplier = 2;
  1427. options.num_levels = 4;
  1428. options.max_background_compactions = 3;
  1429. options.disable_auto_compactions = true;
  1430. DestroyAndReopen(options);
  1431. int32_t value_size = 10 * 1024; // 10 KB
  1432. Random rnd(301);
  1433. std::map<int32_t, std::string> values;
  1434. // file [0 => 100), [100 => 200), ... [900, 1000)
  1435. for (auto i = 0; i < 10; i++) {
  1436. for (auto j = 0; j < 100; j++) {
  1437. auto k = i * 100 + j;
  1438. values[k] = RandomString(&rnd, value_size);
  1439. ASSERT_OK(Put(Key(k), values[k]));
  1440. }
  1441. ASSERT_OK(Flush());
  1442. }
  1443. ASSERT_EQ("10", FilesPerLevel(0));
  1444. CompactRangeOptions compact_options;
  1445. compact_options.change_level = true;
  1446. compact_options.target_level = 2;
  1447. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1448. ASSERT_EQ("0,0,10", FilesPerLevel(0));
  1449. // file [0 => 100), [200 => 300), ... [800, 900)
  1450. for (auto i = 0; i < 10; i+=2) {
  1451. for (auto j = 0; j < 100; j++) {
  1452. auto k = i * 100 + j;
  1453. ASSERT_OK(Put(Key(k), values[k]));
  1454. }
  1455. ASSERT_OK(Flush());
  1456. }
  1457. ASSERT_EQ("5,0,10", FilesPerLevel(0));
  1458. ASSERT_OK(dbfull()->TEST_CompactRange(0, nullptr, nullptr));
  1459. ASSERT_EQ("0,5,10", FilesPerLevel(0));
  1460. // Delete files in range [0, 299] (inclusive)
  1461. {
  1462. auto begin_str1 = Key(0), end_str1 = Key(100);
  1463. auto begin_str2 = Key(100), end_str2 = Key(200);
  1464. auto begin_str3 = Key(200), end_str3 = Key(299);
  1465. Slice begin1(begin_str1), end1(end_str1);
  1466. Slice begin2(begin_str2), end2(end_str2);
  1467. Slice begin3(begin_str3), end3(end_str3);
  1468. std::vector<RangePtr> ranges;
  1469. ranges.push_back(RangePtr(&begin1, &end1));
  1470. ranges.push_back(RangePtr(&begin2, &end2));
  1471. ranges.push_back(RangePtr(&begin3, &end3));
  1472. ASSERT_OK(DeleteFilesInRanges(db_, db_->DefaultColumnFamily(),
  1473. ranges.data(), ranges.size()));
  1474. ASSERT_EQ("0,3,7", FilesPerLevel(0));
  1475. // Keys [0, 300) should not exist.
  1476. for (auto i = 0; i < 300; i++) {
  1477. ReadOptions ropts;
  1478. std::string result;
  1479. auto s = db_->Get(ropts, Key(i), &result);
  1480. ASSERT_TRUE(s.IsNotFound());
  1481. }
  1482. for (auto i = 300; i < 1000; i++) {
  1483. ASSERT_EQ(Get(Key(i)), values[i]);
  1484. }
  1485. }
  1486. // Delete files in range [600, 999) (exclusive)
  1487. {
  1488. auto begin_str1 = Key(600), end_str1 = Key(800);
  1489. auto begin_str2 = Key(700), end_str2 = Key(900);
  1490. auto begin_str3 = Key(800), end_str3 = Key(999);
  1491. Slice begin1(begin_str1), end1(end_str1);
  1492. Slice begin2(begin_str2), end2(end_str2);
  1493. Slice begin3(begin_str3), end3(end_str3);
  1494. std::vector<RangePtr> ranges;
  1495. ranges.push_back(RangePtr(&begin1, &end1));
  1496. ranges.push_back(RangePtr(&begin2, &end2));
  1497. ranges.push_back(RangePtr(&begin3, &end3));
  1498. ASSERT_OK(DeleteFilesInRanges(db_, db_->DefaultColumnFamily(),
  1499. ranges.data(), ranges.size(), false));
  1500. ASSERT_EQ("0,1,4", FilesPerLevel(0));
  1501. // Keys [600, 900) should not exist.
  1502. for (auto i = 600; i < 900; i++) {
  1503. ReadOptions ropts;
  1504. std::string result;
  1505. auto s = db_->Get(ropts, Key(i), &result);
  1506. ASSERT_TRUE(s.IsNotFound());
  1507. }
  1508. for (auto i = 300; i < 600; i++) {
  1509. ASSERT_EQ(Get(Key(i)), values[i]);
  1510. }
  1511. for (auto i = 900; i < 1000; i++) {
  1512. ASSERT_EQ(Get(Key(i)), values[i]);
  1513. }
  1514. }
  1515. // Delete all files.
  1516. {
  1517. RangePtr range;
  1518. ASSERT_OK(DeleteFilesInRanges(db_, db_->DefaultColumnFamily(), &range, 1));
  1519. ASSERT_EQ("", FilesPerLevel(0));
  1520. for (auto i = 0; i < 1000; i++) {
  1521. ReadOptions ropts;
  1522. std::string result;
  1523. auto s = db_->Get(ropts, Key(i), &result);
  1524. ASSERT_TRUE(s.IsNotFound());
  1525. }
  1526. }
  1527. }
  1528. TEST_F(DBCompactionTest, DeleteFileRangeFileEndpointsOverlapBug) {
  1529. // regression test for #2833: groups of files whose user-keys overlap at the
  1530. // endpoints could be split by `DeleteFilesInRange`. This caused old data to
  1531. // reappear, either because a new version of the key was removed, or a range
  1532. // deletion was partially dropped. It could also cause non-overlapping
  1533. // invariant to be violated if the files dropped by DeleteFilesInRange were
  1534. // a subset of files that a range deletion spans.
  1535. const int kNumL0Files = 2;
  1536. const int kValSize = 8 << 10; // 8KB
  1537. Options options = CurrentOptions();
  1538. options.level0_file_num_compaction_trigger = kNumL0Files;
  1539. options.target_file_size_base = 1 << 10; // 1KB
  1540. DestroyAndReopen(options);
  1541. // The snapshot prevents key 1 from having its old version dropped. The low
  1542. // `target_file_size_base` ensures two keys will be in each output file.
  1543. const Snapshot* snapshot = nullptr;
  1544. Random rnd(301);
  1545. // The value indicates which flush the key belonged to, which is enough
  1546. // for us to determine the keys' relative ages. After L0 flushes finish,
  1547. // files look like:
  1548. //
  1549. // File 0: 0 -> vals[0], 1 -> vals[0]
  1550. // File 1: 1 -> vals[1], 2 -> vals[1]
  1551. //
  1552. // Then L0->L1 compaction happens, which outputs keys as follows:
  1553. //
  1554. // File 0: 0 -> vals[0], 1 -> vals[1]
  1555. // File 1: 1 -> vals[0], 2 -> vals[1]
  1556. //
  1557. // DeleteFilesInRange shouldn't be allowed to drop just file 0, as that
  1558. // would cause `1 -> vals[0]` (an older key) to reappear.
  1559. std::string vals[kNumL0Files];
  1560. for (int i = 0; i < kNumL0Files; ++i) {
  1561. vals[i] = RandomString(&rnd, kValSize);
  1562. Put(Key(i), vals[i]);
  1563. Put(Key(i + 1), vals[i]);
  1564. Flush();
  1565. if (i == 0) {
  1566. snapshot = db_->GetSnapshot();
  1567. }
  1568. }
  1569. dbfull()->TEST_WaitForCompact();
  1570. // Verify `DeleteFilesInRange` can't drop only file 0 which would cause
  1571. // "1 -> vals[0]" to reappear.
  1572. std::string begin_str = Key(0), end_str = Key(1);
  1573. Slice begin = begin_str, end = end_str;
  1574. ASSERT_OK(DeleteFilesInRange(db_, db_->DefaultColumnFamily(), &begin, &end));
  1575. ASSERT_EQ(vals[1], Get(Key(1)));
  1576. db_->ReleaseSnapshot(snapshot);
  1577. }
  1578. TEST_P(DBCompactionTestWithParam, TrivialMoveToLastLevelWithFiles) {
  1579. int32_t trivial_move = 0;
  1580. int32_t non_trivial_move = 0;
  1581. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1582. "DBImpl::BackgroundCompaction:TrivialMove",
  1583. [&](void* /*arg*/) { trivial_move++; });
  1584. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  1585. "DBImpl::BackgroundCompaction:NonTrivial",
  1586. [&](void* /*arg*/) { non_trivial_move++; });
  1587. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  1588. Options options = CurrentOptions();
  1589. options.write_buffer_size = 100000000;
  1590. options.max_subcompactions = max_subcompactions_;
  1591. DestroyAndReopen(options);
  1592. int32_t value_size = 10 * 1024; // 10 KB
  1593. Random rnd(301);
  1594. std::vector<std::string> values;
  1595. // File with keys [ 0 => 99 ]
  1596. for (int i = 0; i < 100; i++) {
  1597. values.push_back(RandomString(&rnd, value_size));
  1598. ASSERT_OK(Put(Key(i), values[i]));
  1599. }
  1600. ASSERT_OK(Flush());
  1601. ASSERT_EQ("1", FilesPerLevel(0));
  1602. // Compaction will do L0=>L1 (trivial move) then move L1 files to L3
  1603. CompactRangeOptions compact_options;
  1604. compact_options.change_level = true;
  1605. compact_options.target_level = 3;
  1606. compact_options.exclusive_manual_compaction = exclusive_manual_compaction_;
  1607. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  1608. ASSERT_EQ("0,0,0,1", FilesPerLevel(0));
  1609. ASSERT_EQ(trivial_move, 1);
  1610. ASSERT_EQ(non_trivial_move, 0);
  1611. // File with keys [ 100 => 199 ]
  1612. for (int i = 100; i < 200; i++) {
  1613. values.push_back(RandomString(&rnd, value_size));
  1614. ASSERT_OK(Put(Key(i), values[i]));
  1615. }
  1616. ASSERT_OK(Flush());
  1617. ASSERT_EQ("1,0,0,1", FilesPerLevel(0));
  1618. CompactRangeOptions cro;
  1619. cro.exclusive_manual_compaction = exclusive_manual_compaction_;
  1620. // Compaction will do L0=>L1 L1=>L2 L2=>L3 (3 trivial moves)
  1621. ASSERT_OK(db_->CompactRange(cro, nullptr, nullptr));
  1622. ASSERT_EQ("0,0,0,2", FilesPerLevel(0));
  1623. ASSERT_EQ(trivial_move, 4);
  1624. ASSERT_EQ(non_trivial_move, 0);
  1625. for (int i = 0; i < 200; i++) {
  1626. ASSERT_EQ(Get(Key(i)), values[i]);
  1627. }
  1628. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  1629. }
  1630. TEST_P(DBCompactionTestWithParam, LevelCompactionThirdPath) {
  1631. Options options = CurrentOptions();
  1632. options.db_paths.emplace_back(dbname_, 500 * 1024);
  1633. options.db_paths.emplace_back(dbname_ + "_2", 4 * 1024 * 1024);
  1634. options.db_paths.emplace_back(dbname_ + "_3", 1024 * 1024 * 1024);
  1635. options.memtable_factory.reset(
  1636. new SpecialSkipListFactory(KNumKeysByGenerateNewFile - 1));
  1637. options.compaction_style = kCompactionStyleLevel;
  1638. options.write_buffer_size = 110 << 10; // 110KB
  1639. options.arena_block_size = 4 << 10;
  1640. options.level0_file_num_compaction_trigger = 2;
  1641. options.num_levels = 4;
  1642. options.max_bytes_for_level_base = 400 * 1024;
  1643. options.max_subcompactions = max_subcompactions_;
  1644. // options = CurrentOptions(options);
  1645. std::vector<std::string> filenames;
  1646. env_->GetChildren(options.db_paths[1].path, &filenames);
  1647. // Delete archival files.
  1648. for (size_t i = 0; i < filenames.size(); ++i) {
  1649. env_->DeleteFile(options.db_paths[1].path + "/" + filenames[i]);
  1650. }
  1651. env_->DeleteDir(options.db_paths[1].path);
  1652. Reopen(options);
  1653. Random rnd(301);
  1654. int key_idx = 0;
  1655. // First three 110KB files are not going to second path.
  1656. // After that, (100K, 200K)
  1657. for (int num = 0; num < 3; num++) {
  1658. GenerateNewFile(&rnd, &key_idx);
  1659. }
  1660. // Another 110KB triggers a compaction to 400K file to fill up first path
  1661. GenerateNewFile(&rnd, &key_idx);
  1662. ASSERT_EQ(3, GetSstFileCount(options.db_paths[1].path));
  1663. // (1, 4)
  1664. GenerateNewFile(&rnd, &key_idx);
  1665. ASSERT_EQ("1,4", FilesPerLevel(0));
  1666. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1667. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1668. // (1, 4, 1)
  1669. GenerateNewFile(&rnd, &key_idx);
  1670. ASSERT_EQ("1,4,1", FilesPerLevel(0));
  1671. ASSERT_EQ(1, GetSstFileCount(options.db_paths[2].path));
  1672. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1673. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1674. // (1, 4, 2)
  1675. GenerateNewFile(&rnd, &key_idx);
  1676. ASSERT_EQ("1,4,2", FilesPerLevel(0));
  1677. ASSERT_EQ(2, GetSstFileCount(options.db_paths[2].path));
  1678. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1679. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1680. // (1, 4, 3)
  1681. GenerateNewFile(&rnd, &key_idx);
  1682. ASSERT_EQ("1,4,3", FilesPerLevel(0));
  1683. ASSERT_EQ(3, GetSstFileCount(options.db_paths[2].path));
  1684. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1685. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1686. // (1, 4, 4)
  1687. GenerateNewFile(&rnd, &key_idx);
  1688. ASSERT_EQ("1,4,4", FilesPerLevel(0));
  1689. ASSERT_EQ(4, GetSstFileCount(options.db_paths[2].path));
  1690. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1691. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1692. // (1, 4, 5)
  1693. GenerateNewFile(&rnd, &key_idx);
  1694. ASSERT_EQ("1,4,5", FilesPerLevel(0));
  1695. ASSERT_EQ(5, GetSstFileCount(options.db_paths[2].path));
  1696. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1697. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1698. // (1, 4, 6)
  1699. GenerateNewFile(&rnd, &key_idx);
  1700. ASSERT_EQ("1,4,6", FilesPerLevel(0));
  1701. ASSERT_EQ(6, GetSstFileCount(options.db_paths[2].path));
  1702. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1703. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1704. // (1, 4, 7)
  1705. GenerateNewFile(&rnd, &key_idx);
  1706. ASSERT_EQ("1,4,7", FilesPerLevel(0));
  1707. ASSERT_EQ(7, GetSstFileCount(options.db_paths[2].path));
  1708. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1709. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1710. // (1, 4, 8)
  1711. GenerateNewFile(&rnd, &key_idx);
  1712. ASSERT_EQ("1,4,8", FilesPerLevel(0));
  1713. ASSERT_EQ(8, GetSstFileCount(options.db_paths[2].path));
  1714. ASSERT_EQ(4, GetSstFileCount(options.db_paths[1].path));
  1715. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1716. for (int i = 0; i < key_idx; i++) {
  1717. auto v = Get(Key(i));
  1718. ASSERT_NE(v, "NOT_FOUND");
  1719. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1720. }
  1721. Reopen(options);
  1722. for (int i = 0; i < key_idx; i++) {
  1723. auto v = Get(Key(i));
  1724. ASSERT_NE(v, "NOT_FOUND");
  1725. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1726. }
  1727. Destroy(options);
  1728. }
  1729. TEST_P(DBCompactionTestWithParam, LevelCompactionPathUse) {
  1730. Options options = CurrentOptions();
  1731. options.db_paths.emplace_back(dbname_, 500 * 1024);
  1732. options.db_paths.emplace_back(dbname_ + "_2", 4 * 1024 * 1024);
  1733. options.db_paths.emplace_back(dbname_ + "_3", 1024 * 1024 * 1024);
  1734. options.memtable_factory.reset(
  1735. new SpecialSkipListFactory(KNumKeysByGenerateNewFile - 1));
  1736. options.compaction_style = kCompactionStyleLevel;
  1737. options.write_buffer_size = 110 << 10; // 110KB
  1738. options.arena_block_size = 4 << 10;
  1739. options.level0_file_num_compaction_trigger = 2;
  1740. options.num_levels = 4;
  1741. options.max_bytes_for_level_base = 400 * 1024;
  1742. options.max_subcompactions = max_subcompactions_;
  1743. // options = CurrentOptions(options);
  1744. std::vector<std::string> filenames;
  1745. env_->GetChildren(options.db_paths[1].path, &filenames);
  1746. // Delete archival files.
  1747. for (size_t i = 0; i < filenames.size(); ++i) {
  1748. env_->DeleteFile(options.db_paths[1].path + "/" + filenames[i]);
  1749. }
  1750. env_->DeleteDir(options.db_paths[1].path);
  1751. Reopen(options);
  1752. Random rnd(301);
  1753. int key_idx = 0;
  1754. // Always gets compacted into 1 Level1 file,
  1755. // 0/1 Level 0 file
  1756. for (int num = 0; num < 3; num++) {
  1757. key_idx = 0;
  1758. GenerateNewFile(&rnd, &key_idx);
  1759. }
  1760. key_idx = 0;
  1761. GenerateNewFile(&rnd, &key_idx);
  1762. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1763. key_idx = 0;
  1764. GenerateNewFile(&rnd, &key_idx);
  1765. ASSERT_EQ("1,1", FilesPerLevel(0));
  1766. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1767. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1768. key_idx = 0;
  1769. GenerateNewFile(&rnd, &key_idx);
  1770. ASSERT_EQ("0,1", FilesPerLevel(0));
  1771. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1772. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1773. ASSERT_EQ(0, GetSstFileCount(dbname_));
  1774. key_idx = 0;
  1775. GenerateNewFile(&rnd, &key_idx);
  1776. ASSERT_EQ("1,1", FilesPerLevel(0));
  1777. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1778. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1779. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1780. key_idx = 0;
  1781. GenerateNewFile(&rnd, &key_idx);
  1782. ASSERT_EQ("0,1", FilesPerLevel(0));
  1783. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1784. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1785. ASSERT_EQ(0, GetSstFileCount(dbname_));
  1786. key_idx = 0;
  1787. GenerateNewFile(&rnd, &key_idx);
  1788. ASSERT_EQ("1,1", FilesPerLevel(0));
  1789. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1790. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1791. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1792. key_idx = 0;
  1793. GenerateNewFile(&rnd, &key_idx);
  1794. ASSERT_EQ("0,1", FilesPerLevel(0));
  1795. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1796. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1797. ASSERT_EQ(0, GetSstFileCount(dbname_));
  1798. key_idx = 0;
  1799. GenerateNewFile(&rnd, &key_idx);
  1800. ASSERT_EQ("1,1", FilesPerLevel(0));
  1801. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1802. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1803. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1804. key_idx = 0;
  1805. GenerateNewFile(&rnd, &key_idx);
  1806. ASSERT_EQ("0,1", FilesPerLevel(0));
  1807. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1808. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1809. ASSERT_EQ(0, GetSstFileCount(dbname_));
  1810. key_idx = 0;
  1811. GenerateNewFile(&rnd, &key_idx);
  1812. ASSERT_EQ("1,1", FilesPerLevel(0));
  1813. ASSERT_EQ(0, GetSstFileCount(options.db_paths[2].path));
  1814. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  1815. ASSERT_EQ(1, GetSstFileCount(dbname_));
  1816. for (int i = 0; i < key_idx; i++) {
  1817. auto v = Get(Key(i));
  1818. ASSERT_NE(v, "NOT_FOUND");
  1819. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1820. }
  1821. Reopen(options);
  1822. for (int i = 0; i < key_idx; i++) {
  1823. auto v = Get(Key(i));
  1824. ASSERT_NE(v, "NOT_FOUND");
  1825. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1826. }
  1827. Destroy(options);
  1828. }
  1829. TEST_P(DBCompactionTestWithParam, LevelCompactionCFPathUse) {
  1830. Options options = CurrentOptions();
  1831. options.db_paths.emplace_back(dbname_, 500 * 1024);
  1832. options.db_paths.emplace_back(dbname_ + "_2", 4 * 1024 * 1024);
  1833. options.db_paths.emplace_back(dbname_ + "_3", 1024 * 1024 * 1024);
  1834. options.memtable_factory.reset(
  1835. new SpecialSkipListFactory(KNumKeysByGenerateNewFile - 1));
  1836. options.compaction_style = kCompactionStyleLevel;
  1837. options.write_buffer_size = 110 << 10; // 110KB
  1838. options.arena_block_size = 4 << 10;
  1839. options.level0_file_num_compaction_trigger = 2;
  1840. options.num_levels = 4;
  1841. options.max_bytes_for_level_base = 400 * 1024;
  1842. options.max_subcompactions = max_subcompactions_;
  1843. std::vector<Options> option_vector;
  1844. option_vector.emplace_back(options);
  1845. ColumnFamilyOptions cf_opt1(options), cf_opt2(options);
  1846. // Configure CF1 specific paths.
  1847. cf_opt1.cf_paths.emplace_back(dbname_ + "cf1", 500 * 1024);
  1848. cf_opt1.cf_paths.emplace_back(dbname_ + "cf1_2", 4 * 1024 * 1024);
  1849. cf_opt1.cf_paths.emplace_back(dbname_ + "cf1_3", 1024 * 1024 * 1024);
  1850. option_vector.emplace_back(DBOptions(options), cf_opt1);
  1851. CreateColumnFamilies({"one"},option_vector[1]);
  1852. // Configura CF2 specific paths.
  1853. cf_opt2.cf_paths.emplace_back(dbname_ + "cf2", 500 * 1024);
  1854. cf_opt2.cf_paths.emplace_back(dbname_ + "cf2_2", 4 * 1024 * 1024);
  1855. cf_opt2.cf_paths.emplace_back(dbname_ + "cf2_3", 1024 * 1024 * 1024);
  1856. option_vector.emplace_back(DBOptions(options), cf_opt2);
  1857. CreateColumnFamilies({"two"},option_vector[2]);
  1858. ReopenWithColumnFamilies({"default", "one", "two"}, option_vector);
  1859. Random rnd(301);
  1860. int key_idx = 0;
  1861. int key_idx1 = 0;
  1862. int key_idx2 = 0;
  1863. auto generate_file = [&]() {
  1864. GenerateNewFile(0, &rnd, &key_idx);
  1865. GenerateNewFile(1, &rnd, &key_idx1);
  1866. GenerateNewFile(2, &rnd, &key_idx2);
  1867. };
  1868. auto check_sstfilecount = [&](int path_id, int expected) {
  1869. ASSERT_EQ(expected, GetSstFileCount(options.db_paths[path_id].path));
  1870. ASSERT_EQ(expected, GetSstFileCount(cf_opt1.cf_paths[path_id].path));
  1871. ASSERT_EQ(expected, GetSstFileCount(cf_opt2.cf_paths[path_id].path));
  1872. };
  1873. auto check_filesperlevel = [&](const std::string& expected) {
  1874. ASSERT_EQ(expected, FilesPerLevel(0));
  1875. ASSERT_EQ(expected, FilesPerLevel(1));
  1876. ASSERT_EQ(expected, FilesPerLevel(2));
  1877. };
  1878. auto check_getvalues = [&]() {
  1879. for (int i = 0; i < key_idx; i++) {
  1880. auto v = Get(0, Key(i));
  1881. ASSERT_NE(v, "NOT_FOUND");
  1882. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1883. }
  1884. for (int i = 0; i < key_idx1; i++) {
  1885. auto v = Get(1, Key(i));
  1886. ASSERT_NE(v, "NOT_FOUND");
  1887. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1888. }
  1889. for (int i = 0; i < key_idx2; i++) {
  1890. auto v = Get(2, Key(i));
  1891. ASSERT_NE(v, "NOT_FOUND");
  1892. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  1893. }
  1894. };
  1895. // Check that default column family uses db_paths.
  1896. // And Column family "one" uses cf_paths.
  1897. // First three 110KB files are not going to second path.
  1898. // After that, (100K, 200K)
  1899. for (int num = 0; num < 3; num++) {
  1900. generate_file();
  1901. }
  1902. // Another 110KB triggers a compaction to 400K file to fill up first path
  1903. generate_file();
  1904. check_sstfilecount(1, 3);
  1905. // (1, 4)
  1906. generate_file();
  1907. check_filesperlevel("1,4");
  1908. check_sstfilecount(1, 4);
  1909. check_sstfilecount(0, 1);
  1910. // (1, 4, 1)
  1911. generate_file();
  1912. check_filesperlevel("1,4,1");
  1913. check_sstfilecount(2, 1);
  1914. check_sstfilecount(1, 4);
  1915. check_sstfilecount(0, 1);
  1916. // (1, 4, 2)
  1917. generate_file();
  1918. check_filesperlevel("1,4,2");
  1919. check_sstfilecount(2, 2);
  1920. check_sstfilecount(1, 4);
  1921. check_sstfilecount(0, 1);
  1922. check_getvalues();
  1923. ReopenWithColumnFamilies({"default", "one", "two"}, option_vector);
  1924. check_getvalues();
  1925. Destroy(options, true);
  1926. }
  1927. TEST_P(DBCompactionTestWithParam, ConvertCompactionStyle) {
  1928. Random rnd(301);
  1929. int max_key_level_insert = 200;
  1930. int max_key_universal_insert = 600;
  1931. // Stage 1: generate a db with level compaction
  1932. Options options = CurrentOptions();
  1933. options.write_buffer_size = 110 << 10; // 110KB
  1934. options.arena_block_size = 4 << 10;
  1935. options.num_levels = 4;
  1936. options.level0_file_num_compaction_trigger = 3;
  1937. options.max_bytes_for_level_base = 500 << 10; // 500KB
  1938. options.max_bytes_for_level_multiplier = 1;
  1939. options.target_file_size_base = 200 << 10; // 200KB
  1940. options.target_file_size_multiplier = 1;
  1941. options.max_subcompactions = max_subcompactions_;
  1942. CreateAndReopenWithCF({"pikachu"}, options);
  1943. for (int i = 0; i <= max_key_level_insert; i++) {
  1944. // each value is 10K
  1945. ASSERT_OK(Put(1, Key(i), RandomString(&rnd, 10000)));
  1946. }
  1947. ASSERT_OK(Flush(1));
  1948. dbfull()->TEST_WaitForCompact();
  1949. ASSERT_GT(TotalTableFiles(1, 4), 1);
  1950. int non_level0_num_files = 0;
  1951. for (int i = 1; i < options.num_levels; i++) {
  1952. non_level0_num_files += NumTableFilesAtLevel(i, 1);
  1953. }
  1954. ASSERT_GT(non_level0_num_files, 0);
  1955. // Stage 2: reopen with universal compaction - should fail
  1956. options = CurrentOptions();
  1957. options.compaction_style = kCompactionStyleUniversal;
  1958. options.num_levels = 1;
  1959. options = CurrentOptions(options);
  1960. Status s = TryReopenWithColumnFamilies({"default", "pikachu"}, options);
  1961. ASSERT_TRUE(s.IsInvalidArgument());
  1962. // Stage 3: compact into a single file and move the file to level 0
  1963. options = CurrentOptions();
  1964. options.disable_auto_compactions = true;
  1965. options.target_file_size_base = INT_MAX;
  1966. options.target_file_size_multiplier = 1;
  1967. options.max_bytes_for_level_base = INT_MAX;
  1968. options.max_bytes_for_level_multiplier = 1;
  1969. options.num_levels = 4;
  1970. options = CurrentOptions(options);
  1971. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  1972. CompactRangeOptions compact_options;
  1973. compact_options.change_level = true;
  1974. compact_options.target_level = 0;
  1975. // cannot use kForceOptimized here because the compaction here is expected
  1976. // to generate one output file
  1977. compact_options.bottommost_level_compaction =
  1978. BottommostLevelCompaction::kForce;
  1979. compact_options.exclusive_manual_compaction = exclusive_manual_compaction_;
  1980. dbfull()->CompactRange(compact_options, handles_[1], nullptr, nullptr);
  1981. // Only 1 file in L0
  1982. ASSERT_EQ("1", FilesPerLevel(1));
  1983. // Stage 4: re-open in universal compaction style and do some db operations
  1984. options = CurrentOptions();
  1985. options.compaction_style = kCompactionStyleUniversal;
  1986. options.num_levels = 4;
  1987. options.write_buffer_size = 110 << 10; // 110KB
  1988. options.arena_block_size = 4 << 10;
  1989. options.level0_file_num_compaction_trigger = 3;
  1990. options = CurrentOptions(options);
  1991. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  1992. options.num_levels = 1;
  1993. ReopenWithColumnFamilies({"default", "pikachu"}, options);
  1994. for (int i = max_key_level_insert / 2; i <= max_key_universal_insert; i++) {
  1995. ASSERT_OK(Put(1, Key(i), RandomString(&rnd, 10000)));
  1996. }
  1997. dbfull()->Flush(FlushOptions());
  1998. ASSERT_OK(Flush(1));
  1999. dbfull()->TEST_WaitForCompact();
  2000. for (int i = 1; i < options.num_levels; i++) {
  2001. ASSERT_EQ(NumTableFilesAtLevel(i, 1), 0);
  2002. }
  2003. // verify keys inserted in both level compaction style and universal
  2004. // compaction style
  2005. std::string keys_in_db;
  2006. Iterator* iter = dbfull()->NewIterator(ReadOptions(), handles_[1]);
  2007. for (iter->SeekToFirst(); iter->Valid(); iter->Next()) {
  2008. keys_in_db.append(iter->key().ToString());
  2009. keys_in_db.push_back(',');
  2010. }
  2011. delete iter;
  2012. std::string expected_keys;
  2013. for (int i = 0; i <= max_key_universal_insert; i++) {
  2014. expected_keys.append(Key(i));
  2015. expected_keys.push_back(',');
  2016. }
  2017. ASSERT_EQ(keys_in_db, expected_keys);
  2018. }
  2019. TEST_F(DBCompactionTest, L0_CompactionBug_Issue44_a) {
  2020. do {
  2021. CreateAndReopenWithCF({"pikachu"}, CurrentOptions());
  2022. ASSERT_OK(Put(1, "b", "v"));
  2023. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2024. ASSERT_OK(Delete(1, "b"));
  2025. ASSERT_OK(Delete(1, "a"));
  2026. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2027. ASSERT_OK(Delete(1, "a"));
  2028. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2029. ASSERT_OK(Put(1, "a", "v"));
  2030. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2031. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2032. ASSERT_EQ("(a->v)", Contents(1));
  2033. env_->SleepForMicroseconds(1000000); // Wait for compaction to finish
  2034. ASSERT_EQ("(a->v)", Contents(1));
  2035. } while (ChangeCompactOptions());
  2036. }
  2037. TEST_F(DBCompactionTest, L0_CompactionBug_Issue44_b) {
  2038. do {
  2039. CreateAndReopenWithCF({"pikachu"}, CurrentOptions());
  2040. Put(1, "", "");
  2041. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2042. Delete(1, "e");
  2043. Put(1, "", "");
  2044. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2045. Put(1, "c", "cv");
  2046. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2047. Put(1, "", "");
  2048. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2049. Put(1, "", "");
  2050. env_->SleepForMicroseconds(1000000); // Wait for compaction to finish
  2051. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2052. Put(1, "d", "dv");
  2053. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2054. Put(1, "", "");
  2055. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2056. Delete(1, "d");
  2057. Delete(1, "b");
  2058. ReopenWithColumnFamilies({"default", "pikachu"}, CurrentOptions());
  2059. ASSERT_EQ("(->)(c->cv)", Contents(1));
  2060. env_->SleepForMicroseconds(1000000); // Wait for compaction to finish
  2061. ASSERT_EQ("(->)(c->cv)", Contents(1));
  2062. } while (ChangeCompactOptions());
  2063. }
  2064. TEST_F(DBCompactionTest, ManualAutoRace) {
  2065. CreateAndReopenWithCF({"pikachu"}, CurrentOptions());
  2066. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  2067. {{"DBImpl::BGWorkCompaction", "DBCompactionTest::ManualAutoRace:1"},
  2068. {"DBImpl::RunManualCompaction:WaitScheduled",
  2069. "BackgroundCallCompaction:0"}});
  2070. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2071. Put(1, "foo", "");
  2072. Put(1, "bar", "");
  2073. Flush(1);
  2074. Put(1, "foo", "");
  2075. Put(1, "bar", "");
  2076. // Generate four files in CF 0, which should trigger an auto compaction
  2077. Put("foo", "");
  2078. Put("bar", "");
  2079. Flush();
  2080. Put("foo", "");
  2081. Put("bar", "");
  2082. Flush();
  2083. Put("foo", "");
  2084. Put("bar", "");
  2085. Flush();
  2086. Put("foo", "");
  2087. Put("bar", "");
  2088. Flush();
  2089. // The auto compaction is scheduled but waited until here
  2090. TEST_SYNC_POINT("DBCompactionTest::ManualAutoRace:1");
  2091. // The auto compaction will wait until the manual compaction is registerd
  2092. // before processing so that it will be cancelled.
  2093. dbfull()->CompactRange(CompactRangeOptions(), handles_[1], nullptr, nullptr);
  2094. ASSERT_EQ("0,1", FilesPerLevel(1));
  2095. // Eventually the cancelled compaction will be rescheduled and executed.
  2096. dbfull()->TEST_WaitForCompact();
  2097. ASSERT_EQ("0,1", FilesPerLevel(0));
  2098. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2099. }
  2100. TEST_P(DBCompactionTestWithParam, ManualCompaction) {
  2101. Options options = CurrentOptions();
  2102. options.max_subcompactions = max_subcompactions_;
  2103. options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics();
  2104. CreateAndReopenWithCF({"pikachu"}, options);
  2105. // iter - 0 with 7 levels
  2106. // iter - 1 with 3 levels
  2107. for (int iter = 0; iter < 2; ++iter) {
  2108. MakeTables(3, "p", "q", 1);
  2109. ASSERT_EQ("1,1,1", FilesPerLevel(1));
  2110. // Compaction range falls before files
  2111. Compact(1, "", "c");
  2112. ASSERT_EQ("1,1,1", FilesPerLevel(1));
  2113. // Compaction range falls after files
  2114. Compact(1, "r", "z");
  2115. ASSERT_EQ("1,1,1", FilesPerLevel(1));
  2116. // Compaction range overlaps files
  2117. Compact(1, "p1", "p9");
  2118. ASSERT_EQ("0,0,1", FilesPerLevel(1));
  2119. // Populate a different range
  2120. MakeTables(3, "c", "e", 1);
  2121. ASSERT_EQ("1,1,2", FilesPerLevel(1));
  2122. // Compact just the new range
  2123. Compact(1, "b", "f");
  2124. ASSERT_EQ("0,0,2", FilesPerLevel(1));
  2125. // Compact all
  2126. MakeTables(1, "a", "z", 1);
  2127. ASSERT_EQ("1,0,2", FilesPerLevel(1));
  2128. uint64_t prev_block_cache_add =
  2129. options.statistics->getTickerCount(BLOCK_CACHE_ADD);
  2130. CompactRangeOptions cro;
  2131. cro.exclusive_manual_compaction = exclusive_manual_compaction_;
  2132. db_->CompactRange(cro, handles_[1], nullptr, nullptr);
  2133. // Verify manual compaction doesn't fill block cache
  2134. ASSERT_EQ(prev_block_cache_add,
  2135. options.statistics->getTickerCount(BLOCK_CACHE_ADD));
  2136. ASSERT_EQ("0,0,1", FilesPerLevel(1));
  2137. if (iter == 0) {
  2138. options = CurrentOptions();
  2139. options.num_levels = 3;
  2140. options.create_if_missing = true;
  2141. options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics();
  2142. DestroyAndReopen(options);
  2143. CreateAndReopenWithCF({"pikachu"}, options);
  2144. }
  2145. }
  2146. }
  2147. TEST_P(DBCompactionTestWithParam, ManualLevelCompactionOutputPathId) {
  2148. Options options = CurrentOptions();
  2149. options.db_paths.emplace_back(dbname_ + "_2", 2 * 10485760);
  2150. options.db_paths.emplace_back(dbname_ + "_3", 100 * 10485760);
  2151. options.db_paths.emplace_back(dbname_ + "_4", 120 * 10485760);
  2152. options.max_subcompactions = max_subcompactions_;
  2153. CreateAndReopenWithCF({"pikachu"}, options);
  2154. // iter - 0 with 7 levels
  2155. // iter - 1 with 3 levels
  2156. for (int iter = 0; iter < 2; ++iter) {
  2157. for (int i = 0; i < 3; ++i) {
  2158. ASSERT_OK(Put(1, "p", "begin"));
  2159. ASSERT_OK(Put(1, "q", "end"));
  2160. ASSERT_OK(Flush(1));
  2161. }
  2162. ASSERT_EQ("3", FilesPerLevel(1));
  2163. ASSERT_EQ(3, GetSstFileCount(options.db_paths[0].path));
  2164. ASSERT_EQ(0, GetSstFileCount(dbname_));
  2165. // Compaction range falls before files
  2166. Compact(1, "", "c");
  2167. ASSERT_EQ("3", FilesPerLevel(1));
  2168. // Compaction range falls after files
  2169. Compact(1, "r", "z");
  2170. ASSERT_EQ("3", FilesPerLevel(1));
  2171. // Compaction range overlaps files
  2172. Compact(1, "p1", "p9", 1);
  2173. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  2174. ASSERT_EQ("0,1", FilesPerLevel(1));
  2175. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  2176. ASSERT_EQ(0, GetSstFileCount(options.db_paths[0].path));
  2177. ASSERT_EQ(0, GetSstFileCount(dbname_));
  2178. // Populate a different range
  2179. for (int i = 0; i < 3; ++i) {
  2180. ASSERT_OK(Put(1, "c", "begin"));
  2181. ASSERT_OK(Put(1, "e", "end"));
  2182. ASSERT_OK(Flush(1));
  2183. }
  2184. ASSERT_EQ("3,1", FilesPerLevel(1));
  2185. // Compact just the new range
  2186. Compact(1, "b", "f", 1);
  2187. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  2188. ASSERT_EQ("0,2", FilesPerLevel(1));
  2189. ASSERT_EQ(2, GetSstFileCount(options.db_paths[1].path));
  2190. ASSERT_EQ(0, GetSstFileCount(options.db_paths[0].path));
  2191. ASSERT_EQ(0, GetSstFileCount(dbname_));
  2192. // Compact all
  2193. ASSERT_OK(Put(1, "a", "begin"));
  2194. ASSERT_OK(Put(1, "z", "end"));
  2195. ASSERT_OK(Flush(1));
  2196. ASSERT_EQ("1,2", FilesPerLevel(1));
  2197. ASSERT_EQ(2, GetSstFileCount(options.db_paths[1].path));
  2198. ASSERT_EQ(1, GetSstFileCount(options.db_paths[0].path));
  2199. CompactRangeOptions compact_options;
  2200. compact_options.target_path_id = 1;
  2201. compact_options.exclusive_manual_compaction = exclusive_manual_compaction_;
  2202. db_->CompactRange(compact_options, handles_[1], nullptr, nullptr);
  2203. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  2204. ASSERT_EQ("0,1", FilesPerLevel(1));
  2205. ASSERT_EQ(1, GetSstFileCount(options.db_paths[1].path));
  2206. ASSERT_EQ(0, GetSstFileCount(options.db_paths[0].path));
  2207. ASSERT_EQ(0, GetSstFileCount(dbname_));
  2208. if (iter == 0) {
  2209. DestroyAndReopen(options);
  2210. options = CurrentOptions();
  2211. options.db_paths.emplace_back(dbname_ + "_2", 2 * 10485760);
  2212. options.db_paths.emplace_back(dbname_ + "_3", 100 * 10485760);
  2213. options.db_paths.emplace_back(dbname_ + "_4", 120 * 10485760);
  2214. options.max_background_flushes = 1;
  2215. options.num_levels = 3;
  2216. options.create_if_missing = true;
  2217. CreateAndReopenWithCF({"pikachu"}, options);
  2218. }
  2219. }
  2220. }
  2221. TEST_F(DBCompactionTest, FilesDeletedAfterCompaction) {
  2222. do {
  2223. CreateAndReopenWithCF({"pikachu"}, CurrentOptions());
  2224. ASSERT_OK(Put(1, "foo", "v2"));
  2225. Compact(1, "a", "z");
  2226. const size_t num_files = CountLiveFiles();
  2227. for (int i = 0; i < 10; i++) {
  2228. ASSERT_OK(Put(1, "foo", "v2"));
  2229. Compact(1, "a", "z");
  2230. }
  2231. ASSERT_EQ(CountLiveFiles(), num_files);
  2232. } while (ChangeCompactOptions());
  2233. }
  2234. // Check level comapction with compact files
  2235. TEST_P(DBCompactionTestWithParam, DISABLED_CompactFilesOnLevelCompaction) {
  2236. const int kTestKeySize = 16;
  2237. const int kTestValueSize = 984;
  2238. const int kEntrySize = kTestKeySize + kTestValueSize;
  2239. const int kEntriesPerBuffer = 100;
  2240. Options options;
  2241. options.create_if_missing = true;
  2242. options.write_buffer_size = kEntrySize * kEntriesPerBuffer;
  2243. options.compaction_style = kCompactionStyleLevel;
  2244. options.target_file_size_base = options.write_buffer_size;
  2245. options.max_bytes_for_level_base = options.target_file_size_base * 2;
  2246. options.level0_stop_writes_trigger = 2;
  2247. options.max_bytes_for_level_multiplier = 2;
  2248. options.compression = kNoCompression;
  2249. options.max_subcompactions = max_subcompactions_;
  2250. options = CurrentOptions(options);
  2251. CreateAndReopenWithCF({"pikachu"}, options);
  2252. Random rnd(301);
  2253. for (int key = 64 * kEntriesPerBuffer; key >= 0; --key) {
  2254. ASSERT_OK(Put(1, ToString(key), RandomString(&rnd, kTestValueSize)));
  2255. }
  2256. dbfull()->TEST_WaitForFlushMemTable(handles_[1]);
  2257. dbfull()->TEST_WaitForCompact();
  2258. ColumnFamilyMetaData cf_meta;
  2259. dbfull()->GetColumnFamilyMetaData(handles_[1], &cf_meta);
  2260. int output_level = static_cast<int>(cf_meta.levels.size()) - 1;
  2261. for (int file_picked = 5; file_picked > 0; --file_picked) {
  2262. std::set<std::string> overlapping_file_names;
  2263. std::vector<std::string> compaction_input_file_names;
  2264. for (int f = 0; f < file_picked; ++f) {
  2265. int level = 0;
  2266. auto file_meta = PickFileRandomly(cf_meta, &rnd, &level);
  2267. compaction_input_file_names.push_back(file_meta->name);
  2268. GetOverlappingFileNumbersForLevelCompaction(
  2269. cf_meta, options.comparator, level, output_level,
  2270. file_meta, &overlapping_file_names);
  2271. }
  2272. ASSERT_OK(dbfull()->CompactFiles(
  2273. CompactionOptions(), handles_[1],
  2274. compaction_input_file_names,
  2275. output_level));
  2276. // Make sure all overlapping files do not exist after compaction
  2277. dbfull()->GetColumnFamilyMetaData(handles_[1], &cf_meta);
  2278. VerifyCompactionResult(cf_meta, overlapping_file_names);
  2279. }
  2280. // make sure all key-values are still there.
  2281. for (int key = 64 * kEntriesPerBuffer; key >= 0; --key) {
  2282. ASSERT_NE(Get(1, ToString(key)), "NOT_FOUND");
  2283. }
  2284. }
  2285. TEST_P(DBCompactionTestWithParam, PartialCompactionFailure) {
  2286. Options options;
  2287. const int kKeySize = 16;
  2288. const int kKvSize = 1000;
  2289. const int kKeysPerBuffer = 100;
  2290. const int kNumL1Files = 5;
  2291. options.create_if_missing = true;
  2292. options.write_buffer_size = kKeysPerBuffer * kKvSize;
  2293. options.max_write_buffer_number = 2;
  2294. options.target_file_size_base =
  2295. options.write_buffer_size *
  2296. (options.max_write_buffer_number - 1);
  2297. options.level0_file_num_compaction_trigger = kNumL1Files;
  2298. options.max_bytes_for_level_base =
  2299. options.level0_file_num_compaction_trigger *
  2300. options.target_file_size_base;
  2301. options.max_bytes_for_level_multiplier = 2;
  2302. options.compression = kNoCompression;
  2303. options.max_subcompactions = max_subcompactions_;
  2304. env_->SetBackgroundThreads(1, Env::HIGH);
  2305. env_->SetBackgroundThreads(1, Env::LOW);
  2306. // stop the compaction thread until we simulate the file creation failure.
  2307. test::SleepingBackgroundTask sleeping_task_low;
  2308. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask, &sleeping_task_low,
  2309. Env::Priority::LOW);
  2310. options.env = env_;
  2311. DestroyAndReopen(options);
  2312. const int kNumInsertedKeys =
  2313. options.level0_file_num_compaction_trigger *
  2314. (options.max_write_buffer_number - 1) *
  2315. kKeysPerBuffer;
  2316. Random rnd(301);
  2317. std::vector<std::string> keys;
  2318. std::vector<std::string> values;
  2319. for (int k = 0; k < kNumInsertedKeys; ++k) {
  2320. keys.emplace_back(RandomString(&rnd, kKeySize));
  2321. values.emplace_back(RandomString(&rnd, kKvSize - kKeySize));
  2322. ASSERT_OK(Put(Slice(keys[k]), Slice(values[k])));
  2323. dbfull()->TEST_WaitForFlushMemTable();
  2324. }
  2325. dbfull()->TEST_FlushMemTable(true);
  2326. // Make sure the number of L0 files can trigger compaction.
  2327. ASSERT_GE(NumTableFilesAtLevel(0),
  2328. options.level0_file_num_compaction_trigger);
  2329. auto previous_num_level0_files = NumTableFilesAtLevel(0);
  2330. // Fail the first file creation.
  2331. env_->non_writable_count_ = 1;
  2332. sleeping_task_low.WakeUp();
  2333. sleeping_task_low.WaitUntilDone();
  2334. // Expect compaction to fail here as one file will fail its
  2335. // creation.
  2336. ASSERT_TRUE(!dbfull()->TEST_WaitForCompact().ok());
  2337. // Verify L0 -> L1 compaction does fail.
  2338. ASSERT_EQ(NumTableFilesAtLevel(1), 0);
  2339. // Verify all L0 files are still there.
  2340. ASSERT_EQ(NumTableFilesAtLevel(0), previous_num_level0_files);
  2341. // All key-values must exist after compaction fails.
  2342. for (int k = 0; k < kNumInsertedKeys; ++k) {
  2343. ASSERT_EQ(values[k], Get(keys[k]));
  2344. }
  2345. env_->non_writable_count_ = 0;
  2346. // Make sure RocksDB will not get into corrupted state.
  2347. Reopen(options);
  2348. // Verify again after reopen.
  2349. for (int k = 0; k < kNumInsertedKeys; ++k) {
  2350. ASSERT_EQ(values[k], Get(keys[k]));
  2351. }
  2352. }
  2353. TEST_P(DBCompactionTestWithParam, DeleteMovedFileAfterCompaction) {
  2354. // iter 1 -- delete_obsolete_files_period_micros == 0
  2355. for (int iter = 0; iter < 2; ++iter) {
  2356. // This test triggers move compaction and verifies that the file is not
  2357. // deleted when it's part of move compaction
  2358. Options options = CurrentOptions();
  2359. options.env = env_;
  2360. if (iter == 1) {
  2361. options.delete_obsolete_files_period_micros = 0;
  2362. }
  2363. options.create_if_missing = true;
  2364. options.level0_file_num_compaction_trigger =
  2365. 2; // trigger compaction when we have 2 files
  2366. OnFileDeletionListener* listener = new OnFileDeletionListener();
  2367. options.listeners.emplace_back(listener);
  2368. options.max_subcompactions = max_subcompactions_;
  2369. DestroyAndReopen(options);
  2370. Random rnd(301);
  2371. // Create two 1MB sst files
  2372. for (int i = 0; i < 2; ++i) {
  2373. // Create 1MB sst file
  2374. for (int j = 0; j < 100; ++j) {
  2375. ASSERT_OK(Put(Key(i * 50 + j), RandomString(&rnd, 10 * 1024)));
  2376. }
  2377. ASSERT_OK(Flush());
  2378. }
  2379. // this should execute L0->L1
  2380. dbfull()->TEST_WaitForCompact();
  2381. ASSERT_EQ("0,1", FilesPerLevel(0));
  2382. // block compactions
  2383. test::SleepingBackgroundTask sleeping_task;
  2384. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask, &sleeping_task,
  2385. Env::Priority::LOW);
  2386. options.max_bytes_for_level_base = 1024 * 1024; // 1 MB
  2387. Reopen(options);
  2388. std::unique_ptr<Iterator> iterator(db_->NewIterator(ReadOptions()));
  2389. ASSERT_EQ("0,1", FilesPerLevel(0));
  2390. // let compactions go
  2391. sleeping_task.WakeUp();
  2392. sleeping_task.WaitUntilDone();
  2393. // this should execute L1->L2 (move)
  2394. dbfull()->TEST_WaitForCompact();
  2395. ASSERT_EQ("0,0,1", FilesPerLevel(0));
  2396. std::vector<LiveFileMetaData> metadata;
  2397. db_->GetLiveFilesMetaData(&metadata);
  2398. ASSERT_EQ(metadata.size(), 1U);
  2399. auto moved_file_name = metadata[0].name;
  2400. // Create two more 1MB sst files
  2401. for (int i = 0; i < 2; ++i) {
  2402. // Create 1MB sst file
  2403. for (int j = 0; j < 100; ++j) {
  2404. ASSERT_OK(Put(Key(i * 50 + j + 100), RandomString(&rnd, 10 * 1024)));
  2405. }
  2406. ASSERT_OK(Flush());
  2407. }
  2408. // this should execute both L0->L1 and L1->L2 (merge with previous file)
  2409. dbfull()->TEST_WaitForCompact();
  2410. ASSERT_EQ("0,0,2", FilesPerLevel(0));
  2411. // iterator is holding the file
  2412. ASSERT_OK(env_->FileExists(dbname_ + moved_file_name));
  2413. listener->SetExpectedFileName(dbname_ + moved_file_name);
  2414. iterator.reset();
  2415. // this file should have been compacted away
  2416. ASSERT_NOK(env_->FileExists(dbname_ + moved_file_name));
  2417. listener->VerifyMatchedCount(1);
  2418. }
  2419. }
  2420. TEST_P(DBCompactionTestWithParam, CompressLevelCompaction) {
  2421. if (!Zlib_Supported()) {
  2422. return;
  2423. }
  2424. Options options = CurrentOptions();
  2425. options.memtable_factory.reset(
  2426. new SpecialSkipListFactory(KNumKeysByGenerateNewFile - 1));
  2427. options.compaction_style = kCompactionStyleLevel;
  2428. options.write_buffer_size = 110 << 10; // 110KB
  2429. options.arena_block_size = 4 << 10;
  2430. options.level0_file_num_compaction_trigger = 2;
  2431. options.num_levels = 4;
  2432. options.max_bytes_for_level_base = 400 * 1024;
  2433. options.max_subcompactions = max_subcompactions_;
  2434. // First two levels have no compression, so that a trivial move between
  2435. // them will be allowed. Level 2 has Zlib compression so that a trivial
  2436. // move to level 3 will not be allowed
  2437. options.compression_per_level = {kNoCompression, kNoCompression,
  2438. kZlibCompression};
  2439. int matches = 0, didnt_match = 0, trivial_move = 0, non_trivial = 0;
  2440. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2441. "Compaction::InputCompressionMatchesOutput:Matches",
  2442. [&](void* /*arg*/) { matches++; });
  2443. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2444. "Compaction::InputCompressionMatchesOutput:DidntMatch",
  2445. [&](void* /*arg*/) { didnt_match++; });
  2446. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2447. "DBImpl::BackgroundCompaction:NonTrivial",
  2448. [&](void* /*arg*/) { non_trivial++; });
  2449. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2450. "DBImpl::BackgroundCompaction:TrivialMove",
  2451. [&](void* /*arg*/) { trivial_move++; });
  2452. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2453. Reopen(options);
  2454. Random rnd(301);
  2455. int key_idx = 0;
  2456. // First three 110KB files are going to level 0
  2457. // After that, (100K, 200K)
  2458. for (int num = 0; num < 3; num++) {
  2459. GenerateNewFile(&rnd, &key_idx);
  2460. }
  2461. // Another 110KB triggers a compaction to 400K file to fill up level 0
  2462. GenerateNewFile(&rnd, &key_idx);
  2463. ASSERT_EQ(4, GetSstFileCount(dbname_));
  2464. // (1, 4)
  2465. GenerateNewFile(&rnd, &key_idx);
  2466. ASSERT_EQ("1,4", FilesPerLevel(0));
  2467. // (1, 4, 1)
  2468. GenerateNewFile(&rnd, &key_idx);
  2469. ASSERT_EQ("1,4,1", FilesPerLevel(0));
  2470. // (1, 4, 2)
  2471. GenerateNewFile(&rnd, &key_idx);
  2472. ASSERT_EQ("1,4,2", FilesPerLevel(0));
  2473. // (1, 4, 3)
  2474. GenerateNewFile(&rnd, &key_idx);
  2475. ASSERT_EQ("1,4,3", FilesPerLevel(0));
  2476. // (1, 4, 4)
  2477. GenerateNewFile(&rnd, &key_idx);
  2478. ASSERT_EQ("1,4,4", FilesPerLevel(0));
  2479. // (1, 4, 5)
  2480. GenerateNewFile(&rnd, &key_idx);
  2481. ASSERT_EQ("1,4,5", FilesPerLevel(0));
  2482. // (1, 4, 6)
  2483. GenerateNewFile(&rnd, &key_idx);
  2484. ASSERT_EQ("1,4,6", FilesPerLevel(0));
  2485. // (1, 4, 7)
  2486. GenerateNewFile(&rnd, &key_idx);
  2487. ASSERT_EQ("1,4,7", FilesPerLevel(0));
  2488. // (1, 4, 8)
  2489. GenerateNewFile(&rnd, &key_idx);
  2490. ASSERT_EQ("1,4,8", FilesPerLevel(0));
  2491. ASSERT_EQ(matches, 12);
  2492. // Currently, the test relies on the number of calls to
  2493. // InputCompressionMatchesOutput() per compaction.
  2494. const int kCallsToInputCompressionMatch = 2;
  2495. ASSERT_EQ(didnt_match, 8 * kCallsToInputCompressionMatch);
  2496. ASSERT_EQ(trivial_move, 12);
  2497. ASSERT_EQ(non_trivial, 8);
  2498. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2499. for (int i = 0; i < key_idx; i++) {
  2500. auto v = Get(Key(i));
  2501. ASSERT_NE(v, "NOT_FOUND");
  2502. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  2503. }
  2504. Reopen(options);
  2505. for (int i = 0; i < key_idx; i++) {
  2506. auto v = Get(Key(i));
  2507. ASSERT_NE(v, "NOT_FOUND");
  2508. ASSERT_TRUE(v.size() == 1 || v.size() == 990);
  2509. }
  2510. Destroy(options);
  2511. }
  2512. TEST_F(DBCompactionTest, SanitizeCompactionOptionsTest) {
  2513. Options options = CurrentOptions();
  2514. options.max_background_compactions = 5;
  2515. options.soft_pending_compaction_bytes_limit = 0;
  2516. options.hard_pending_compaction_bytes_limit = 100;
  2517. options.create_if_missing = true;
  2518. DestroyAndReopen(options);
  2519. ASSERT_EQ(100, db_->GetOptions().soft_pending_compaction_bytes_limit);
  2520. options.max_background_compactions = 3;
  2521. options.soft_pending_compaction_bytes_limit = 200;
  2522. options.hard_pending_compaction_bytes_limit = 150;
  2523. DestroyAndReopen(options);
  2524. ASSERT_EQ(150, db_->GetOptions().soft_pending_compaction_bytes_limit);
  2525. }
  2526. // This tests for a bug that could cause two level0 compactions running
  2527. // concurrently
  2528. // TODO(aekmekji): Make sure that the reason this fails when run with
  2529. // max_subcompactions > 1 is not a correctness issue but just inherent to
  2530. // running parallel L0-L1 compactions
  2531. TEST_F(DBCompactionTest, SuggestCompactRangeNoTwoLevel0Compactions) {
  2532. Options options = CurrentOptions();
  2533. options.compaction_style = kCompactionStyleLevel;
  2534. options.write_buffer_size = 110 << 10;
  2535. options.arena_block_size = 4 << 10;
  2536. options.level0_file_num_compaction_trigger = 4;
  2537. options.num_levels = 4;
  2538. options.compression = kNoCompression;
  2539. options.max_bytes_for_level_base = 450 << 10;
  2540. options.target_file_size_base = 98 << 10;
  2541. options.max_write_buffer_number = 2;
  2542. options.max_background_compactions = 2;
  2543. DestroyAndReopen(options);
  2544. // fill up the DB
  2545. Random rnd(301);
  2546. for (int num = 0; num < 10; num++) {
  2547. GenerateNewRandomFile(&rnd);
  2548. }
  2549. db_->CompactRange(CompactRangeOptions(), nullptr, nullptr);
  2550. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  2551. {{"CompactionJob::Run():Start",
  2552. "DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:1"},
  2553. {"DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:2",
  2554. "CompactionJob::Run():End"}});
  2555. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2556. // trigger L0 compaction
  2557. for (int num = 0; num < options.level0_file_num_compaction_trigger + 1;
  2558. num++) {
  2559. GenerateNewRandomFile(&rnd, /* nowait */ true);
  2560. ASSERT_OK(Flush());
  2561. }
  2562. TEST_SYNC_POINT(
  2563. "DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:1");
  2564. GenerateNewRandomFile(&rnd, /* nowait */ true);
  2565. dbfull()->TEST_WaitForFlushMemTable();
  2566. ASSERT_OK(experimental::SuggestCompactRange(db_, nullptr, nullptr));
  2567. for (int num = 0; num < options.level0_file_num_compaction_trigger + 1;
  2568. num++) {
  2569. GenerateNewRandomFile(&rnd, /* nowait */ true);
  2570. ASSERT_OK(Flush());
  2571. }
  2572. TEST_SYNC_POINT(
  2573. "DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:2");
  2574. dbfull()->TEST_WaitForCompact();
  2575. }
  2576. static std::string ShortKey(int i) {
  2577. assert(i < 10000);
  2578. char buf[100];
  2579. snprintf(buf, sizeof(buf), "key%04d", i);
  2580. return std::string(buf);
  2581. }
  2582. TEST_P(DBCompactionTestWithParam, ForceBottommostLevelCompaction) {
  2583. int32_t trivial_move = 0;
  2584. int32_t non_trivial_move = 0;
  2585. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2586. "DBImpl::BackgroundCompaction:TrivialMove",
  2587. [&](void* /*arg*/) { trivial_move++; });
  2588. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2589. "DBImpl::BackgroundCompaction:NonTrivial",
  2590. [&](void* /*arg*/) { non_trivial_move++; });
  2591. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2592. // The key size is guaranteed to be <= 8
  2593. class ShortKeyComparator : public Comparator {
  2594. int Compare(const ROCKSDB_NAMESPACE::Slice& a,
  2595. const ROCKSDB_NAMESPACE::Slice& b) const override {
  2596. assert(a.size() <= 8);
  2597. assert(b.size() <= 8);
  2598. return BytewiseComparator()->Compare(a, b);
  2599. }
  2600. const char* Name() const override { return "ShortKeyComparator"; }
  2601. void FindShortestSeparator(
  2602. std::string* start,
  2603. const ROCKSDB_NAMESPACE::Slice& limit) const override {
  2604. return BytewiseComparator()->FindShortestSeparator(start, limit);
  2605. }
  2606. void FindShortSuccessor(std::string* key) const override {
  2607. return BytewiseComparator()->FindShortSuccessor(key);
  2608. }
  2609. } short_key_cmp;
  2610. Options options = CurrentOptions();
  2611. options.target_file_size_base = 100000000;
  2612. options.write_buffer_size = 100000000;
  2613. options.max_subcompactions = max_subcompactions_;
  2614. options.comparator = &short_key_cmp;
  2615. DestroyAndReopen(options);
  2616. int32_t value_size = 10 * 1024; // 10 KB
  2617. Random rnd(301);
  2618. std::vector<std::string> values;
  2619. // File with keys [ 0 => 99 ]
  2620. for (int i = 0; i < 100; i++) {
  2621. values.push_back(RandomString(&rnd, value_size));
  2622. ASSERT_OK(Put(ShortKey(i), values[i]));
  2623. }
  2624. ASSERT_OK(Flush());
  2625. ASSERT_EQ("1", FilesPerLevel(0));
  2626. // Compaction will do L0=>L1 (trivial move) then move L1 files to L3
  2627. CompactRangeOptions compact_options;
  2628. compact_options.change_level = true;
  2629. compact_options.target_level = 3;
  2630. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  2631. ASSERT_EQ("0,0,0,1", FilesPerLevel(0));
  2632. ASSERT_EQ(trivial_move, 1);
  2633. ASSERT_EQ(non_trivial_move, 0);
  2634. // File with keys [ 100 => 199 ]
  2635. for (int i = 100; i < 200; i++) {
  2636. values.push_back(RandomString(&rnd, value_size));
  2637. ASSERT_OK(Put(ShortKey(i), values[i]));
  2638. }
  2639. ASSERT_OK(Flush());
  2640. ASSERT_EQ("1,0,0,1", FilesPerLevel(0));
  2641. // Compaction will do L0=>L1 L1=>L2 L2=>L3 (3 trivial moves)
  2642. // then compacte the bottommost level L3=>L3 (non trivial move)
  2643. compact_options = CompactRangeOptions();
  2644. compact_options.bottommost_level_compaction =
  2645. BottommostLevelCompaction::kForceOptimized;
  2646. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  2647. ASSERT_EQ("0,0,0,1", FilesPerLevel(0));
  2648. ASSERT_EQ(trivial_move, 4);
  2649. ASSERT_EQ(non_trivial_move, 1);
  2650. // File with keys [ 200 => 299 ]
  2651. for (int i = 200; i < 300; i++) {
  2652. values.push_back(RandomString(&rnd, value_size));
  2653. ASSERT_OK(Put(ShortKey(i), values[i]));
  2654. }
  2655. ASSERT_OK(Flush());
  2656. ASSERT_EQ("1,0,0,1", FilesPerLevel(0));
  2657. trivial_move = 0;
  2658. non_trivial_move = 0;
  2659. compact_options = CompactRangeOptions();
  2660. compact_options.bottommost_level_compaction =
  2661. BottommostLevelCompaction::kSkip;
  2662. // Compaction will do L0=>L1 L1=>L2 L2=>L3 (3 trivial moves)
  2663. // and will skip bottommost level compaction
  2664. ASSERT_OK(db_->CompactRange(compact_options, nullptr, nullptr));
  2665. ASSERT_EQ("0,0,0,2", FilesPerLevel(0));
  2666. ASSERT_EQ(trivial_move, 3);
  2667. ASSERT_EQ(non_trivial_move, 0);
  2668. for (int i = 0; i < 300; i++) {
  2669. ASSERT_EQ(Get(ShortKey(i)), values[i]);
  2670. }
  2671. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2672. }
  2673. TEST_P(DBCompactionTestWithParam, IntraL0Compaction) {
  2674. Options options = CurrentOptions();
  2675. options.compression = kNoCompression;
  2676. options.level0_file_num_compaction_trigger = 5;
  2677. options.max_background_compactions = 2;
  2678. options.max_subcompactions = max_subcompactions_;
  2679. DestroyAndReopen(options);
  2680. const size_t kValueSize = 1 << 20;
  2681. Random rnd(301);
  2682. std::string value(RandomString(&rnd, kValueSize));
  2683. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  2684. {{"LevelCompactionPicker::PickCompactionBySize:0",
  2685. "CompactionJob::Run():Start"}});
  2686. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2687. // index: 0 1 2 3 4 5 6 7 8 9
  2688. // size: 1MB 1MB 1MB 1MB 1MB 2MB 1MB 1MB 1MB 1MB
  2689. // score: 1.5 1.3 1.5 2.0 inf
  2690. //
  2691. // Files 0-4 will be included in an L0->L1 compaction.
  2692. //
  2693. // L0->L0 will be triggered since the sync points guarantee compaction to base
  2694. // level is still blocked when files 5-9 trigger another compaction.
  2695. //
  2696. // Files 6-9 are the longest span of available files for which
  2697. // work-per-deleted-file decreases (see "score" row above).
  2698. for (int i = 0; i < 10; ++i) {
  2699. ASSERT_OK(Put(Key(0), "")); // prevents trivial move
  2700. if (i == 5) {
  2701. ASSERT_OK(Put(Key(i + 1), value + value));
  2702. } else {
  2703. ASSERT_OK(Put(Key(i + 1), value));
  2704. }
  2705. ASSERT_OK(Flush());
  2706. }
  2707. dbfull()->TEST_WaitForCompact();
  2708. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2709. std::vector<std::vector<FileMetaData>> level_to_files;
  2710. dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(),
  2711. &level_to_files);
  2712. ASSERT_GE(level_to_files.size(), 2); // at least L0 and L1
  2713. // L0 has the 2MB file (not compacted) and 4MB file (output of L0->L0)
  2714. ASSERT_EQ(2, level_to_files[0].size());
  2715. ASSERT_GT(level_to_files[1].size(), 0);
  2716. for (int i = 0; i < 2; ++i) {
  2717. ASSERT_GE(level_to_files[0][i].fd.file_size, 1 << 21);
  2718. }
  2719. }
  2720. TEST_P(DBCompactionTestWithParam, IntraL0CompactionDoesNotObsoleteDeletions) {
  2721. // regression test for issue #2722: L0->L0 compaction can resurrect deleted
  2722. // keys from older L0 files if L1+ files' key-ranges do not include the key.
  2723. Options options = CurrentOptions();
  2724. options.compression = kNoCompression;
  2725. options.level0_file_num_compaction_trigger = 5;
  2726. options.max_background_compactions = 2;
  2727. options.max_subcompactions = max_subcompactions_;
  2728. DestroyAndReopen(options);
  2729. const size_t kValueSize = 1 << 20;
  2730. Random rnd(301);
  2731. std::string value(RandomString(&rnd, kValueSize));
  2732. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  2733. {{"LevelCompactionPicker::PickCompactionBySize:0",
  2734. "CompactionJob::Run():Start"}});
  2735. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2736. // index: 0 1 2 3 4 5 6 7 8 9
  2737. // size: 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB
  2738. // score: 1.25 1.33 1.5 2.0 inf
  2739. //
  2740. // Files 0-4 will be included in an L0->L1 compaction.
  2741. //
  2742. // L0->L0 will be triggered since the sync points guarantee compaction to base
  2743. // level is still blocked when files 5-9 trigger another compaction. All files
  2744. // 5-9 are included in the L0->L0 due to work-per-deleted file decreasing.
  2745. //
  2746. // Put a key-value in files 0-4. Delete that key in files 5-9. Verify the
  2747. // L0->L0 preserves the deletion such that the key remains deleted.
  2748. for (int i = 0; i < 10; ++i) {
  2749. // key 0 serves both to prevent trivial move and as the key we want to
  2750. // verify is not resurrected by L0->L0 compaction.
  2751. if (i < 5) {
  2752. ASSERT_OK(Put(Key(0), ""));
  2753. } else {
  2754. ASSERT_OK(Delete(Key(0)));
  2755. }
  2756. ASSERT_OK(Put(Key(i + 1), value));
  2757. ASSERT_OK(Flush());
  2758. }
  2759. dbfull()->TEST_WaitForCompact();
  2760. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2761. std::vector<std::vector<FileMetaData>> level_to_files;
  2762. dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(),
  2763. &level_to_files);
  2764. ASSERT_GE(level_to_files.size(), 2); // at least L0 and L1
  2765. // L0 has a single output file from L0->L0
  2766. ASSERT_EQ(1, level_to_files[0].size());
  2767. ASSERT_GT(level_to_files[1].size(), 0);
  2768. ASSERT_GE(level_to_files[0][0].fd.file_size, 1 << 22);
  2769. ReadOptions roptions;
  2770. std::string result;
  2771. ASSERT_TRUE(db_->Get(roptions, Key(0), &result).IsNotFound());
  2772. }
  2773. TEST_P(DBCompactionTestWithParam, FullCompactionInBottomPriThreadPool) {
  2774. const int kNumFilesTrigger = 3;
  2775. Env::Default()->SetBackgroundThreads(1, Env::Priority::BOTTOM);
  2776. for (bool use_universal_compaction : {false, true}) {
  2777. Options options = CurrentOptions();
  2778. if (use_universal_compaction) {
  2779. options.compaction_style = kCompactionStyleUniversal;
  2780. } else {
  2781. options.compaction_style = kCompactionStyleLevel;
  2782. options.level_compaction_dynamic_level_bytes = true;
  2783. }
  2784. options.num_levels = 4;
  2785. options.write_buffer_size = 100 << 10; // 100KB
  2786. options.target_file_size_base = 32 << 10; // 32KB
  2787. options.level0_file_num_compaction_trigger = kNumFilesTrigger;
  2788. // Trigger compaction if size amplification exceeds 110%
  2789. options.compaction_options_universal.max_size_amplification_percent = 110;
  2790. DestroyAndReopen(options);
  2791. int num_bottom_pri_compactions = 0;
  2792. SyncPoint::GetInstance()->SetCallBack(
  2793. "DBImpl::BGWorkBottomCompaction",
  2794. [&](void* /*arg*/) { ++num_bottom_pri_compactions; });
  2795. SyncPoint::GetInstance()->EnableProcessing();
  2796. Random rnd(301);
  2797. for (int num = 0; num < kNumFilesTrigger; num++) {
  2798. ASSERT_EQ(NumSortedRuns(), num);
  2799. int key_idx = 0;
  2800. GenerateNewFile(&rnd, &key_idx);
  2801. }
  2802. dbfull()->TEST_WaitForCompact();
  2803. ASSERT_EQ(1, num_bottom_pri_compactions);
  2804. // Verify that size amplification did occur
  2805. ASSERT_EQ(NumSortedRuns(), 1);
  2806. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2807. }
  2808. Env::Default()->SetBackgroundThreads(0, Env::Priority::BOTTOM);
  2809. }
  2810. TEST_F(DBCompactionTest, OptimizedDeletionObsoleting) {
  2811. // Deletions can be dropped when compacted to non-last level if they fall
  2812. // outside the lower-level files' key-ranges.
  2813. const int kNumL0Files = 4;
  2814. Options options = CurrentOptions();
  2815. options.level0_file_num_compaction_trigger = kNumL0Files;
  2816. options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics();
  2817. DestroyAndReopen(options);
  2818. // put key 1 and 3 in separate L1, L2 files.
  2819. // So key 0, 2, and 4+ fall outside these levels' key-ranges.
  2820. for (int level = 2; level >= 1; --level) {
  2821. for (int i = 0; i < 2; ++i) {
  2822. Put(Key(2 * i + 1), "val");
  2823. Flush();
  2824. }
  2825. MoveFilesToLevel(level);
  2826. ASSERT_EQ(2, NumTableFilesAtLevel(level));
  2827. }
  2828. // Delete keys in range [1, 4]. These L0 files will be compacted with L1:
  2829. // - Tombstones for keys 2 and 4 can be dropped early.
  2830. // - Tombstones for keys 1 and 3 must be kept due to L2 files' key-ranges.
  2831. for (int i = 0; i < kNumL0Files; ++i) {
  2832. Put(Key(0), "val"); // sentinel to prevent trivial move
  2833. Delete(Key(i + 1));
  2834. Flush();
  2835. }
  2836. dbfull()->TEST_WaitForCompact();
  2837. for (int i = 0; i < kNumL0Files; ++i) {
  2838. std::string value;
  2839. ASSERT_TRUE(db_->Get(ReadOptions(), Key(i + 1), &value).IsNotFound());
  2840. }
  2841. ASSERT_EQ(2, options.statistics->getTickerCount(
  2842. COMPACTION_OPTIMIZED_DEL_DROP_OBSOLETE));
  2843. ASSERT_EQ(2,
  2844. options.statistics->getTickerCount(COMPACTION_KEY_DROP_OBSOLETE));
  2845. }
  2846. TEST_F(DBCompactionTest, CompactFilesPendingL0Bug) {
  2847. // https://www.facebook.com/groups/rocksdb.dev/permalink/1389452781153232/
  2848. // CompactFiles() had a bug where it failed to pick a compaction when an L0
  2849. // compaction existed, but marked it as scheduled anyways. It'd never be
  2850. // unmarked as scheduled, so future compactions or DB close could hang.
  2851. const int kNumL0Files = 5;
  2852. Options options = CurrentOptions();
  2853. options.level0_file_num_compaction_trigger = kNumL0Files - 1;
  2854. options.max_background_compactions = 2;
  2855. DestroyAndReopen(options);
  2856. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  2857. {{"LevelCompactionPicker::PickCompaction:Return",
  2858. "DBCompactionTest::CompactFilesPendingL0Bug:Picked"},
  2859. {"DBCompactionTest::CompactFilesPendingL0Bug:ManualCompacted",
  2860. "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}});
  2861. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2862. auto schedule_multi_compaction_token =
  2863. dbfull()->TEST_write_controler().GetCompactionPressureToken();
  2864. // Files 0-3 will be included in an L0->L1 compaction.
  2865. //
  2866. // File 4 will be included in a call to CompactFiles() while the first
  2867. // compaction is running.
  2868. for (int i = 0; i < kNumL0Files - 1; ++i) {
  2869. ASSERT_OK(Put(Key(0), "val")); // sentinel to prevent trivial move
  2870. ASSERT_OK(Put(Key(i + 1), "val"));
  2871. ASSERT_OK(Flush());
  2872. }
  2873. TEST_SYNC_POINT("DBCompactionTest::CompactFilesPendingL0Bug:Picked");
  2874. // file 4 flushed after 0-3 picked
  2875. ASSERT_OK(Put(Key(kNumL0Files), "val"));
  2876. ASSERT_OK(Flush());
  2877. // previously DB close would hang forever as this situation caused scheduled
  2878. // compactions count to never decrement to zero.
  2879. ColumnFamilyMetaData cf_meta;
  2880. dbfull()->GetColumnFamilyMetaData(dbfull()->DefaultColumnFamily(), &cf_meta);
  2881. ASSERT_EQ(kNumL0Files, cf_meta.levels[0].files.size());
  2882. std::vector<std::string> input_filenames;
  2883. input_filenames.push_back(cf_meta.levels[0].files.front().name);
  2884. ASSERT_OK(dbfull()
  2885. ->CompactFiles(CompactionOptions(), input_filenames,
  2886. 0 /* output_level */));
  2887. TEST_SYNC_POINT("DBCompactionTest::CompactFilesPendingL0Bug:ManualCompacted");
  2888. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2889. }
  2890. TEST_F(DBCompactionTest, CompactFilesOverlapInL0Bug) {
  2891. // Regression test for bug of not pulling in L0 files that overlap the user-
  2892. // specified input files in time- and key-ranges.
  2893. Put(Key(0), "old_val");
  2894. Flush();
  2895. Put(Key(0), "new_val");
  2896. Flush();
  2897. ColumnFamilyMetaData cf_meta;
  2898. dbfull()->GetColumnFamilyMetaData(dbfull()->DefaultColumnFamily(), &cf_meta);
  2899. ASSERT_GE(cf_meta.levels.size(), 2);
  2900. ASSERT_EQ(2, cf_meta.levels[0].files.size());
  2901. // Compacting {new L0 file, L1 file} should pull in the old L0 file since it
  2902. // overlaps in key-range and time-range.
  2903. std::vector<std::string> input_filenames;
  2904. input_filenames.push_back(cf_meta.levels[0].files.front().name);
  2905. ASSERT_OK(dbfull()->CompactFiles(CompactionOptions(), input_filenames,
  2906. 1 /* output_level */));
  2907. ASSERT_EQ("new_val", Get(Key(0)));
  2908. }
  2909. TEST_F(DBCompactionTest, CompactBottomLevelFilesWithDeletions) {
  2910. // bottom-level files may contain deletions due to snapshots protecting the
  2911. // deleted keys. Once the snapshot is released, we should see files with many
  2912. // such deletions undergo single-file compactions.
  2913. const int kNumKeysPerFile = 1024;
  2914. const int kNumLevelFiles = 4;
  2915. const int kValueSize = 128;
  2916. Options options = CurrentOptions();
  2917. options.compression = kNoCompression;
  2918. options.level0_file_num_compaction_trigger = kNumLevelFiles;
  2919. // inflate it a bit to account for key/metadata overhead
  2920. options.target_file_size_base = 120 * kNumKeysPerFile * kValueSize / 100;
  2921. CreateAndReopenWithCF({"one"}, options);
  2922. Random rnd(301);
  2923. const Snapshot* snapshot = nullptr;
  2924. for (int i = 0; i < kNumLevelFiles; ++i) {
  2925. for (int j = 0; j < kNumKeysPerFile; ++j) {
  2926. ASSERT_OK(
  2927. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  2928. }
  2929. if (i == kNumLevelFiles - 1) {
  2930. snapshot = db_->GetSnapshot();
  2931. // delete every other key after grabbing a snapshot, so these deletions
  2932. // and the keys they cover can't be dropped until after the snapshot is
  2933. // released.
  2934. for (int j = 0; j < kNumLevelFiles * kNumKeysPerFile; j += 2) {
  2935. ASSERT_OK(Delete(Key(j)));
  2936. }
  2937. }
  2938. Flush();
  2939. if (i < kNumLevelFiles - 1) {
  2940. ASSERT_EQ(i + 1, NumTableFilesAtLevel(0));
  2941. }
  2942. }
  2943. dbfull()->TEST_WaitForCompact();
  2944. ASSERT_EQ(kNumLevelFiles, NumTableFilesAtLevel(1));
  2945. std::vector<LiveFileMetaData> pre_release_metadata, post_release_metadata;
  2946. db_->GetLiveFilesMetaData(&pre_release_metadata);
  2947. // just need to bump seqnum so ReleaseSnapshot knows the newest key in the SST
  2948. // files does not need to be preserved in case of a future snapshot.
  2949. ASSERT_OK(Put(Key(0), "val"));
  2950. ASSERT_NE(kMaxSequenceNumber, dbfull()->bottommost_files_mark_threshold_);
  2951. // release snapshot and wait for compactions to finish. Single-file
  2952. // compactions should be triggered, which reduce the size of each bottom-level
  2953. // file without changing file count.
  2954. db_->ReleaseSnapshot(snapshot);
  2955. ASSERT_EQ(kMaxSequenceNumber, dbfull()->bottommost_files_mark_threshold_);
  2956. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  2957. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  2958. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  2959. ASSERT_TRUE(compaction->compaction_reason() ==
  2960. CompactionReason::kBottommostFiles);
  2961. });
  2962. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  2963. dbfull()->TEST_WaitForCompact();
  2964. db_->GetLiveFilesMetaData(&post_release_metadata);
  2965. ASSERT_EQ(pre_release_metadata.size(), post_release_metadata.size());
  2966. for (size_t i = 0; i < pre_release_metadata.size(); ++i) {
  2967. const auto& pre_file = pre_release_metadata[i];
  2968. const auto& post_file = post_release_metadata[i];
  2969. ASSERT_EQ(1, pre_file.level);
  2970. ASSERT_EQ(1, post_file.level);
  2971. // each file is smaller than it was before as it was rewritten without
  2972. // deletion markers/deleted keys.
  2973. ASSERT_LT(post_file.size, pre_file.size);
  2974. }
  2975. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  2976. }
  2977. TEST_F(DBCompactionTest, LevelCompactExpiredTtlFiles) {
  2978. const int kNumKeysPerFile = 32;
  2979. const int kNumLevelFiles = 2;
  2980. const int kValueSize = 1024;
  2981. Options options = CurrentOptions();
  2982. options.compression = kNoCompression;
  2983. options.ttl = 24 * 60 * 60; // 24 hours
  2984. options.max_open_files = -1;
  2985. env_->time_elapse_only_sleep_ = false;
  2986. options.env = env_;
  2987. env_->addon_time_.store(0);
  2988. DestroyAndReopen(options);
  2989. Random rnd(301);
  2990. for (int i = 0; i < kNumLevelFiles; ++i) {
  2991. for (int j = 0; j < kNumKeysPerFile; ++j) {
  2992. ASSERT_OK(
  2993. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  2994. }
  2995. Flush();
  2996. }
  2997. dbfull()->TEST_WaitForCompact();
  2998. MoveFilesToLevel(3);
  2999. ASSERT_EQ("0,0,0,2", FilesPerLevel());
  3000. // Delete previously written keys.
  3001. for (int i = 0; i < kNumLevelFiles; ++i) {
  3002. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3003. ASSERT_OK(Delete(Key(i * kNumKeysPerFile + j)));
  3004. }
  3005. Flush();
  3006. }
  3007. dbfull()->TEST_WaitForCompact();
  3008. ASSERT_EQ("2,0,0,2", FilesPerLevel());
  3009. MoveFilesToLevel(1);
  3010. ASSERT_EQ("0,2,0,2", FilesPerLevel());
  3011. env_->addon_time_.fetch_add(36 * 60 * 60); // 36 hours
  3012. ASSERT_EQ("0,2,0,2", FilesPerLevel());
  3013. // Just do a simple write + flush so that the Ttl expired files get
  3014. // compacted.
  3015. ASSERT_OK(Put("a", "1"));
  3016. Flush();
  3017. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3018. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3019. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3020. ASSERT_TRUE(compaction->compaction_reason() == CompactionReason::kTtl);
  3021. });
  3022. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3023. dbfull()->TEST_WaitForCompact();
  3024. // All non-L0 files are deleted, as they contained only deleted data.
  3025. ASSERT_EQ("1", FilesPerLevel());
  3026. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3027. // Test dynamically changing ttl.
  3028. env_->addon_time_.store(0);
  3029. DestroyAndReopen(options);
  3030. for (int i = 0; i < kNumLevelFiles; ++i) {
  3031. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3032. ASSERT_OK(
  3033. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  3034. }
  3035. Flush();
  3036. }
  3037. dbfull()->TEST_WaitForCompact();
  3038. MoveFilesToLevel(3);
  3039. ASSERT_EQ("0,0,0,2", FilesPerLevel());
  3040. // Delete previously written keys.
  3041. for (int i = 0; i < kNumLevelFiles; ++i) {
  3042. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3043. ASSERT_OK(Delete(Key(i * kNumKeysPerFile + j)));
  3044. }
  3045. Flush();
  3046. }
  3047. dbfull()->TEST_WaitForCompact();
  3048. ASSERT_EQ("2,0,0,2", FilesPerLevel());
  3049. MoveFilesToLevel(1);
  3050. ASSERT_EQ("0,2,0,2", FilesPerLevel());
  3051. // Move time forward by 12 hours, and make sure that compaction still doesn't
  3052. // trigger as ttl is set to 24 hours.
  3053. env_->addon_time_.fetch_add(12 * 60 * 60);
  3054. ASSERT_OK(Put("a", "1"));
  3055. Flush();
  3056. dbfull()->TEST_WaitForCompact();
  3057. ASSERT_EQ("1,2,0,2", FilesPerLevel());
  3058. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3059. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3060. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3061. ASSERT_TRUE(compaction->compaction_reason() == CompactionReason::kTtl);
  3062. });
  3063. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3064. // Dynamically change ttl to 10 hours.
  3065. // This should trigger a ttl compaction, as 12 hours have already passed.
  3066. ASSERT_OK(dbfull()->SetOptions({{"ttl", "36000"}}));
  3067. dbfull()->TEST_WaitForCompact();
  3068. // All non-L0 files are deleted, as they contained only deleted data.
  3069. ASSERT_EQ("1", FilesPerLevel());
  3070. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3071. }
  3072. TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) {
  3073. const int kValueSize = 100;
  3074. for (bool if_restart : {false, true}) {
  3075. for (bool if_open_all_files : {false, true}) {
  3076. Options options = CurrentOptions();
  3077. options.compression = kNoCompression;
  3078. options.ttl = 24 * 60 * 60; // 24 hours
  3079. if (if_open_all_files) {
  3080. options.max_open_files = -1;
  3081. } else {
  3082. options.max_open_files = 20;
  3083. }
  3084. // RocksDB sanitize max open files to at least 20. Modify it back.
  3085. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3086. "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) {
  3087. int* max_open_files = static_cast<int*>(arg);
  3088. *max_open_files = 2;
  3089. });
  3090. // In the case where all files are opened and doing DB restart
  3091. // forcing the oldest ancester time in manifest file to be 0 to
  3092. // simulate the case of reading from an old version.
  3093. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3094. "VersionEdit::EncodeTo:VarintOldestAncesterTime", [&](void* arg) {
  3095. if (if_restart && if_open_all_files) {
  3096. std::string* encoded_fieled = static_cast<std::string*>(arg);
  3097. *encoded_fieled = "";
  3098. PutVarint64(encoded_fieled, 0);
  3099. }
  3100. });
  3101. env_->time_elapse_only_sleep_ = false;
  3102. options.env = env_;
  3103. env_->addon_time_.store(0);
  3104. DestroyAndReopen(options);
  3105. int ttl_compactions = 0;
  3106. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3107. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3108. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3109. auto compaction_reason = compaction->compaction_reason();
  3110. if (compaction_reason == CompactionReason::kTtl) {
  3111. ttl_compactions++;
  3112. }
  3113. });
  3114. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3115. // Add two L6 files with key ranges: [1 .. 100], [101 .. 200].
  3116. Random rnd(301);
  3117. for (int i = 1; i <= 100; ++i) {
  3118. ASSERT_OK(Put(Key(i), RandomString(&rnd, kValueSize)));
  3119. }
  3120. Flush();
  3121. // Get the first file's creation time. This will be the oldest file in the
  3122. // DB. Compactions inolving this file's descendents should keep getting
  3123. // this time.
  3124. std::vector<std::vector<FileMetaData>> level_to_files;
  3125. dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(),
  3126. &level_to_files);
  3127. uint64_t oldest_time = level_to_files[0][0].oldest_ancester_time;
  3128. // Add 1 hour and do another flush.
  3129. env_->addon_time_.fetch_add(1 * 60 * 60);
  3130. for (int i = 101; i <= 200; ++i) {
  3131. ASSERT_OK(Put(Key(i), RandomString(&rnd, kValueSize)));
  3132. }
  3133. Flush();
  3134. MoveFilesToLevel(6);
  3135. ASSERT_EQ("0,0,0,0,0,0,2", FilesPerLevel());
  3136. env_->addon_time_.fetch_add(1 * 60 * 60);
  3137. // Add two L4 files with key ranges: [1 .. 50], [51 .. 150].
  3138. for (int i = 1; i <= 50; ++i) {
  3139. ASSERT_OK(Put(Key(i), RandomString(&rnd, kValueSize)));
  3140. }
  3141. Flush();
  3142. env_->addon_time_.fetch_add(1 * 60 * 60);
  3143. for (int i = 51; i <= 150; ++i) {
  3144. ASSERT_OK(Put(Key(i), RandomString(&rnd, kValueSize)));
  3145. }
  3146. Flush();
  3147. MoveFilesToLevel(4);
  3148. ASSERT_EQ("0,0,0,0,2,0,2", FilesPerLevel());
  3149. env_->addon_time_.fetch_add(1 * 60 * 60);
  3150. // Add one L1 file with key range: [26, 75].
  3151. for (int i = 26; i <= 75; ++i) {
  3152. ASSERT_OK(Put(Key(i), RandomString(&rnd, kValueSize)));
  3153. }
  3154. Flush();
  3155. dbfull()->TEST_WaitForCompact();
  3156. MoveFilesToLevel(1);
  3157. ASSERT_EQ("0,1,0,0,2,0,2", FilesPerLevel());
  3158. // LSM tree:
  3159. // L1: [26 .. 75]
  3160. // L4: [1 .. 50][51 ..... 150]
  3161. // L6: [1 ........ 100][101 .... 200]
  3162. //
  3163. // On TTL expiry, TTL compaction should be initiated on L1 file, and the
  3164. // compactions should keep going on until the key range hits bottom level.
  3165. // In other words: the compaction on this data range "cascasdes" until
  3166. // reaching the bottom level.
  3167. //
  3168. // Order of events on TTL expiry:
  3169. // 1. L1 file falls to L3 via 2 trivial moves which are initiated by the
  3170. // ttl
  3171. // compaction.
  3172. // 2. A TTL compaction happens between L3 and L4 files. Output file in L4.
  3173. // 3. The new output file from L4 falls to L5 via 1 trival move initiated
  3174. // by the ttl compaction.
  3175. // 4. A TTL compaction happens between L5 and L6 files. Ouptut in L6.
  3176. // Add 25 hours and do a write
  3177. env_->addon_time_.fetch_add(25 * 60 * 60);
  3178. ASSERT_OK(Put(Key(1), "1"));
  3179. if (if_restart) {
  3180. Reopen(options);
  3181. } else {
  3182. Flush();
  3183. }
  3184. dbfull()->TEST_WaitForCompact();
  3185. ASSERT_EQ("1,0,0,0,0,0,1", FilesPerLevel());
  3186. ASSERT_EQ(5, ttl_compactions);
  3187. dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(),
  3188. &level_to_files);
  3189. ASSERT_EQ(oldest_time, level_to_files[6][0].oldest_ancester_time);
  3190. env_->addon_time_.fetch_add(25 * 60 * 60);
  3191. ASSERT_OK(Put(Key(2), "1"));
  3192. if (if_restart) {
  3193. Reopen(options);
  3194. } else {
  3195. Flush();
  3196. }
  3197. dbfull()->TEST_WaitForCompact();
  3198. ASSERT_EQ("1,0,0,0,0,0,1", FilesPerLevel());
  3199. ASSERT_GE(ttl_compactions, 6);
  3200. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3201. }
  3202. }
  3203. }
  3204. TEST_F(DBCompactionTest, LevelPeriodicCompaction) {
  3205. const int kNumKeysPerFile = 32;
  3206. const int kNumLevelFiles = 2;
  3207. const int kValueSize = 100;
  3208. for (bool if_restart : {false, true}) {
  3209. for (bool if_open_all_files : {false, true}) {
  3210. Options options = CurrentOptions();
  3211. options.periodic_compaction_seconds = 48 * 60 * 60; // 2 days
  3212. if (if_open_all_files) {
  3213. options.max_open_files = -1; // needed for ttl compaction
  3214. } else {
  3215. options.max_open_files = 20;
  3216. }
  3217. // RocksDB sanitize max open files to at least 20. Modify it back.
  3218. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3219. "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) {
  3220. int* max_open_files = static_cast<int*>(arg);
  3221. *max_open_files = 0;
  3222. });
  3223. // In the case where all files are opened and doing DB restart
  3224. // forcing the file creation time in manifest file to be 0 to
  3225. // simulate the case of reading from an old version.
  3226. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3227. "VersionEdit::EncodeTo:VarintFileCreationTime", [&](void* arg) {
  3228. if (if_restart && if_open_all_files) {
  3229. std::string* encoded_fieled = static_cast<std::string*>(arg);
  3230. *encoded_fieled = "";
  3231. PutVarint64(encoded_fieled, 0);
  3232. }
  3233. });
  3234. env_->time_elapse_only_sleep_ = false;
  3235. options.env = env_;
  3236. env_->addon_time_.store(0);
  3237. DestroyAndReopen(options);
  3238. int periodic_compactions = 0;
  3239. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3240. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3241. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3242. auto compaction_reason = compaction->compaction_reason();
  3243. if (compaction_reason == CompactionReason::kPeriodicCompaction) {
  3244. periodic_compactions++;
  3245. }
  3246. });
  3247. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3248. Random rnd(301);
  3249. for (int i = 0; i < kNumLevelFiles; ++i) {
  3250. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3251. ASSERT_OK(Put(Key(i * kNumKeysPerFile + j),
  3252. RandomString(&rnd, kValueSize)));
  3253. }
  3254. Flush();
  3255. }
  3256. dbfull()->TEST_WaitForCompact();
  3257. ASSERT_EQ("2", FilesPerLevel());
  3258. ASSERT_EQ(0, periodic_compactions);
  3259. // Add 50 hours and do a write
  3260. env_->addon_time_.fetch_add(50 * 60 * 60);
  3261. ASSERT_OK(Put("a", "1"));
  3262. Flush();
  3263. dbfull()->TEST_WaitForCompact();
  3264. // Assert that the files stay in the same level
  3265. ASSERT_EQ("3", FilesPerLevel());
  3266. // The two old files go through the periodic compaction process
  3267. ASSERT_EQ(2, periodic_compactions);
  3268. MoveFilesToLevel(1);
  3269. ASSERT_EQ("0,3", FilesPerLevel());
  3270. // Add another 50 hours and do another write
  3271. env_->addon_time_.fetch_add(50 * 60 * 60);
  3272. ASSERT_OK(Put("b", "2"));
  3273. if (if_restart) {
  3274. Reopen(options);
  3275. } else {
  3276. Flush();
  3277. }
  3278. dbfull()->TEST_WaitForCompact();
  3279. ASSERT_EQ("1,3", FilesPerLevel());
  3280. // The three old files now go through the periodic compaction process. 2
  3281. // + 3.
  3282. ASSERT_EQ(5, periodic_compactions);
  3283. // Add another 50 hours and do another write
  3284. env_->addon_time_.fetch_add(50 * 60 * 60);
  3285. ASSERT_OK(Put("c", "3"));
  3286. Flush();
  3287. dbfull()->TEST_WaitForCompact();
  3288. ASSERT_EQ("2,3", FilesPerLevel());
  3289. // The four old files now go through the periodic compaction process. 5
  3290. // + 4.
  3291. ASSERT_EQ(9, periodic_compactions);
  3292. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3293. }
  3294. }
  3295. }
  3296. TEST_F(DBCompactionTest, LevelPeriodicCompactionWithOldDB) {
  3297. // This test makes sure that periodic compactions are working with a DB
  3298. // where file_creation_time of some files is 0.
  3299. // After compactions the new files are created with a valid file_creation_time
  3300. const int kNumKeysPerFile = 32;
  3301. const int kNumFiles = 4;
  3302. const int kValueSize = 100;
  3303. Options options = CurrentOptions();
  3304. env_->time_elapse_only_sleep_ = false;
  3305. options.env = env_;
  3306. env_->addon_time_.store(0);
  3307. DestroyAndReopen(options);
  3308. int periodic_compactions = 0;
  3309. bool set_file_creation_time_to_zero = true;
  3310. bool set_creation_time_to_zero = true;
  3311. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3312. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3313. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3314. auto compaction_reason = compaction->compaction_reason();
  3315. if (compaction_reason == CompactionReason::kPeriodicCompaction) {
  3316. periodic_compactions++;
  3317. }
  3318. });
  3319. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3320. "PropertyBlockBuilder::AddTableProperty:Start", [&](void* arg) {
  3321. TableProperties* props = reinterpret_cast<TableProperties*>(arg);
  3322. if (set_file_creation_time_to_zero) {
  3323. props->file_creation_time = 0;
  3324. }
  3325. if (set_creation_time_to_zero) {
  3326. props->creation_time = 0;
  3327. }
  3328. });
  3329. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3330. Random rnd(301);
  3331. for (int i = 0; i < kNumFiles; ++i) {
  3332. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3333. ASSERT_OK(
  3334. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  3335. }
  3336. Flush();
  3337. // Move the first two files to L2.
  3338. if (i == 1) {
  3339. MoveFilesToLevel(2);
  3340. set_creation_time_to_zero = false;
  3341. }
  3342. }
  3343. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  3344. ASSERT_EQ("2,0,2", FilesPerLevel());
  3345. ASSERT_EQ(0, periodic_compactions);
  3346. Close();
  3347. set_file_creation_time_to_zero = false;
  3348. // Forward the clock by 2 days.
  3349. env_->addon_time_.fetch_add(2 * 24 * 60 * 60);
  3350. options.periodic_compaction_seconds = 1 * 24 * 60 * 60; // 1 day
  3351. Reopen(options);
  3352. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  3353. ASSERT_EQ("2,0,2", FilesPerLevel());
  3354. // Make sure that all files go through periodic compaction.
  3355. ASSERT_EQ(kNumFiles, periodic_compactions);
  3356. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3357. }
  3358. TEST_F(DBCompactionTest, LevelPeriodicAndTtlCompaction) {
  3359. const int kNumKeysPerFile = 32;
  3360. const int kNumLevelFiles = 2;
  3361. const int kValueSize = 100;
  3362. Options options = CurrentOptions();
  3363. options.ttl = 10 * 60 * 60; // 10 hours
  3364. options.periodic_compaction_seconds = 48 * 60 * 60; // 2 days
  3365. options.max_open_files = -1; // needed for both periodic and ttl compactions
  3366. env_->time_elapse_only_sleep_ = false;
  3367. options.env = env_;
  3368. env_->addon_time_.store(0);
  3369. DestroyAndReopen(options);
  3370. int periodic_compactions = 0;
  3371. int ttl_compactions = 0;
  3372. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3373. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3374. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3375. auto compaction_reason = compaction->compaction_reason();
  3376. if (compaction_reason == CompactionReason::kPeriodicCompaction) {
  3377. periodic_compactions++;
  3378. } else if (compaction_reason == CompactionReason::kTtl) {
  3379. ttl_compactions++;
  3380. }
  3381. });
  3382. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3383. Random rnd(301);
  3384. for (int i = 0; i < kNumLevelFiles; ++i) {
  3385. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3386. ASSERT_OK(
  3387. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  3388. }
  3389. Flush();
  3390. }
  3391. dbfull()->TEST_WaitForCompact();
  3392. MoveFilesToLevel(3);
  3393. ASSERT_EQ("0,0,0,2", FilesPerLevel());
  3394. ASSERT_EQ(0, periodic_compactions);
  3395. ASSERT_EQ(0, ttl_compactions);
  3396. // Add some time greater than periodic_compaction_time.
  3397. env_->addon_time_.fetch_add(50 * 60 * 60);
  3398. ASSERT_OK(Put("a", "1"));
  3399. Flush();
  3400. dbfull()->TEST_WaitForCompact();
  3401. // Files in the bottom level go through periodic compactions.
  3402. ASSERT_EQ("1,0,0,2", FilesPerLevel());
  3403. ASSERT_EQ(2, periodic_compactions);
  3404. ASSERT_EQ(0, ttl_compactions);
  3405. // Add a little more time than ttl
  3406. env_->addon_time_.fetch_add(11 * 60 * 60);
  3407. ASSERT_OK(Put("b", "1"));
  3408. Flush();
  3409. dbfull()->TEST_WaitForCompact();
  3410. // Notice that the previous file in level 1 falls down to the bottom level
  3411. // due to ttl compactions, one level at a time.
  3412. // And bottom level files don't get picked up for ttl compactions.
  3413. ASSERT_EQ("1,0,0,3", FilesPerLevel());
  3414. ASSERT_EQ(2, periodic_compactions);
  3415. ASSERT_EQ(3, ttl_compactions);
  3416. // Add some time greater than periodic_compaction_time.
  3417. env_->addon_time_.fetch_add(50 * 60 * 60);
  3418. ASSERT_OK(Put("c", "1"));
  3419. Flush();
  3420. dbfull()->TEST_WaitForCompact();
  3421. // Previous L0 file falls one level at a time to bottom level due to ttl.
  3422. // And all 4 bottom files go through periodic compactions.
  3423. ASSERT_EQ("1,0,0,4", FilesPerLevel());
  3424. ASSERT_EQ(6, periodic_compactions);
  3425. ASSERT_EQ(6, ttl_compactions);
  3426. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3427. }
  3428. TEST_F(DBCompactionTest, LevelPeriodicCompactionWithCompactionFilters) {
  3429. class TestCompactionFilter : public CompactionFilter {
  3430. const char* Name() const override { return "TestCompactionFilter"; }
  3431. };
  3432. class TestCompactionFilterFactory : public CompactionFilterFactory {
  3433. const char* Name() const override { return "TestCompactionFilterFactory"; }
  3434. std::unique_ptr<CompactionFilter> CreateCompactionFilter(
  3435. const CompactionFilter::Context& /*context*/) override {
  3436. return std::unique_ptr<CompactionFilter>(new TestCompactionFilter());
  3437. }
  3438. };
  3439. const int kNumKeysPerFile = 32;
  3440. const int kNumLevelFiles = 2;
  3441. const int kValueSize = 100;
  3442. Random rnd(301);
  3443. Options options = CurrentOptions();
  3444. TestCompactionFilter test_compaction_filter;
  3445. env_->time_elapse_only_sleep_ = false;
  3446. options.env = env_;
  3447. env_->addon_time_.store(0);
  3448. enum CompactionFilterType {
  3449. kUseCompactionFilter,
  3450. kUseCompactionFilterFactory
  3451. };
  3452. for (CompactionFilterType comp_filter_type :
  3453. {kUseCompactionFilter, kUseCompactionFilterFactory}) {
  3454. // Assert that periodic compactions are not enabled.
  3455. ASSERT_EQ(port::kMaxUint64 - 1, options.periodic_compaction_seconds);
  3456. if (comp_filter_type == kUseCompactionFilter) {
  3457. options.compaction_filter = &test_compaction_filter;
  3458. options.compaction_filter_factory.reset();
  3459. } else if (comp_filter_type == kUseCompactionFilterFactory) {
  3460. options.compaction_filter = nullptr;
  3461. options.compaction_filter_factory.reset(
  3462. new TestCompactionFilterFactory());
  3463. }
  3464. DestroyAndReopen(options);
  3465. // periodic_compaction_seconds should be set to the sanitized value when
  3466. // a compaction filter or a compaction filter factory is used.
  3467. ASSERT_EQ(30 * 24 * 60 * 60,
  3468. dbfull()->GetOptions().periodic_compaction_seconds);
  3469. int periodic_compactions = 0;
  3470. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3471. "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) {
  3472. Compaction* compaction = reinterpret_cast<Compaction*>(arg);
  3473. auto compaction_reason = compaction->compaction_reason();
  3474. if (compaction_reason == CompactionReason::kPeriodicCompaction) {
  3475. periodic_compactions++;
  3476. }
  3477. });
  3478. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3479. for (int i = 0; i < kNumLevelFiles; ++i) {
  3480. for (int j = 0; j < kNumKeysPerFile; ++j) {
  3481. ASSERT_OK(
  3482. Put(Key(i * kNumKeysPerFile + j), RandomString(&rnd, kValueSize)));
  3483. }
  3484. Flush();
  3485. }
  3486. dbfull()->TEST_WaitForCompact();
  3487. ASSERT_EQ("2", FilesPerLevel());
  3488. ASSERT_EQ(0, periodic_compactions);
  3489. // Add 31 days and do a write
  3490. env_->addon_time_.fetch_add(31 * 24 * 60 * 60);
  3491. ASSERT_OK(Put("a", "1"));
  3492. Flush();
  3493. dbfull()->TEST_WaitForCompact();
  3494. // Assert that the files stay in the same level
  3495. ASSERT_EQ("3", FilesPerLevel());
  3496. // The two old files go through the periodic compaction process
  3497. ASSERT_EQ(2, periodic_compactions);
  3498. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3499. }
  3500. }
  3501. TEST_F(DBCompactionTest, CompactRangeDelayedByL0FileCount) {
  3502. // Verify that, when `CompactRangeOptions::allow_write_stall == false`, manual
  3503. // compaction only triggers flush after it's sure stall won't be triggered for
  3504. // L0 file count going too high.
  3505. const int kNumL0FilesTrigger = 4;
  3506. const int kNumL0FilesLimit = 8;
  3507. // i == 0: verifies normal case where stall is avoided by delay
  3508. // i == 1: verifies no delay in edge case where stall trigger is same as
  3509. // compaction trigger, so stall can't be avoided
  3510. for (int i = 0; i < 2; ++i) {
  3511. Options options = CurrentOptions();
  3512. options.level0_slowdown_writes_trigger = kNumL0FilesLimit;
  3513. if (i == 0) {
  3514. options.level0_file_num_compaction_trigger = kNumL0FilesTrigger;
  3515. } else {
  3516. options.level0_file_num_compaction_trigger = kNumL0FilesLimit;
  3517. }
  3518. Reopen(options);
  3519. if (i == 0) {
  3520. // ensure the auto compaction doesn't finish until manual compaction has
  3521. // had a chance to be delayed.
  3522. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3523. {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait",
  3524. "CompactionJob::Run():End"}});
  3525. } else {
  3526. // ensure the auto-compaction doesn't finish until manual compaction has
  3527. // continued without delay.
  3528. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3529. {{"DBImpl::FlushMemTable:StallWaitDone",
  3530. "CompactionJob::Run():End"}});
  3531. }
  3532. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3533. Random rnd(301);
  3534. for (int j = 0; j < kNumL0FilesLimit - 1; ++j) {
  3535. for (int k = 0; k < 2; ++k) {
  3536. ASSERT_OK(Put(Key(k), RandomString(&rnd, 1024)));
  3537. }
  3538. Flush();
  3539. }
  3540. auto manual_compaction_thread = port::Thread([this]() {
  3541. CompactRangeOptions cro;
  3542. cro.allow_write_stall = false;
  3543. db_->CompactRange(cro, nullptr, nullptr);
  3544. });
  3545. manual_compaction_thread.join();
  3546. dbfull()->TEST_WaitForCompact();
  3547. ASSERT_EQ(0, NumTableFilesAtLevel(0));
  3548. ASSERT_GT(NumTableFilesAtLevel(1), 0);
  3549. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3550. }
  3551. }
  3552. TEST_F(DBCompactionTest, CompactRangeDelayedByImmMemTableCount) {
  3553. // Verify that, when `CompactRangeOptions::allow_write_stall == false`, manual
  3554. // compaction only triggers flush after it's sure stall won't be triggered for
  3555. // immutable memtable count going too high.
  3556. const int kNumImmMemTableLimit = 8;
  3557. // i == 0: verifies normal case where stall is avoided by delay
  3558. // i == 1: verifies no delay in edge case where stall trigger is same as flush
  3559. // trigger, so stall can't be avoided
  3560. for (int i = 0; i < 2; ++i) {
  3561. Options options = CurrentOptions();
  3562. options.disable_auto_compactions = true;
  3563. // the delay limit is one less than the stop limit. This test focuses on
  3564. // avoiding delay limit, but this option sets stop limit, so add one.
  3565. options.max_write_buffer_number = kNumImmMemTableLimit + 1;
  3566. if (i == 1) {
  3567. options.min_write_buffer_number_to_merge = kNumImmMemTableLimit;
  3568. }
  3569. Reopen(options);
  3570. if (i == 0) {
  3571. // ensure the flush doesn't finish until manual compaction has had a
  3572. // chance to be delayed.
  3573. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3574. {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait",
  3575. "FlushJob::WriteLevel0Table"}});
  3576. } else {
  3577. // ensure the flush doesn't finish until manual compaction has continued
  3578. // without delay.
  3579. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3580. {{"DBImpl::FlushMemTable:StallWaitDone",
  3581. "FlushJob::WriteLevel0Table"}});
  3582. }
  3583. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3584. Random rnd(301);
  3585. for (int j = 0; j < kNumImmMemTableLimit - 1; ++j) {
  3586. ASSERT_OK(Put(Key(0), RandomString(&rnd, 1024)));
  3587. FlushOptions flush_opts;
  3588. flush_opts.wait = false;
  3589. flush_opts.allow_write_stall = true;
  3590. dbfull()->Flush(flush_opts);
  3591. }
  3592. auto manual_compaction_thread = port::Thread([this]() {
  3593. CompactRangeOptions cro;
  3594. cro.allow_write_stall = false;
  3595. db_->CompactRange(cro, nullptr, nullptr);
  3596. });
  3597. manual_compaction_thread.join();
  3598. dbfull()->TEST_WaitForFlushMemTable();
  3599. ASSERT_EQ(0, NumTableFilesAtLevel(0));
  3600. ASSERT_GT(NumTableFilesAtLevel(1), 0);
  3601. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3602. }
  3603. }
  3604. TEST_F(DBCompactionTest, CompactRangeShutdownWhileDelayed) {
  3605. // Verify that, when `CompactRangeOptions::allow_write_stall == false`, delay
  3606. // does not hang if CF is dropped or DB is closed
  3607. const int kNumL0FilesTrigger = 4;
  3608. const int kNumL0FilesLimit = 8;
  3609. Options options = CurrentOptions();
  3610. options.level0_file_num_compaction_trigger = kNumL0FilesTrigger;
  3611. options.level0_slowdown_writes_trigger = kNumL0FilesLimit;
  3612. // i == 0: DB::DropColumnFamily() on CompactRange's target CF unblocks it
  3613. // i == 1: DB::CancelAllBackgroundWork() unblocks CompactRange. This is to
  3614. // simulate what happens during Close as we can't call Close (it
  3615. // blocks on the auto-compaction, making a cycle).
  3616. for (int i = 0; i < 2; ++i) {
  3617. CreateAndReopenWithCF({"one"}, options);
  3618. // The calls to close CF/DB wait until the manual compaction stalls.
  3619. // The auto-compaction waits until the manual compaction finishes to ensure
  3620. // the signal comes from closing CF/DB, not from compaction making progress.
  3621. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3622. {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait",
  3623. "DBCompactionTest::CompactRangeShutdownWhileDelayed:PreShutdown"},
  3624. {"DBCompactionTest::CompactRangeShutdownWhileDelayed:PostManual",
  3625. "CompactionJob::Run():End"}});
  3626. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3627. Random rnd(301);
  3628. for (int j = 0; j < kNumL0FilesLimit - 1; ++j) {
  3629. for (int k = 0; k < 2; ++k) {
  3630. ASSERT_OK(Put(1, Key(k), RandomString(&rnd, 1024)));
  3631. }
  3632. Flush(1);
  3633. }
  3634. auto manual_compaction_thread = port::Thread([this, i]() {
  3635. CompactRangeOptions cro;
  3636. cro.allow_write_stall = false;
  3637. Status s = db_->CompactRange(cro, handles_[1], nullptr, nullptr);
  3638. if (i == 0) {
  3639. ASSERT_TRUE(db_->CompactRange(cro, handles_[1], nullptr, nullptr)
  3640. .IsColumnFamilyDropped());
  3641. } else {
  3642. ASSERT_TRUE(db_->CompactRange(cro, handles_[1], nullptr, nullptr)
  3643. .IsShutdownInProgress());
  3644. }
  3645. });
  3646. TEST_SYNC_POINT(
  3647. "DBCompactionTest::CompactRangeShutdownWhileDelayed:PreShutdown");
  3648. if (i == 0) {
  3649. ASSERT_OK(db_->DropColumnFamily(handles_[1]));
  3650. } else {
  3651. dbfull()->CancelAllBackgroundWork(false /* wait */);
  3652. }
  3653. manual_compaction_thread.join();
  3654. TEST_SYNC_POINT(
  3655. "DBCompactionTest::CompactRangeShutdownWhileDelayed:PostManual");
  3656. dbfull()->TEST_WaitForCompact();
  3657. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3658. }
  3659. }
  3660. TEST_F(DBCompactionTest, CompactRangeSkipFlushAfterDelay) {
  3661. // Verify that, when `CompactRangeOptions::allow_write_stall == false`,
  3662. // CompactRange skips its flush if the delay is long enough that the memtables
  3663. // existing at the beginning of the call have already been flushed.
  3664. const int kNumL0FilesTrigger = 4;
  3665. const int kNumL0FilesLimit = 8;
  3666. Options options = CurrentOptions();
  3667. options.level0_slowdown_writes_trigger = kNumL0FilesLimit;
  3668. options.level0_file_num_compaction_trigger = kNumL0FilesTrigger;
  3669. Reopen(options);
  3670. Random rnd(301);
  3671. // The manual flush includes the memtable that was active when CompactRange
  3672. // began. So it unblocks CompactRange and precludes its flush. Throughout the
  3673. // test, stall conditions are upheld via high L0 file count.
  3674. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  3675. {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait",
  3676. "DBCompactionTest::CompactRangeSkipFlushAfterDelay:PreFlush"},
  3677. {"DBCompactionTest::CompactRangeSkipFlushAfterDelay:PostFlush",
  3678. "DBImpl::FlushMemTable:StallWaitDone"},
  3679. {"DBImpl::FlushMemTable:StallWaitDone", "CompactionJob::Run():End"}});
  3680. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3681. //used for the delayable flushes
  3682. FlushOptions flush_opts;
  3683. flush_opts.allow_write_stall = true;
  3684. for (int i = 0; i < kNumL0FilesLimit - 1; ++i) {
  3685. for (int j = 0; j < 2; ++j) {
  3686. ASSERT_OK(Put(Key(j), RandomString(&rnd, 1024)));
  3687. }
  3688. dbfull()->Flush(flush_opts);
  3689. }
  3690. auto manual_compaction_thread = port::Thread([this]() {
  3691. CompactRangeOptions cro;
  3692. cro.allow_write_stall = false;
  3693. db_->CompactRange(cro, nullptr, nullptr);
  3694. });
  3695. TEST_SYNC_POINT("DBCompactionTest::CompactRangeSkipFlushAfterDelay:PreFlush");
  3696. Put(ToString(0), RandomString(&rnd, 1024));
  3697. dbfull()->Flush(flush_opts);
  3698. Put(ToString(0), RandomString(&rnd, 1024));
  3699. TEST_SYNC_POINT("DBCompactionTest::CompactRangeSkipFlushAfterDelay:PostFlush");
  3700. manual_compaction_thread.join();
  3701. // If CompactRange's flush was skipped, the final Put above will still be
  3702. // in the active memtable.
  3703. std::string num_keys_in_memtable;
  3704. db_->GetProperty(DB::Properties::kNumEntriesActiveMemTable, &num_keys_in_memtable);
  3705. ASSERT_EQ(ToString(1), num_keys_in_memtable);
  3706. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  3707. }
  3708. TEST_F(DBCompactionTest, CompactRangeFlushOverlappingMemtable) {
  3709. // Verify memtable only gets flushed if it contains data overlapping the range
  3710. // provided to `CompactRange`. Tests all kinds of overlap/non-overlap.
  3711. const int kNumEndpointKeys = 5;
  3712. std::string keys[kNumEndpointKeys] = {"a", "b", "c", "d", "e"};
  3713. Options options = CurrentOptions();
  3714. options.disable_auto_compactions = true;
  3715. Reopen(options);
  3716. // One extra iteration for nullptr, which means left side of interval is
  3717. // unbounded.
  3718. for (int i = 0; i <= kNumEndpointKeys; ++i) {
  3719. Slice begin;
  3720. Slice* begin_ptr;
  3721. if (i == 0) {
  3722. begin_ptr = nullptr;
  3723. } else {
  3724. begin = keys[i - 1];
  3725. begin_ptr = &begin;
  3726. }
  3727. // Start at `i` so right endpoint comes after left endpoint. One extra
  3728. // iteration for nullptr, which means right side of interval is unbounded.
  3729. for (int j = std::max(0, i - 1); j <= kNumEndpointKeys; ++j) {
  3730. Slice end;
  3731. Slice* end_ptr;
  3732. if (j == kNumEndpointKeys) {
  3733. end_ptr = nullptr;
  3734. } else {
  3735. end = keys[j];
  3736. end_ptr = &end;
  3737. }
  3738. ASSERT_OK(Put("b", "val"));
  3739. ASSERT_OK(Put("d", "val"));
  3740. CompactRangeOptions compact_range_opts;
  3741. ASSERT_OK(db_->CompactRange(compact_range_opts, begin_ptr, end_ptr));
  3742. uint64_t get_prop_tmp, num_memtable_entries = 0;
  3743. ASSERT_TRUE(db_->GetIntProperty(DB::Properties::kNumEntriesImmMemTables,
  3744. &get_prop_tmp));
  3745. num_memtable_entries += get_prop_tmp;
  3746. ASSERT_TRUE(db_->GetIntProperty(DB::Properties::kNumEntriesActiveMemTable,
  3747. &get_prop_tmp));
  3748. num_memtable_entries += get_prop_tmp;
  3749. if (begin_ptr == nullptr || end_ptr == nullptr ||
  3750. (i <= 4 && j >= 1 && (begin != "c" || end != "c"))) {
  3751. // In this case `CompactRange`'s range overlapped in some way with the
  3752. // memtable's range, so flush should've happened. Then "b" and "d" won't
  3753. // be in the memtable.
  3754. ASSERT_EQ(0, num_memtable_entries);
  3755. } else {
  3756. ASSERT_EQ(2, num_memtable_entries);
  3757. // flush anyways to prepare for next iteration
  3758. db_->Flush(FlushOptions());
  3759. }
  3760. }
  3761. }
  3762. }
  3763. TEST_F(DBCompactionTest, CompactionStatsTest) {
  3764. Options options = CurrentOptions();
  3765. options.level0_file_num_compaction_trigger = 2;
  3766. CompactionStatsCollector* collector = new CompactionStatsCollector();
  3767. options.listeners.emplace_back(collector);
  3768. DestroyAndReopen(options);
  3769. for (int i = 0; i < 32; i++) {
  3770. for (int j = 0; j < 5000; j++) {
  3771. Put(std::to_string(j), std::string(1, 'A'));
  3772. }
  3773. ASSERT_OK(Flush());
  3774. ASSERT_OK(dbfull()->TEST_WaitForFlushMemTable());
  3775. }
  3776. dbfull()->TEST_WaitForCompact();
  3777. ColumnFamilyHandleImpl* cfh =
  3778. static_cast<ColumnFamilyHandleImpl*>(dbfull()->DefaultColumnFamily());
  3779. ColumnFamilyData* cfd = cfh->cfd();
  3780. VerifyCompactionStats(*cfd, *collector);
  3781. }
  3782. TEST_F(DBCompactionTest, CompactFilesOutputRangeConflict) {
  3783. // LSM setup:
  3784. // L1: [ba bz]
  3785. // L2: [a b] [c d]
  3786. // L3: [a b] [c d]
  3787. //
  3788. // Thread 1: Thread 2:
  3789. // Begin compacting all L2->L3
  3790. // Compact [ba bz] L1->L3
  3791. // End compacting all L2->L3
  3792. //
  3793. // The compaction operation in thread 2 should be disallowed because the range
  3794. // overlaps with the compaction in thread 1, which also covers that range in
  3795. // L3.
  3796. Options options = CurrentOptions();
  3797. FlushedFileCollector* collector = new FlushedFileCollector();
  3798. options.listeners.emplace_back(collector);
  3799. Reopen(options);
  3800. for (int level = 3; level >= 2; --level) {
  3801. ASSERT_OK(Put("a", "val"));
  3802. ASSERT_OK(Put("b", "val"));
  3803. ASSERT_OK(Flush());
  3804. ASSERT_OK(Put("c", "val"));
  3805. ASSERT_OK(Put("d", "val"));
  3806. ASSERT_OK(Flush());
  3807. MoveFilesToLevel(level);
  3808. }
  3809. ASSERT_OK(Put("ba", "val"));
  3810. ASSERT_OK(Put("bz", "val"));
  3811. ASSERT_OK(Flush());
  3812. MoveFilesToLevel(1);
  3813. SyncPoint::GetInstance()->LoadDependency({
  3814. {"CompactFilesImpl:0",
  3815. "DBCompactionTest::CompactFilesOutputRangeConflict:Thread2Begin"},
  3816. {"DBCompactionTest::CompactFilesOutputRangeConflict:Thread2End",
  3817. "CompactFilesImpl:1"},
  3818. });
  3819. SyncPoint::GetInstance()->EnableProcessing();
  3820. auto bg_thread = port::Thread([&]() {
  3821. // Thread 1
  3822. std::vector<std::string> filenames = collector->GetFlushedFiles();
  3823. filenames.pop_back();
  3824. ASSERT_OK(db_->CompactFiles(CompactionOptions(), filenames,
  3825. 3 /* output_level */));
  3826. });
  3827. // Thread 2
  3828. TEST_SYNC_POINT(
  3829. "DBCompactionTest::CompactFilesOutputRangeConflict:Thread2Begin");
  3830. std::string filename = collector->GetFlushedFiles().back();
  3831. ASSERT_FALSE(
  3832. db_->CompactFiles(CompactionOptions(), {filename}, 3 /* output_level */)
  3833. .ok());
  3834. TEST_SYNC_POINT(
  3835. "DBCompactionTest::CompactFilesOutputRangeConflict:Thread2End");
  3836. bg_thread.join();
  3837. }
  3838. TEST_F(DBCompactionTest, CompactionHasEmptyOutput) {
  3839. Options options = CurrentOptions();
  3840. SstStatsCollector* collector = new SstStatsCollector();
  3841. options.level0_file_num_compaction_trigger = 2;
  3842. options.listeners.emplace_back(collector);
  3843. Reopen(options);
  3844. // Make sure the L0 files overlap to prevent trivial move.
  3845. ASSERT_OK(Put("a", "val"));
  3846. ASSERT_OK(Put("b", "val"));
  3847. ASSERT_OK(Flush());
  3848. ASSERT_OK(Delete("a"));
  3849. ASSERT_OK(Delete("b"));
  3850. ASSERT_OK(Flush());
  3851. dbfull()->TEST_WaitForCompact();
  3852. ASSERT_EQ(NumTableFilesAtLevel(0), 0);
  3853. ASSERT_EQ(NumTableFilesAtLevel(1), 0);
  3854. // Expect one file creation to start for each flush, and zero for compaction
  3855. // since no keys are written.
  3856. ASSERT_EQ(2, collector->num_ssts_creation_started());
  3857. }
  3858. TEST_F(DBCompactionTest, CompactionLimiter) {
  3859. const int kNumKeysPerFile = 10;
  3860. const int kMaxBackgroundThreads = 64;
  3861. struct CompactionLimiter {
  3862. std::string name;
  3863. int limit_tasks;
  3864. int max_tasks;
  3865. int tasks;
  3866. std::shared_ptr<ConcurrentTaskLimiter> limiter;
  3867. };
  3868. std::vector<CompactionLimiter> limiter_settings;
  3869. limiter_settings.push_back({"limiter_1", 1, 0, 0, nullptr});
  3870. limiter_settings.push_back({"limiter_2", 2, 0, 0, nullptr});
  3871. limiter_settings.push_back({"limiter_3", 3, 0, 0, nullptr});
  3872. for (auto& ls : limiter_settings) {
  3873. ls.limiter.reset(NewConcurrentTaskLimiter(ls.name, ls.limit_tasks));
  3874. }
  3875. std::shared_ptr<ConcurrentTaskLimiter> unique_limiter(
  3876. NewConcurrentTaskLimiter("unique_limiter", -1));
  3877. const char* cf_names[] = {"default", "0", "1", "2", "3", "4", "5",
  3878. "6", "7", "8", "9", "a", "b", "c", "d", "e", "f" };
  3879. const unsigned int cf_count = sizeof cf_names / sizeof cf_names[0];
  3880. std::unordered_map<std::string, CompactionLimiter*> cf_to_limiter;
  3881. Options options = CurrentOptions();
  3882. options.write_buffer_size = 110 * 1024; // 110KB
  3883. options.arena_block_size = 4096;
  3884. options.num_levels = 3;
  3885. options.level0_file_num_compaction_trigger = 4;
  3886. options.level0_slowdown_writes_trigger = 64;
  3887. options.level0_stop_writes_trigger = 64;
  3888. options.max_background_jobs = kMaxBackgroundThreads; // Enough threads
  3889. options.memtable_factory.reset(new SpecialSkipListFactory(kNumKeysPerFile));
  3890. options.max_write_buffer_number = 10; // Enough memtables
  3891. DestroyAndReopen(options);
  3892. std::vector<Options> option_vector;
  3893. option_vector.reserve(cf_count);
  3894. for (unsigned int cf = 0; cf < cf_count; cf++) {
  3895. ColumnFamilyOptions cf_opt(options);
  3896. if (cf == 0) {
  3897. // "Default" CF does't use compaction limiter
  3898. cf_opt.compaction_thread_limiter = nullptr;
  3899. } else if (cf == 1) {
  3900. // "1" CF uses bypass compaction limiter
  3901. unique_limiter->SetMaxOutstandingTask(-1);
  3902. cf_opt.compaction_thread_limiter = unique_limiter;
  3903. } else {
  3904. // Assign limiter by mod
  3905. auto& ls = limiter_settings[cf % 3];
  3906. cf_opt.compaction_thread_limiter = ls.limiter;
  3907. cf_to_limiter[cf_names[cf]] = &ls;
  3908. }
  3909. option_vector.emplace_back(DBOptions(options), cf_opt);
  3910. }
  3911. for (unsigned int cf = 1; cf < cf_count; cf++) {
  3912. CreateColumnFamilies({cf_names[cf]}, option_vector[cf]);
  3913. }
  3914. ReopenWithColumnFamilies(std::vector<std::string>(cf_names,
  3915. cf_names + cf_count),
  3916. option_vector);
  3917. port::Mutex mutex;
  3918. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3919. "DBImpl::BackgroundCompaction:BeforeCompaction", [&](void* arg) {
  3920. const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName();
  3921. auto iter = cf_to_limiter.find(cf_name);
  3922. if (iter != cf_to_limiter.end()) {
  3923. MutexLock l(&mutex);
  3924. ASSERT_GE(iter->second->limit_tasks, ++iter->second->tasks);
  3925. iter->second->max_tasks =
  3926. std::max(iter->second->max_tasks, iter->second->limit_tasks);
  3927. }
  3928. });
  3929. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  3930. "DBImpl::BackgroundCompaction:AfterCompaction", [&](void* arg) {
  3931. const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName();
  3932. auto iter = cf_to_limiter.find(cf_name);
  3933. if (iter != cf_to_limiter.end()) {
  3934. MutexLock l(&mutex);
  3935. ASSERT_GE(--iter->second->tasks, 0);
  3936. }
  3937. });
  3938. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  3939. // Block all compact threads in thread pool.
  3940. const size_t kTotalFlushTasks = kMaxBackgroundThreads / 4;
  3941. const size_t kTotalCompactTasks = kMaxBackgroundThreads - kTotalFlushTasks;
  3942. env_->SetBackgroundThreads((int)kTotalFlushTasks, Env::HIGH);
  3943. env_->SetBackgroundThreads((int)kTotalCompactTasks, Env::LOW);
  3944. test::SleepingBackgroundTask sleeping_compact_tasks[kTotalCompactTasks];
  3945. // Block all compaction threads in thread pool.
  3946. for (size_t i = 0; i < kTotalCompactTasks; i++) {
  3947. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask,
  3948. &sleeping_compact_tasks[i], Env::LOW);
  3949. sleeping_compact_tasks[i].WaitUntilSleeping();
  3950. }
  3951. int keyIndex = 0;
  3952. for (int n = 0; n < options.level0_file_num_compaction_trigger; n++) {
  3953. for (unsigned int cf = 0; cf < cf_count; cf++) {
  3954. for (int i = 0; i < kNumKeysPerFile; i++) {
  3955. ASSERT_OK(Put(cf, Key(keyIndex++), ""));
  3956. }
  3957. // put extra key to trigger flush
  3958. ASSERT_OK(Put(cf, "", ""));
  3959. }
  3960. for (unsigned int cf = 0; cf < cf_count; cf++) {
  3961. dbfull()->TEST_WaitForFlushMemTable(handles_[cf]);
  3962. }
  3963. }
  3964. // Enough L0 files to trigger compaction
  3965. for (unsigned int cf = 0; cf < cf_count; cf++) {
  3966. ASSERT_EQ(NumTableFilesAtLevel(0, cf),
  3967. options.level0_file_num_compaction_trigger);
  3968. }
  3969. // Create more files for one column family, which triggers speed up
  3970. // condition, all compactions will be scheduled.
  3971. for (int num = 0; num < options.level0_file_num_compaction_trigger; num++) {
  3972. for (int i = 0; i < kNumKeysPerFile; i++) {
  3973. ASSERT_OK(Put(0, Key(i), ""));
  3974. }
  3975. // put extra key to trigger flush
  3976. ASSERT_OK(Put(0, "", ""));
  3977. dbfull()->TEST_WaitForFlushMemTable(handles_[0]);
  3978. ASSERT_EQ(options.level0_file_num_compaction_trigger + num + 1,
  3979. NumTableFilesAtLevel(0, 0));
  3980. }
  3981. // All CFs are pending compaction
  3982. ASSERT_EQ(cf_count, env_->GetThreadPoolQueueLen(Env::LOW));
  3983. // Unblock all compaction threads
  3984. for (size_t i = 0; i < kTotalCompactTasks; i++) {
  3985. sleeping_compact_tasks[i].WakeUp();
  3986. sleeping_compact_tasks[i].WaitUntilDone();
  3987. }
  3988. for (unsigned int cf = 0; cf < cf_count; cf++) {
  3989. dbfull()->TEST_WaitForFlushMemTable(handles_[cf]);
  3990. }
  3991. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  3992. // Max outstanding compact tasks reached limit
  3993. for (auto& ls : limiter_settings) {
  3994. ASSERT_EQ(ls.limit_tasks, ls.max_tasks);
  3995. ASSERT_EQ(0, ls.limiter->GetOutstandingTask());
  3996. }
  3997. // test manual compaction under a fully throttled limiter
  3998. int cf_test = 1;
  3999. unique_limiter->SetMaxOutstandingTask(0);
  4000. // flush one more file to cf 1
  4001. for (int i = 0; i < kNumKeysPerFile; i++) {
  4002. ASSERT_OK(Put(cf_test, Key(keyIndex++), ""));
  4003. }
  4004. // put extra key to trigger flush
  4005. ASSERT_OK(Put(cf_test, "", ""));
  4006. dbfull()->TEST_WaitForFlushMemTable(handles_[cf_test]);
  4007. ASSERT_EQ(1, NumTableFilesAtLevel(0, cf_test));
  4008. Compact(cf_test, Key(0), Key(keyIndex));
  4009. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  4010. }
  4011. INSTANTIATE_TEST_CASE_P(DBCompactionTestWithParam, DBCompactionTestWithParam,
  4012. ::testing::Values(std::make_tuple(1, true),
  4013. std::make_tuple(1, false),
  4014. std::make_tuple(4, true),
  4015. std::make_tuple(4, false)));
  4016. TEST_P(DBCompactionDirectIOTest, DirectIO) {
  4017. Options options = CurrentOptions();
  4018. Destroy(options);
  4019. options.create_if_missing = true;
  4020. options.disable_auto_compactions = true;
  4021. options.use_direct_io_for_flush_and_compaction = GetParam();
  4022. options.env = new MockEnv(Env::Default());
  4023. Reopen(options);
  4024. bool readahead = false;
  4025. SyncPoint::GetInstance()->SetCallBack(
  4026. "CompactionJob::OpenCompactionOutputFile", [&](void* arg) {
  4027. bool* use_direct_writes = static_cast<bool*>(arg);
  4028. ASSERT_EQ(*use_direct_writes,
  4029. options.use_direct_io_for_flush_and_compaction);
  4030. });
  4031. if (options.use_direct_io_for_flush_and_compaction) {
  4032. SyncPoint::GetInstance()->SetCallBack(
  4033. "SanitizeOptions:direct_io", [&](void* /*arg*/) {
  4034. readahead = true;
  4035. });
  4036. }
  4037. SyncPoint::GetInstance()->EnableProcessing();
  4038. CreateAndReopenWithCF({"pikachu"}, options);
  4039. MakeTables(3, "p", "q", 1);
  4040. ASSERT_EQ("1,1,1", FilesPerLevel(1));
  4041. Compact(1, "p1", "p9");
  4042. ASSERT_EQ(readahead, options.use_direct_reads);
  4043. ASSERT_EQ("0,0,1", FilesPerLevel(1));
  4044. Destroy(options);
  4045. delete options.env;
  4046. }
  4047. INSTANTIATE_TEST_CASE_P(DBCompactionDirectIOTest, DBCompactionDirectIOTest,
  4048. testing::Bool());
  4049. class CompactionPriTest : public DBTestBase,
  4050. public testing::WithParamInterface<uint32_t> {
  4051. public:
  4052. CompactionPriTest() : DBTestBase("/compaction_pri_test") {
  4053. compaction_pri_ = GetParam();
  4054. }
  4055. // Required if inheriting from testing::WithParamInterface<>
  4056. static void SetUpTestCase() {}
  4057. static void TearDownTestCase() {}
  4058. uint32_t compaction_pri_;
  4059. };
  4060. TEST_P(CompactionPriTest, Test) {
  4061. Options options = CurrentOptions();
  4062. options.write_buffer_size = 16 * 1024;
  4063. options.compaction_pri = static_cast<CompactionPri>(compaction_pri_);
  4064. options.hard_pending_compaction_bytes_limit = 256 * 1024;
  4065. options.max_bytes_for_level_base = 64 * 1024;
  4066. options.max_bytes_for_level_multiplier = 4;
  4067. options.compression = kNoCompression;
  4068. DestroyAndReopen(options);
  4069. Random rnd(301);
  4070. const int kNKeys = 5000;
  4071. int keys[kNKeys];
  4072. for (int i = 0; i < kNKeys; i++) {
  4073. keys[i] = i;
  4074. }
  4075. std::random_shuffle(std::begin(keys), std::end(keys));
  4076. for (int i = 0; i < kNKeys; i++) {
  4077. ASSERT_OK(Put(Key(keys[i]), RandomString(&rnd, 102)));
  4078. }
  4079. dbfull()->TEST_WaitForCompact();
  4080. for (int i = 0; i < kNKeys; i++) {
  4081. ASSERT_NE("NOT_FOUND", Get(Key(i)));
  4082. }
  4083. }
  4084. INSTANTIATE_TEST_CASE_P(
  4085. CompactionPriTest, CompactionPriTest,
  4086. ::testing::Values(CompactionPri::kByCompensatedSize,
  4087. CompactionPri::kOldestLargestSeqFirst,
  4088. CompactionPri::kOldestSmallestSeqFirst,
  4089. CompactionPri::kMinOverlappingRatio));
  4090. class NoopMergeOperator : public MergeOperator {
  4091. public:
  4092. NoopMergeOperator() {}
  4093. bool FullMergeV2(const MergeOperationInput& /*merge_in*/,
  4094. MergeOperationOutput* merge_out) const override {
  4095. std::string val("bar");
  4096. merge_out->new_value = val;
  4097. return true;
  4098. }
  4099. const char* Name() const override { return "Noop"; }
  4100. };
  4101. TEST_F(DBCompactionTest, PartialManualCompaction) {
  4102. Options opts = CurrentOptions();
  4103. opts.num_levels = 3;
  4104. opts.level0_file_num_compaction_trigger = 10;
  4105. opts.compression = kNoCompression;
  4106. opts.merge_operator.reset(new NoopMergeOperator());
  4107. opts.target_file_size_base = 10240;
  4108. DestroyAndReopen(opts);
  4109. Random rnd(301);
  4110. for (auto i = 0; i < 8; ++i) {
  4111. for (auto j = 0; j < 10; ++j) {
  4112. Merge("foo", RandomString(&rnd, 1024));
  4113. }
  4114. Flush();
  4115. }
  4116. MoveFilesToLevel(2);
  4117. std::string prop;
  4118. EXPECT_TRUE(dbfull()->GetProperty(DB::Properties::kLiveSstFilesSize, &prop));
  4119. uint64_t max_compaction_bytes = atoi(prop.c_str()) / 2;
  4120. ASSERT_OK(dbfull()->SetOptions(
  4121. {{"max_compaction_bytes", std::to_string(max_compaction_bytes)}}));
  4122. CompactRangeOptions cro;
  4123. cro.bottommost_level_compaction = BottommostLevelCompaction::kForceOptimized;
  4124. dbfull()->CompactRange(cro, nullptr, nullptr);
  4125. }
  4126. TEST_F(DBCompactionTest, ManualCompactionFailsInReadOnlyMode) {
  4127. // Regression test for bug where manual compaction hangs forever when the DB
  4128. // is in read-only mode. Verify it now at least returns, despite failing.
  4129. const int kNumL0Files = 4;
  4130. std::unique_ptr<FaultInjectionTestEnv> mock_env(
  4131. new FaultInjectionTestEnv(Env::Default()));
  4132. Options opts = CurrentOptions();
  4133. opts.disable_auto_compactions = true;
  4134. opts.env = mock_env.get();
  4135. DestroyAndReopen(opts);
  4136. Random rnd(301);
  4137. for (int i = 0; i < kNumL0Files; ++i) {
  4138. // Make sure files are overlapping in key-range to prevent trivial move.
  4139. Put("key1", RandomString(&rnd, 1024));
  4140. Put("key2", RandomString(&rnd, 1024));
  4141. Flush();
  4142. }
  4143. ASSERT_EQ(kNumL0Files, NumTableFilesAtLevel(0));
  4144. // Enter read-only mode by failing a write.
  4145. mock_env->SetFilesystemActive(false);
  4146. // Make sure this is outside `CompactRange`'s range so that it doesn't fail
  4147. // early trying to flush memtable.
  4148. ASSERT_NOK(Put("key3", RandomString(&rnd, 1024)));
  4149. // In the bug scenario, the first manual compaction would fail and forget to
  4150. // unregister itself, causing the second one to hang forever due to conflict
  4151. // with a non-running compaction.
  4152. CompactRangeOptions cro;
  4153. cro.exclusive_manual_compaction = false;
  4154. Slice begin_key("key1");
  4155. Slice end_key("key2");
  4156. ASSERT_NOK(dbfull()->CompactRange(cro, &begin_key, &end_key));
  4157. ASSERT_NOK(dbfull()->CompactRange(cro, &begin_key, &end_key));
  4158. // Close before mock_env destruct.
  4159. Close();
  4160. }
  4161. // ManualCompactionBottomLevelOptimization tests the bottom level manual
  4162. // compaction optimization to skip recompacting files created by Ln-1 to Ln
  4163. // compaction
  4164. TEST_F(DBCompactionTest, ManualCompactionBottomLevelOptimized) {
  4165. Options opts = CurrentOptions();
  4166. opts.num_levels = 3;
  4167. opts.level0_file_num_compaction_trigger = 5;
  4168. opts.compression = kNoCompression;
  4169. opts.merge_operator.reset(new NoopMergeOperator());
  4170. opts.target_file_size_base = 1024;
  4171. opts.max_bytes_for_level_multiplier = 2;
  4172. opts.disable_auto_compactions = true;
  4173. DestroyAndReopen(opts);
  4174. ColumnFamilyHandleImpl* cfh =
  4175. static_cast<ColumnFamilyHandleImpl*>(dbfull()->DefaultColumnFamily());
  4176. ColumnFamilyData* cfd = cfh->cfd();
  4177. InternalStats* internal_stats_ptr = cfd->internal_stats();
  4178. ASSERT_NE(internal_stats_ptr, nullptr);
  4179. Random rnd(301);
  4180. for (auto i = 0; i < 8; ++i) {
  4181. for (auto j = 0; j < 10; ++j) {
  4182. ASSERT_OK(
  4183. Put("foo" + std::to_string(i * 10 + j), RandomString(&rnd, 1024)));
  4184. }
  4185. Flush();
  4186. }
  4187. MoveFilesToLevel(2);
  4188. for (auto i = 0; i < 8; ++i) {
  4189. for (auto j = 0; j < 10; ++j) {
  4190. ASSERT_OK(
  4191. Put("bar" + std::to_string(i * 10 + j), RandomString(&rnd, 1024)));
  4192. }
  4193. Flush();
  4194. }
  4195. const std::vector<InternalStats::CompactionStats>& comp_stats =
  4196. internal_stats_ptr->TEST_GetCompactionStats();
  4197. int num = comp_stats[2].num_input_files_in_output_level;
  4198. ASSERT_EQ(num, 0);
  4199. CompactRangeOptions cro;
  4200. cro.bottommost_level_compaction = BottommostLevelCompaction::kForceOptimized;
  4201. dbfull()->CompactRange(cro, nullptr, nullptr);
  4202. const std::vector<InternalStats::CompactionStats>& comp_stats2 =
  4203. internal_stats_ptr->TEST_GetCompactionStats();
  4204. num = comp_stats2[2].num_input_files_in_output_level;
  4205. ASSERT_EQ(num, 0);
  4206. }
  4207. TEST_F(DBCompactionTest, CompactionDuringShutdown) {
  4208. Options opts = CurrentOptions();
  4209. opts.level0_file_num_compaction_trigger = 2;
  4210. opts.disable_auto_compactions = true;
  4211. DestroyAndReopen(opts);
  4212. ColumnFamilyHandleImpl* cfh =
  4213. static_cast<ColumnFamilyHandleImpl*>(dbfull()->DefaultColumnFamily());
  4214. ColumnFamilyData* cfd = cfh->cfd();
  4215. InternalStats* internal_stats_ptr = cfd->internal_stats();
  4216. ASSERT_NE(internal_stats_ptr, nullptr);
  4217. Random rnd(301);
  4218. for (auto i = 0; i < 2; ++i) {
  4219. for (auto j = 0; j < 10; ++j) {
  4220. ASSERT_OK(
  4221. Put("foo" + std::to_string(i * 10 + j), RandomString(&rnd, 1024)));
  4222. }
  4223. Flush();
  4224. }
  4225. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  4226. "DBImpl::BackgroundCompaction:NonTrivial:BeforeRun",
  4227. [&](void* /*arg*/) { dbfull()->shutting_down_.store(true); });
  4228. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  4229. dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr);
  4230. ASSERT_OK(dbfull()->error_handler_.GetBGError());
  4231. }
  4232. // FixFileIngestionCompactionDeadlock tests and verifies that compaction and
  4233. // file ingestion do not cause deadlock in the event of write stall triggered
  4234. // by number of L0 files reaching level0_stop_writes_trigger.
  4235. TEST_P(DBCompactionTestWithParam, FixFileIngestionCompactionDeadlock) {
  4236. const int kNumKeysPerFile = 100;
  4237. // Generate SST files.
  4238. Options options = CurrentOptions();
  4239. // Generate an external SST file containing a single key, i.e. 99
  4240. std::string sst_files_dir = dbname_ + "/sst_files/";
  4241. test::DestroyDir(env_, sst_files_dir);
  4242. ASSERT_OK(env_->CreateDir(sst_files_dir));
  4243. SstFileWriter sst_writer(EnvOptions(), options);
  4244. const std::string sst_file_path = sst_files_dir + "test.sst";
  4245. ASSERT_OK(sst_writer.Open(sst_file_path));
  4246. ASSERT_OK(sst_writer.Put(Key(kNumKeysPerFile - 1), "value"));
  4247. ASSERT_OK(sst_writer.Finish());
  4248. SyncPoint::GetInstance()->DisableProcessing();
  4249. SyncPoint::GetInstance()->ClearAllCallBacks();
  4250. SyncPoint::GetInstance()->LoadDependency({
  4251. {"DBImpl::IngestExternalFile:AfterIncIngestFileCounter",
  4252. "BackgroundCallCompaction:0"},
  4253. });
  4254. SyncPoint::GetInstance()->EnableProcessing();
  4255. options.write_buffer_size = 110 << 10; // 110KB
  4256. options.level0_file_num_compaction_trigger =
  4257. options.level0_stop_writes_trigger;
  4258. options.max_subcompactions = max_subcompactions_;
  4259. options.memtable_factory.reset(new SpecialSkipListFactory(kNumKeysPerFile));
  4260. DestroyAndReopen(options);
  4261. Random rnd(301);
  4262. // Generate level0_stop_writes_trigger L0 files to trigger write stop
  4263. for (int i = 0; i != options.level0_file_num_compaction_trigger; ++i) {
  4264. for (int j = 0; j != kNumKeysPerFile; ++j) {
  4265. ASSERT_OK(Put(Key(j), RandomString(&rnd, 990)));
  4266. }
  4267. if (0 == i) {
  4268. // When we reach here, the memtables have kNumKeysPerFile keys. Note that
  4269. // flush is not yet triggered. We need to write an extra key so that the
  4270. // write path will call PreprocessWrite and flush the previous key-value
  4271. // pairs to e flushed. After that, there will be the newest key in the
  4272. // memtable, and a bunch of L0 files. Since there is already one key in
  4273. // the memtable, then for i = 1, 2, ..., we do not have to write this
  4274. // extra key to trigger flush.
  4275. ASSERT_OK(Put("", ""));
  4276. }
  4277. dbfull()->TEST_WaitForFlushMemTable();
  4278. ASSERT_EQ(NumTableFilesAtLevel(0 /*level*/, 0 /*cf*/), i + 1);
  4279. }
  4280. // When we reach this point, there will be level0_stop_writes_trigger L0
  4281. // files and one extra key (99) in memory, which overlaps with the external
  4282. // SST file. Write stall triggers, and can be cleared only after compaction
  4283. // reduces the number of L0 files.
  4284. // Compaction will also be triggered since we have reached the threshold for
  4285. // auto compaction. Note that compaction may begin after the following file
  4286. // ingestion thread and waits for ingestion to finish.
  4287. // Thread to ingest file with overlapping key range with the current
  4288. // memtable. Consequently ingestion will trigger a flush. The flush MUST
  4289. // proceed without waiting for the write stall condition to clear, otherwise
  4290. // deadlock can happen.
  4291. port::Thread ingestion_thr([&]() {
  4292. IngestExternalFileOptions ifo;
  4293. Status s = db_->IngestExternalFile({sst_file_path}, ifo);
  4294. ASSERT_OK(s);
  4295. });
  4296. // More write to trigger write stop
  4297. ingestion_thr.join();
  4298. ASSERT_OK(dbfull()->TEST_WaitForCompact());
  4299. Close();
  4300. }
  4301. TEST_F(DBCompactionTest, ConsistencyFailTest) {
  4302. Options options = CurrentOptions();
  4303. DestroyAndReopen(options);
  4304. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  4305. "VersionBuilder::CheckConsistency", [&](void* arg) {
  4306. auto p =
  4307. reinterpret_cast<std::pair<FileMetaData**, FileMetaData**>*>(arg);
  4308. // just swap the two FileMetaData so that we hit error
  4309. // in CheckConsistency funcion
  4310. FileMetaData* temp = *(p->first);
  4311. *(p->first) = *(p->second);
  4312. *(p->second) = temp;
  4313. });
  4314. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  4315. for (int k = 0; k < 2; ++k) {
  4316. ASSERT_OK(Put("foo", "bar"));
  4317. Flush();
  4318. }
  4319. ASSERT_NOK(Put("foo", "bar"));
  4320. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  4321. }
  4322. void IngestOneKeyValue(DBImpl* db, const std::string& key,
  4323. const std::string& value, const Options& options) {
  4324. ExternalSstFileInfo info;
  4325. std::string f = test::PerThreadDBPath("sst_file" + key);
  4326. EnvOptions env;
  4327. ROCKSDB_NAMESPACE::SstFileWriter writer(env, options);
  4328. auto s = writer.Open(f);
  4329. ASSERT_OK(s);
  4330. // ASSERT_OK(writer.Put(Key(), ""));
  4331. ASSERT_OK(writer.Put(key, value));
  4332. ASSERT_OK(writer.Finish(&info));
  4333. IngestExternalFileOptions ingest_opt;
  4334. ASSERT_OK(db->IngestExternalFile({info.file_path}, ingest_opt));
  4335. }
  4336. TEST_P(DBCompactionTestWithParam,
  4337. FlushAfterIntraL0CompactionCheckConsistencyFail) {
  4338. Options options = CurrentOptions();
  4339. options.force_consistency_checks = true;
  4340. options.compression = kNoCompression;
  4341. options.level0_file_num_compaction_trigger = 5;
  4342. options.max_background_compactions = 2;
  4343. options.max_subcompactions = max_subcompactions_;
  4344. DestroyAndReopen(options);
  4345. const size_t kValueSize = 1 << 20;
  4346. Random rnd(301);
  4347. std::atomic<int> pick_intra_l0_count(0);
  4348. std::string value(RandomString(&rnd, kValueSize));
  4349. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  4350. {{"DBCompactionTestWithParam::FlushAfterIntraL0:1",
  4351. "CompactionJob::Run():Start"}});
  4352. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  4353. "FindIntraL0Compaction",
  4354. [&](void* /*arg*/) { pick_intra_l0_count.fetch_add(1); });
  4355. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  4356. // prevents trivial move
  4357. for (int i = 0; i < 10; ++i) {
  4358. ASSERT_OK(Put(Key(i), "")); // prevents trivial move
  4359. }
  4360. ASSERT_OK(Flush());
  4361. Compact("", Key(99));
  4362. ASSERT_EQ(0, NumTableFilesAtLevel(0));
  4363. // Flush 5 L0 sst.
  4364. for (int i = 0; i < 5; ++i) {
  4365. ASSERT_OK(Put(Key(i + 1), value));
  4366. ASSERT_OK(Flush());
  4367. }
  4368. ASSERT_EQ(5, NumTableFilesAtLevel(0));
  4369. // Put one key, to make smallest log sequence number in this memtable is less
  4370. // than sst which would be ingested in next step.
  4371. ASSERT_OK(Put(Key(0), "a"));
  4372. ASSERT_EQ(5, NumTableFilesAtLevel(0));
  4373. // Ingest 5 L0 sst. And this files would trigger PickIntraL0Compaction.
  4374. for (int i = 5; i < 10; i++) {
  4375. IngestOneKeyValue(dbfull(), Key(i), value, options);
  4376. ASSERT_EQ(i + 1, NumTableFilesAtLevel(0));
  4377. }
  4378. TEST_SYNC_POINT("DBCompactionTestWithParam::FlushAfterIntraL0:1");
  4379. // Put one key, to make biggest log sequence number in this memtable is bigger
  4380. // than sst which would be ingested in next step.
  4381. ASSERT_OK(Put(Key(2), "b"));
  4382. ASSERT_EQ(10, NumTableFilesAtLevel(0));
  4383. dbfull()->TEST_WaitForCompact();
  4384. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  4385. std::vector<std::vector<FileMetaData>> level_to_files;
  4386. dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(),
  4387. &level_to_files);
  4388. ASSERT_GT(level_to_files[0].size(), 0);
  4389. ASSERT_GT(pick_intra_l0_count.load(), 0);
  4390. ASSERT_OK(Flush());
  4391. }
  4392. TEST_P(DBCompactionTestWithParam,
  4393. IntraL0CompactionAfterFlushCheckConsistencyFail) {
  4394. Options options = CurrentOptions();
  4395. options.force_consistency_checks = true;
  4396. options.compression = kNoCompression;
  4397. options.level0_file_num_compaction_trigger = 5;
  4398. options.max_background_compactions = 2;
  4399. options.max_subcompactions = max_subcompactions_;
  4400. options.write_buffer_size = 2 << 20;
  4401. options.max_write_buffer_number = 6;
  4402. DestroyAndReopen(options);
  4403. const size_t kValueSize = 1 << 20;
  4404. Random rnd(301);
  4405. std::string value(RandomString(&rnd, kValueSize));
  4406. std::string value2(RandomString(&rnd, kValueSize));
  4407. std::string bigvalue = value + value;
  4408. // prevents trivial move
  4409. for (int i = 0; i < 10; ++i) {
  4410. ASSERT_OK(Put(Key(i), "")); // prevents trivial move
  4411. }
  4412. ASSERT_OK(Flush());
  4413. Compact("", Key(99));
  4414. ASSERT_EQ(0, NumTableFilesAtLevel(0));
  4415. std::atomic<int> pick_intra_l0_count(0);
  4416. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency(
  4417. {{"DBCompactionTestWithParam::IntraL0CompactionAfterFlush:1",
  4418. "CompactionJob::Run():Start"}});
  4419. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
  4420. "FindIntraL0Compaction",
  4421. [&](void* /*arg*/) { pick_intra_l0_count.fetch_add(1); });
  4422. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
  4423. // Make 6 L0 sst.
  4424. for (int i = 0; i < 6; ++i) {
  4425. if (i % 2 == 0) {
  4426. IngestOneKeyValue(dbfull(), Key(i), value, options);
  4427. } else {
  4428. ASSERT_OK(Put(Key(i), value));
  4429. ASSERT_OK(Flush());
  4430. }
  4431. }
  4432. ASSERT_EQ(6, NumTableFilesAtLevel(0));
  4433. // Stop run flush job
  4434. env_->SetBackgroundThreads(1, Env::HIGH);
  4435. test::SleepingBackgroundTask sleeping_tasks;
  4436. env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask, &sleeping_tasks,
  4437. Env::Priority::HIGH);
  4438. sleeping_tasks.WaitUntilSleeping();
  4439. // Put many keys to make memtable request to flush
  4440. for (int i = 0; i < 6; ++i) {
  4441. ASSERT_OK(Put(Key(i), bigvalue));
  4442. }
  4443. ASSERT_EQ(6, NumTableFilesAtLevel(0));
  4444. // ingest file to trigger IntraL0Compaction
  4445. for (int i = 6; i < 10; ++i) {
  4446. ASSERT_EQ(i, NumTableFilesAtLevel(0));
  4447. IngestOneKeyValue(dbfull(), Key(i), value2, options);
  4448. }
  4449. ASSERT_EQ(10, NumTableFilesAtLevel(0));
  4450. // Wake up flush job
  4451. sleeping_tasks.WakeUp();
  4452. sleeping_tasks.WaitUntilDone();
  4453. TEST_SYNC_POINT("DBCompactionTestWithParam::IntraL0CompactionAfterFlush:1");
  4454. dbfull()->TEST_WaitForCompact();
  4455. ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();
  4456. uint64_t error_count = 0;
  4457. db_->GetIntProperty("rocksdb.background-errors", &error_count);
  4458. ASSERT_EQ(error_count, 0);
  4459. ASSERT_GT(pick_intra_l0_count.load(), 0);
  4460. for (int i = 0; i < 6; ++i) {
  4461. ASSERT_EQ(bigvalue, Get(Key(i)));
  4462. }
  4463. for (int i = 6; i < 10; ++i) {
  4464. ASSERT_EQ(value2, Get(Key(i)));
  4465. }
  4466. }
  4467. #endif // !defined(ROCKSDB_LITE)
  4468. } // namespace ROCKSDB_NAMESPACE
  4469. int main(int argc, char** argv) {
  4470. #if !defined(ROCKSDB_LITE)
  4471. ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
  4472. ::testing::InitGoogleTest(&argc, argv);
  4473. return RUN_ALL_TESTS();
  4474. #else
  4475. (void) argc;
  4476. (void) argv;
  4477. return 0;
  4478. #endif
  4479. }